Received-SPF: pass (google.com: domain of linux-kernel+bounces-128649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 2 Apr 2024 22:21:18 +0200
From: Borislav Petkov <bp@alien8.de>
To: "Kalra, Ashish" <ashish.kalra@amd.com>
Cc: bp@kernel.org, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
	linux-tip-commits@vger.kernel.org, michael.roth@amd.com,
	x86@kernel.org
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Message-ID: <20240402202118.GCZgxovu-pgPKYvner@fat_crate.local>
References: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
 <20240402163412.19325-1-bp@kernel.org>
 <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
 <359264a1-e4ef-438c-8f24-32848e131272@amd.com>
 <20240402174540.GAZgxERNxsRJUCb1yp@fat_crate.local>
 <37321af9-aee4-4ba6-81ac-0df4cef38644@amd.com>
 <20240402185039.GBZgxTfwvEP45OxVjm@fat_crate.local>
 <8daf448f-eb52-4b1f-9f98-099a83665321@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8daf448f-eb52-4b1f-9f98-099a83665321@amd.com>

On Tue, Apr 02, 2024 at 02:33:44PM -0500, Kalra, Ashish wrote:
> And we can't do this in snp_rmptable_init() as e820_table_firmware can't be
> fixed at that point and by that time this table has been mapped into sysfs
> (/sys/firmware) which is used by kexec -c variant.

Well, you have to do something here because if snp_rmptable_init()
late-disables SNP, your RMP table fixups are moot and invalid.

Which means, your RMP table fixups need to happen at the *very* *late*
step after we know that SNP is enabled and won't get disabled anymore.

I.e., in snp_rmptable_init().

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette