Received-SPF: pass (google.com: domain of linux-kernel+bounces-128681-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Cc: ahmed.zaki@intel.com,
	aleksander.lobakin@intel.com,
	alexandre.torgue@foss.st.com,
	andrew@lunn.ch,
	cjubran@nvidia.com,
	corbet@lwn.net,
	davem@davemloft.net,
	dtatulea@nvidia.com,
	edumazet@google.com,
	gal@nvidia.com,
	hkallweit1@gmail.com,
	jacob.e.keller@intel.com,
	jiri@resnulli.us,
	joabreu@synopsys.com,
	justinstitt@google.com,
	kory.maincent@bootlin.com,
	kuba@kernel.org,
	leon@kernel.org,
	liuhangbin@gmail.com,
	maxime.chevallier@bootlin.com,
	pabeni@redhat.com,
	paul.greenwalt@intel.com,
	przemyslaw.kitszel@intel.com,
	rdunlap@infradead.org,
	richardcochran@gmail.com,
	saeed@kernel.org,
	tariqt@nvidia.com,
	vadim.fedorenko@linux.dev,
	vladimir.oltean@nxp.com,
	wojciech.drewek@intel.com,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH net-next v1 4/6] net/mlx5e: Implement ethtool hardware timestamping statistics
Date: Tue,  2 Apr 2024 13:52:04 -0700
Message-ID: <20240402205223.137565-5-rrameshbabu@nvidia.com>
In-Reply-To: <20240402205223.137565-1-rrameshbabu@nvidia.com>
References: <20240402205223.137565-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WBKeA+OqUdHb0mcQEm9nTlpg5BWDUwJYmLEbKYIw7bZuWimfpLTdn4nXBO5G?=
 =?us-ascii?Q?gFhqiFb5dSm05b4s0LaFWJBboY/HuLjMjHWTm1aOhldECLp0Zz4A+m01FlK8?=
 =?us-ascii?Q?KQoQ81Ek4KRCrqd2lrFtCbxPUN2okZGi5tZ60YFiZQPxl/5bxkBrsmaj3UFr?=
 =?us-ascii?Q?DY+YyaZIrMK6ly3zDLRMYPPqofsilzUReFlp0Y5Uadl32XFwU8z+n+jIuzx/?=
 =?us-ascii?Q?/iyYjwNPhxCwUXr68jyTXzs9OK+Pr8juhmvND5JIALabnakWS1Flf4upjltz?=
 =?us-ascii?Q?ruzHV/Td85uhN19NMCVBBh7QlYDdCcvG3lx925MhBdzHa7qVYmzLUkoljVfJ?=
 =?us-ascii?Q?7ZiQlGyJU7xOvhZOjaTJWc6ud2riI63oQdN79aUoXXBETdh1ViSThvGZEOVs?=
 =?us-ascii?Q?n+q94K6huDEtZQ30NWna1+Z5vAU9wT5LhVwBtQu4heW3xKiHfUtxguro6V6w?=
 =?us-ascii?Q?ZWMg5TcZjUIknaB615WrUlIqz2aa+cbYM1AjbnZ+Rxi3nMLN5t61EEiXwaP1?=
 =?us-ascii?Q?IDpOJW1N5Zr4S8EwjqiHITlji8MW8/UlSQNtFKZC/GhTVkNXpyZbi/De74Ip?=
 =?us-ascii?Q?HoxsSuzB7p4V0izmSCiJ0P5bN2Yduy54Ow7vRWyK86XHoPKylu/udOR3/z4G?=
 =?us-ascii?Q?BJxcsWT+wb1lkENCTnfIGczKUlV1mWUIcQd5riilmSNg1ize62VoQdash0HB?=
 =?us-ascii?Q?8vai4UPY3mH7Ur4L9Ni14CjvYwKbtc2dvq1M1O39xUgs6DMBkv38FDnLx3ua?=
 =?us-ascii?Q?1CU3g0lMC8Y4cNQjc9rrc9epEyV7BcvdKXhnLbqRwQ+RgAet6AvVV7Saoped?=
 =?us-ascii?Q?XuaoM9bYYnx1rN8VDu7hSZY7caJehdy6Vrf1B6YABFkrjRGe69zqAIoi+6RQ?=
 =?us-ascii?Q?qO8llFvYOdmXxPAOQqn8BRnE0uFmlnc7NrtwYdv2sXog5xdMSnh9kiV4+7KK?=
 =?us-ascii?Q?Tzh8VcL8EmY7Nx8D3cXyeGI1+9E0FmuS/yqxVYv0uDkDakNvfjkQrjJeATxm?=
 =?us-ascii?Q?JmneZh2IXHtpKRf7Wudu2AKGuh7OeKa0lX3mYGMZIVESNPCIZP1NvJoGUMxm?=
 =?us-ascii?Q?dDaqhySagsWRxiXxtjlqYD382U0mbdlfJ6yaIfiO0NclrYaiCeUYKJcMGJmH?=
 =?us-ascii?Q?x66CILAdCg/GhzI3MoevcWIiaPmzYuXtiWfbCzJwfIjW4RgNf0KuScjfH+tV?=
 =?us-ascii?Q?hjeLzX3Pos9w9GjU6UTzSDygNTNr6/pFbRMMlNYGthYyqEiqcHJFXP5MBFKI?=
 =?us-ascii?Q?oHYjc6t8ZZr51X+rYcgkQ5Mfbs/EjGxJPWEImKAPIiBD2v5G2FnkcB1A51Ee?=
 =?us-ascii?Q?NJ660Nqqi3Uv/ypzVNKQSyCJ6CtCGD6EKjIlezf/uIS6gWwE5UdiNja/L6sm?=
 =?us-ascii?Q?LHQRXGj3u5/ARnXlA9i0RquOS0lFl1OtQT0FFgRx4NF8thxHAdHq1BoBeSuk?=
 =?us-ascii?Q?Xc+7U+1eyL/N+rtMPaoVUdHxOE2ijRfW1bqYyzKDf8/K70HU2/2rUh095xlG?=
 =?us-ascii?Q?w2YZabMc0T+/k57qA2UnLh90reFsoHqFGGoNsT7h0p7xL8E/dFxC3maR7jOP?=
 =?us-ascii?Q?8Nxpr59IlPJKfrN5nwskm0wSzZHUkAbPJ82yn2DPFv35a5raPunXqvh5mdcP?=
 =?us-ascii?Q?kg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2d00c8d-c309-4fa5-1de1-08dc5356cf84
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 20:52:29.5182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r+QBEox+JE6loSZtzZjW66c0Y0/wgQtAdc7YwXhM/M5N8levHtzAj4+szb+Zwpkuh+ienLwDgZNyug4q58TBJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4393

Feed driver statistics counters related to hardware timestamping to
standardized ethtool hardware timestamping statistics group.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
---
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  9 ++++
 .../ethernet/mellanox/mlx5/core/en_stats.c    | 45 +++++++++++++++++++
 .../ethernet/mellanox/mlx5/core/en_stats.h    |  2 +
 3 files changed, 56 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
index cc51ce16df14..d3b77054c30a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
@@ -2381,6 +2381,14 @@ static void mlx5e_get_rmon_stats(struct net_device *netdev,
 	mlx5e_stats_rmon_get(priv, rmon_stats, ranges);
 }
 
+static void mlx5e_get_ts_stats(struct net_device *netdev,
+			       struct ethtool_ts_stats *ts_stats)
+{
+	struct mlx5e_priv *priv = netdev_priv(netdev);
+
+	mlx5e_stats_ts_get(priv, ts_stats);
+}
+
 const struct ethtool_ops mlx5e_ethtool_ops = {
 	.cap_rss_ctx_supported	= true,
 	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
@@ -2430,5 +2438,6 @@ const struct ethtool_ops mlx5e_ethtool_ops = {
 	.get_eth_mac_stats = mlx5e_get_eth_mac_stats,
 	.get_eth_ctrl_stats = mlx5e_get_eth_ctrl_stats,
 	.get_rmon_stats    = mlx5e_get_rmon_stats,
+	.get_ts_stats      = mlx5e_get_ts_stats,
 	.get_link_ext_stats = mlx5e_get_link_ext_stats
 };
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index a06c6c80e36f..d8cf1fe99fb0 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -1172,6 +1172,51 @@ void mlx5e_stats_rmon_get(struct mlx5e_priv *priv,
 	*ranges = mlx5e_rmon_ranges;
 }
 
+void mlx5e_stats_ts_get(struct mlx5e_priv *priv,
+			struct ethtool_ts_stats *ts_stats)
+{
+	int i, j;
+
+	mutex_lock(&priv->state_lock);
+
+	if (priv->tx_ptp_opened) {
+		struct mlx5e_ptp *ptp = priv->channels.ptp;
+
+		ts_stats->pkts = 0;
+		ts_stats->err = 0;
+		ts_stats->lost = 0;
+
+		/* Aggregate stats across all TCs */
+		for (i = 0; i < ptp->num_tc; i++) {
+			struct mlx5e_ptp_cq_stats *stats =
+				ptp->ptpsq[i].cq_stats;
+
+			ts_stats->pkts += stats->cqe;
+			ts_stats->err += stats->abort + stats->err_cqe +
+				stats->late_cqe;
+			ts_stats->lost += stats->lost_cqe;
+		}
+	} else {
+		/* DMA layer will always successfully timestamp packets. Other
+		 * counters do not make sense for this layer.
+		 */
+		ts_stats->pkts = 0;
+
+		/* Aggregate stats across all SQs */
+		for (j = 0; j < priv->channels.num; j++) {
+			struct mlx5e_channel *c = priv->channels.c[j];
+
+			for (i = 0; i < c->num_tc; i++) {
+				struct mlx5e_sq_stats *stats = c->sq[i].stats;
+
+				ts_stats->pkts += stats->timestamps;
+			}
+		}
+	}
+
+	mutex_unlock(&priv->state_lock);
+}
+
 #define PPORT_PHY_STATISTICAL_OFF(c) \
 	MLX5_BYTE_OFF(ppcnt_reg, \
 		      counter_set.phys_layer_statistical_cntrs.c##_high)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
index 3c634c5fd420..7b3e6cf1229a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
@@ -126,6 +126,8 @@ void mlx5e_stats_eth_ctrl_get(struct mlx5e_priv *priv,
 void mlx5e_stats_rmon_get(struct mlx5e_priv *priv,
 			  struct ethtool_rmon_stats *rmon,
 			  const struct ethtool_rmon_hist_range **ranges);
+void mlx5e_stats_ts_get(struct mlx5e_priv *priv,
+			struct ethtool_ts_stats *ts_stats);
 void mlx5e_get_link_ext_stats(struct net_device *dev,
 			      struct ethtool_link_ext_stats *stats);
 
-- 
2.42.0