Received-SPF: pass (google.com: domain of linux-kernel+bounces-128682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Cc: ahmed.zaki@intel.com,
	aleksander.lobakin@intel.com,
	alexandre.torgue@foss.st.com,
	andrew@lunn.ch,
	cjubran@nvidia.com,
	corbet@lwn.net,
	davem@davemloft.net,
	dtatulea@nvidia.com,
	edumazet@google.com,
	gal@nvidia.com,
	hkallweit1@gmail.com,
	jacob.e.keller@intel.com,
	jiri@resnulli.us,
	joabreu@synopsys.com,
	justinstitt@google.com,
	kory.maincent@bootlin.com,
	kuba@kernel.org,
	leon@kernel.org,
	liuhangbin@gmail.com,
	maxime.chevallier@bootlin.com,
	pabeni@redhat.com,
	paul.greenwalt@intel.com,
	przemyslaw.kitszel@intel.com,
	rdunlap@infradead.org,
	richardcochran@gmail.com,
	saeed@kernel.org,
	tariqt@nvidia.com,
	vadim.fedorenko@linux.dev,
	vladimir.oltean@nxp.com,
	wojciech.drewek@intel.com,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH net-next v1 5/6] netlink: specs: ethtool: add header-flags enumeration
Date: Tue,  2 Apr 2024 13:52:05 -0700
Message-ID: <20240402205223.137565-6-rrameshbabu@nvidia.com>
In-Reply-To: <20240402205223.137565-1-rrameshbabu@nvidia.com>
References: <20240402205223.137565-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vdX/32sAduWM8bQbg8WqWz88oAr5zMmneJSw3/+jKTDRqgeZaL3+yLaAAbJa?=
 =?us-ascii?Q?sRbxMfFw+gNnRdd7phAx9OH7vBMDcWQkJEW6c+DzQsGKjT8wP96hHi7AcrX2?=
 =?us-ascii?Q?Inc9JPtCjbaG0NjSAJlf1HktIxJgLrA/pamzkP7E0naiaLoXmXixQWItu98o?=
 =?us-ascii?Q?texHekfO29ISRxP9AqGtjfgf6SCnG5b3qBNorxkU0iKquUUsGp5ZfAtwJlg+?=
 =?us-ascii?Q?XGa1IyzxyJAHlbxPDbZ1+N1JOpTQduIZYsDAbQqj3cXK8xCV4pv5uMnL9gMx?=
 =?us-ascii?Q?SLzqlWRCvXNJXR+vs2pJPYq4fTW/R0e0RaA05t99qPoSYtaZky12yo/QjNal?=
 =?us-ascii?Q?fw/PMa9CPeEMN/Tnf+LVXtCOrObvbg5W0EU0OX21vlN92I67m7XjwqYKYBtb?=
 =?us-ascii?Q?uum69sOshMQiM2JFhVbeXkIwATQTk39q6CedHRsjOp/ebA0xifA5hRUMDK+u?=
 =?us-ascii?Q?4VoiCeMZ7OIKizXR2zBwGgwMNNedimslrS+vLPOEPOXAFGTQxvBofphWX/tv?=
 =?us-ascii?Q?DE6Eo87li8Mf8dKxZ7w/gtldBp8cU/ZW/ZKN+NWHjBXjhCCrd5Nrbz3rlgbN?=
 =?us-ascii?Q?P9o28F1BYdhr/9SKC056hzR9KjikQlIiN05oYDZxWKL5tApo/Q4UDUcR9KFp?=
 =?us-ascii?Q?auzkIYcTxlbB8EOtPCieCq4BCv/cd7ki3iVvOYOorAtFXs7Zcywe1HHcnJdw?=
 =?us-ascii?Q?wx6J00usejh/bmn9vpALAJXkctp/OJT5015N17JnslIG59d8hYKm8D9CIzTv?=
 =?us-ascii?Q?98XrUeyKGZMEYq/vVOuvZaDO4gJcC6CmKtL/N5nF46g+NBqKaKqSo7O1moik?=
 =?us-ascii?Q?mzrG5SjbUAFvphHKppHFAj0im1g2aFZSH8r2DxkOPvtWglK6lznSXqDpO2jG?=
 =?us-ascii?Q?a+2v2MxRf4nKD5aAlhHnCtWKiJy1AsVv+Vzv+pjSKmAdfNHNfcgj4JwB6nJb?=
 =?us-ascii?Q?0tOYjLapRC9kZ75dckIAudzdjGHIh8SwilF1/cckWHHs9vL7dizqYnkqZpGH?=
 =?us-ascii?Q?UqoYvlXADYXEgWo38EBEtHbpXmV3+5WvtcSCa7705XWduIy+kRqLhkpILMSw?=
 =?us-ascii?Q?A5b8KGvpYNdI7zY2BhfW7aghxrJ7r59DNtHEpcee19x85uBZm6MIblDWV3/X?=
 =?us-ascii?Q?UcmmhzJLFVp0st/jQa1295ZCO2bWKznJ5gLxszJh4csnLGVqQjkVWyTwnhsF?=
 =?us-ascii?Q?AsiYj/tOvlIPJLspd5vrC+47obfDT4BDA1VHFqtZlY2zGlREkPkcb0fDHQIQ?=
 =?us-ascii?Q?oR+cl1L4NtPRFZfgG7tZq5hrBDfR+Zdsc9oHUHrOaAHT+1Kgbx+5LSKyyS31?=
 =?us-ascii?Q?8SQXXiCtY5gchMyytd885+XzpbWZGzA0Yv44vWJQ4SKwP4ysX0O6razIfZHf?=
 =?us-ascii?Q?5afBpfsIQ+AhYR+U7ZWhygFS0TK3ajBX1+evVnCmuAMgGchmOvC+F2D5DFo0?=
 =?us-ascii?Q?z01mJUNpJFJIcSbR2ArFcQ65gAtLimFhchkGSxj5tiQxqoMh7cyz70FQFvn+?=
 =?us-ascii?Q?xM+j3dnX0tmqcUeLUqBQYpx0Q0yMplkKwjqoJbGBlYjT8XIjh00hqRW+oSKY?=
 =?us-ascii?Q?88aA6rujX7V1IgIa2kO6BY5afQ1foW+d6GmDISqOr30PaIE9AfUY6AVPl51K?=
 =?us-ascii?Q?mw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0880f769-3a49-4ec3-742f-08dc5356d033
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 20:52:30.6268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UMIc3mv/QpnD9t/z30B3QTSPT4FiI/6JkjFvqqFMg4Es0ERpehgr9NwINtTrXLAXwJ/GjnChP9jVczRtcSAzHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4393

Enable specifying header flags using enumerated entries in the spec file
rather than raw flag values.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
---
 Documentation/netlink/specs/ethtool.yaml |  5 +++++
 include/uapi/linux/ethtool_netlink.h     | 11 +++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index f5aa1e7f3383..bae3bb013787 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -16,6 +16,10 @@ definitions:
     name: stringset
     type: enum
     entries: []
+  -
+    name: header-flags
+    type: flags
+    entries: [ compact-bitset, omit-reply, stats ]
 
 attribute-sets:
   -
@@ -30,6 +34,7 @@ attribute-sets:
       -
         name: flags
         type: u32
+        enum: header-flags
 
   -
     name: bitset-bit
diff --git a/include/uapi/linux/ethtool_netlink.h b/include/uapi/linux/ethtool_netlink.h
index 8dfd714c2308..34a4a64262b2 100644
--- a/include/uapi/linux/ethtool_netlink.h
+++ b/include/uapi/linux/ethtool_netlink.h
@@ -117,12 +117,11 @@ enum {
 
 /* request header */
 
-/* use compact bitsets in reply */
-#define ETHTOOL_FLAG_COMPACT_BITSETS	(1 << 0)
-/* provide optional reply for SET or ACT requests */
-#define ETHTOOL_FLAG_OMIT_REPLY	(1 << 1)
-/* request statistics, if supported by the driver */
-#define ETHTOOL_FLAG_STATS		(1 << 2)
+enum ethtool_header_flags {
+	ETHTOOL_FLAG_COMPACT_BITSETS	= 1 << 0,	/* use compact bitsets in reply */
+	ETHTOOL_FLAG_OMIT_REPLY		= 1 << 1,	/* provide optional reply for SET or ACT requests */
+	ETHTOOL_FLAG_STATS		= 1 << 2,	/* request statistics, if supported by the driver */
+};
 
 #define ETHTOOL_FLAG_ALL (ETHTOOL_FLAG_COMPACT_BITSETS | \
 			  ETHTOOL_FLAG_OMIT_REPLY | \
-- 
2.42.0