Received-SPF: pass (google.com: domain of linux-kernel+bounces-128689-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <6fdb98f8-b4e2-474d-b8e9-c3092e77e56e@amd.com>
Date: Tue, 2 Apr 2024 16:00:03 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: bp@kernel.org, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
 linux-tip-commits@vger.kernel.org, michael.roth@amd.com, x86@kernel.org
References: <2ab14f6f-2690-056b-cf9e-38a12dafd728@amd.com>
 <20240402163412.19325-1-bp@kernel.org>
 <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
 <359264a1-e4ef-438c-8f24-32848e131272@amd.com>
 <20240402174540.GAZgxERNxsRJUCb1yp@fat_crate.local>
 <37321af9-aee4-4ba6-81ac-0df4cef38644@amd.com>
 <20240402185039.GBZgxTfwvEP45OxVjm@fat_crate.local>
 <8daf448f-eb52-4b1f-9f98-099a83665321@amd.com>
 <20240402202118.GCZgxovu-pgPKYvner@fat_crate.local>
From: "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <20240402202118.GCZgxovu-pgPKYvner@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Rzl6Qmx3VGkyY3pBUDhtVVNMR3VjSWdBbDF3elBrdFVXTTVLY0Fwc2VHRHlK?=
 =?utf-8?B?bUlnR2kyWFo2UXhnSS9FN2xRWDRzaEQ1dmtVUmdQRStoQnVZUDdITDRDYk5h?=
 =?utf-8?B?Nm9lNjNFYlhQS1p2TktVeExiODNLL0drYkJ6TzdvL3A1bTdUakkxclpiZlk5?=
 =?utf-8?B?YjBDU284cTN2MUZRVGdXc0xjQlJCOEhCR3hnVVNZOThIZmovbENtY0Y2a0RQ?=
 =?utf-8?B?Y3g1a2NLQ20rdForbjRVdG9icXpZVzRtY2R2eXdKcVAyWit2UVhHQ0VhVWs1?=
 =?utf-8?B?T0ZUZC8yQUlmQzhpOEJiZHFRV202Z2JVSCs0VWo3bWN6ajJJcWp2SnhhSFJj?=
 =?utf-8?B?VnpVd1paQStqTzVaaWc0Tkd3ejhKUndzY0UvOGpnTUNuL0UwT3g4RnNQNlhr?=
 =?utf-8?B?bE4zLzRSMjlBNTBodmRST2w3Z1NMVWsrMTNPMGZHa0o2dHZnNnJReXNqY2ZX?=
 =?utf-8?B?eStDdmZFM0loT2xyMTN4NzdHNWt6eTJYUVpEaFdxT2Z3TXl0MXhiMEkwUUpF?=
 =?utf-8?B?SHZrRGpheEFpbG1lZmZKckM2Ujl3WWNtL0dnOENOaTEzYjBETFl4Ni80b01Q?=
 =?utf-8?B?cTFyc3lsaHE5SHZzbXBoeU9UNk56VzcxaXVWMnd1RW96ZENveE5xMGJuc1FG?=
 =?utf-8?B?Mk0vb3JONkYxeE9TcFR6c3E2bkxjRXQzSFdqdW4wQ3ZEM09aWUw3bSs5SHB4?=
 =?utf-8?B?ZUR1dUxETTNzWTJWR2lZNFNTN2JqeTdvcWxJNHYxV2JRR1RZTklqUVcybENV?=
 =?utf-8?B?TlVESWEvUFJRem50MWlWRFRFV2hZKzFIRGRma0lPMENPbG5pL0Vhb1lHeXZp?=
 =?utf-8?B?UGhYSW83L3FuZS9YbTJ6b0NyN2hhQStGMlRIUlFEbDJiQXM5WnBWL1dOc3g0?=
 =?utf-8?B?OTVCNFdxaUFyQWRRUUJPNXcxblBhRWUwN2FVUnpRbmt0Q0QweUZqd0w2N1ll?=
 =?utf-8?B?NjhYYVl3SCtoQ01HYVhJUU5xREJsRmdtMDBRcFZrallqamovWEo2eWtjYVd5?=
 =?utf-8?B?V083V2VxZTlmU21tQ3luTkxsWTNoNXhVejF0TktLUjdBRmZ6R1BEdGl2YnR6?=
 =?utf-8?B?SjhsUTBpNEIwY2FzM1dXWWU1NURoSWxhbkJ3ZTNwa0JHaTFyNDhDQ2pSb3dU?=
 =?utf-8?B?eVVoSkNTby9zTm53UkttaTM2RC9udU9zUWxvMDhERVJNQmlKOUR6Vkt5Vm1O?=
 =?utf-8?B?NFkrK0xVY1NQMXBTUlJuVi9HUTUzWTV2Ly9yM2ZidGR2UHhXc3NOdjFuMnFW?=
 =?utf-8?B?TzZJMzhIZk5vQVBvN2k2Q0VVL3RjQ1JsMEpyaVdZRjA0MTEzcnUza3VORlVk?=
 =?utf-8?B?OVVCV0RMTVFUYk1qajZJU1lLc0JKS3ZETytOemxMWFk3b1J2MGwxSjFOQ3ZB?=
 =?utf-8?B?ZXNlaWVVaXlJMWhRRytkb21QRHEwNFF4WUFkVlgxd3JHSTlrMi9BYXNZcGEx?=
 =?utf-8?B?Mk5Ed3YrZFh0U1lTKy9WQzI2VW9pbENlOGFWdG5JSHdidi9CNEswMWJ2MHpt?=
 =?utf-8?B?aFZndlovUUJvSW1UODUzYWNHWmY0U3ZjdlRkeU1yTVhrUVhKeE5SRkM5YU15?=
 =?utf-8?B?RllBdUdURkdQQ0xFbWFLWjZGUXN5bnc2SjhqMkN5YkJzdUtJaWF3Vjdoc0hF?=
 =?utf-8?B?bnRpY080OTJIYVZ6RndLaVhUQVljekRNVU80RTlUQW9jbm0wVHltVlpjWWpi?=
 =?utf-8?B?UnA0UGEzZ05hZy9YdFhHbWtLdXVtV0dSUnZ2WloxQjVaVVpYMWlsZzc3NGtl?=
 =?utf-8?B?d2x6MVpxd3RhdjBJdzhpVnd2bjFmdDhTZ3VZOHVHVWlOdnNkWUovejB3QnBy?=
 =?utf-8?B?T1lrcUV6RWdIUkZyeFMvV0ZZMkNUY2pXanlPNFlxaDRjdDBIMFNrenBkd0pT?=
 =?utf-8?B?dlY2cjVQLytvTG9jTm1xNDlpT0thQ0FRMWtiUldVYnd0b1ZwdVB1bURDdnpj?=
 =?utf-8?B?MUdvMXY4Tm1penRDdm1nRmRrNEFVaDl1THlnT0REb1BsamtvV3IrSWxWNnF2?=
 =?utf-8?B?K0VxN21HR2E4TWFUWExyaVhveS8yNUhFeGNETnNkMWxTRGVuazRvUjV3cUg5?=
 =?utf-8?B?RVBzWHBsdXNadkdSdVNBUlRuZk12YUozR1JEWG1Pd0ExTUppNHEwYTlXUHll?=
 =?utf-8?Q?8lNvT6Hu7k+eDuqfv9+aywBSp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ade39d7-94b1-44f9-8f6f-08dc5357e00c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 21:00:06.7124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qvEDgs2U/yXFOW6g8La4qNvz5q9t456FNuKdI4YSDwPXQjQjIF2Jqp67nZxzdXeN5tY9iGbkHbKi6jqyNL5/WA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9237


On 4/2/2024 3:21 PM, Borislav Petkov wrote:
> On Tue, Apr 02, 2024 at 02:33:44PM -0500, Kalra, Ashish wrote:
>> And we can't do this in snp_rmptable_init() as e820_table_firmware can't be
>> fixed at that point and by that time this table has been mapped into sysfs
>> (/sys/firmware) which is used by kexec -c variant.
> Well, you have to do something here because if snp_rmptable_init()
> late-disables SNP, your RMP table fixups are moot and invalid.
>
> Which means, your RMP table fixups need to happen at the *very* *late*
> step after we know that SNP is enabled and won't get disabled anymore.
>
> I.e., in snp_rmptable_init().

The main issue with doing that in snp_rmptable_init() is that there is 
no e820 API interfaces available to update the e820_table_kexec and 
e820_table_firmware and e820_table_firmware has already been exposed to 
sysfs.

The e820 API only exports e820__range_update() which *only* fixes 
e820_table.

The important point to note here is that in most cases BIOS would have 
reserved RMP table start and end aligned to 2M boundary and setup the 
e820 table which the BIOS passes to the kernel as such, so even if the 
kernel does not enable SNP or disables SNP later, these reservations 
will remain aligned as such. So what we are doing here in-kernel fixups 
is doing the same alignment fixups which the BIOS would have done. The 
summary here is that e820 table adjustments for RMP table done either by 
BIOS and/or kernel will exist/remain even if SNP is not enabled by the 
kernel.

Thanks, Ashish