Received-SPF: pass (google.com: domain of linux-kernel+bounces-128669-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 2 Apr 2024 17:40:09 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf annotate: Get rid of duplicate --group option
 item
Message-ID: <ZgxtKVSwAbFXK01k@x1>
References: <20240322224313.423181-1-namhyung@kernel.org>
 <9cfa43c3-3698-455c-8a2f-85c30470733c@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9cfa43c3-3698-455c-8a2f-85c30470733c@linux.intel.com>

On Mon, Mar 25, 2024 at 09:56:50AM -0400, Liang, Kan wrote:
> 
> 
> On 2024-03-22 6:43 p.m., Namhyung Kim wrote:
> > The options array in cmd_annotate() has duplicate --group options.  It
> > only needs one and let's get rid of the other.
> > 
> >   $ perf annotate -h 2>&1 | grep group
> >         --group           Show event group information together
> >         --group           Show event group information together
> > 
> > Fixes: 7ebaf4890f63 ("perf annotate: Support '--group' option")
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> For the series,
> 
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

For 'b4' sake, next time please send the Reviewed-by to the cover letter
in the series so that it picks your Reviewed-by for all patches, not
just for the one that you replied to, as in this case.

I'm adding it to this whole series,

Thanks!

- Arnaldo