Received-SPF: pass (google.com: domain of linux-kernel+bounces-128712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6a401cbb-efd0-475f-bc43-81041e908698@linux.intel.com>
Date: Tue, 2 Apr 2024 14:16:53 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/4] platform/x86: xiaomi-wmi: Drop unnecessary NULL
 checks
To: Armin Wolf <W_Armin@gmx.de>, hdegoede@redhat.com,
 ilpo.jarvinen@linux.intel.com
Cc: corbet@lwn.net, linux-doc@vger.kernel.org,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240402143059.8456-1-W_Armin@gmx.de>
 <20240402143059.8456-3-W_Armin@gmx.de>
Content-Language: en-US
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20240402143059.8456-3-W_Armin@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/2/24 7:30 AM, Armin Wolf wrote:
> The WMI driver core already makes sure that:
>
> - a valid WMI device is passed to each callback
> - the notify() callback runs after the probe() callback succeeds
>
> Remove the unnecessary NULL checks.
>
> Compile-tested only.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---

LGTM

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>  drivers/platform/x86/xiaomi-wmi.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
> index 7efbdc111803..cbed29ca502a 100644
> --- a/drivers/platform/x86/xiaomi-wmi.c
> +++ b/drivers/platform/x86/xiaomi-wmi.c
> @@ -38,7 +38,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
>  	struct xiaomi_wmi *data;
>  	int ret;
>
> -	if (wdev == NULL || context == NULL)
> +	if (!context)
>  		return -EINVAL;
>
>  	data = devm_kzalloc(&wdev->dev, sizeof(struct xiaomi_wmi), GFP_KERNEL);
> @@ -66,14 +66,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
>
>  static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
>  {
> -	struct xiaomi_wmi *data;
> -
> -	if (wdev == NULL)
> -		return;
> -
> -	data = dev_get_drvdata(&wdev->dev);
> -	if (data == NULL)
> -		return;
> +	struct xiaomi_wmi *data = dev_get_drvdata(&wdev->dev);
>
>  	mutex_lock(&data->key_lock);
>  	input_report_key(data->input_dev, data->key_code, 1);
> --
> 2.39.2
>
>
-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer