Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2343508lqz; Tue, 2 Apr 2024 14:40:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWySnlZaLQi9vb89geJAugmBtizalET1C056VB48OmZGeNDHRLY+wvzsocj4ryoP58T9en4xw1iZfasxVlzSxGJjg2m4WS+9lCutGUYVg== X-Google-Smtp-Source: AGHT+IET37wEiuz3RFU5ifDDwQ7KJ46yyIjj3hyPx2EvT0yEBts/T6g28+H9m4YQBDAL5iphspj6 X-Received: by 2002:a05:6a00:cc5:b0:6ea:d114:5f05 with SMTP id b5-20020a056a000cc500b006ead1145f05mr15516274pfv.34.1712094032653; Tue, 02 Apr 2024 14:40:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712094032; cv=pass; d=google.com; s=arc-20160816; b=0+XTzwIalqtUPHMDYaVdP6JdnoZGW2ZLrnjRsJJ3+kyoy8bh2IwfzP6Vf4Bj49g88x RAXOZNCM9ApxjH58mnvZJGg0LP1+X8pllYMsEwuxQ8oyXUouhaBCNKPMkYWj9/Euoi9g nEgbBIL9+ONhfu4knQSd4pZKBQfhqTeGWaA85IVP71guJIIM4ur2siqvQysWN+rNYTw5 0yrJGtuHxQBZZaETMoeWldWAG/oZ3ggGNPBvsxr3Rp/uohEo8ONhYLzYkdWmblPLeeRB JHzJFc7dxdvR1JS11nJ3aaYdRk9zNJ8SOLP0GO/Z2htG4lQIVhxNOPnB52SNbjRh9FlV 523Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=TJy6mbt3j04pNsQxrvjJjNHxR+h0zQiRLQYI2vbdrs0=; fh=PaMOM7BFJ/egumKocraj/Hl7uXjq48bD/uZvwihZiVc=; b=yUDy4ZePyMyi9aPDymZY1sukLPzdRi14ECiIQPaJ8CVXQrMM0wHeBfzAPXJX+6exp1 tbArRTAIm3u+1gs7ALKg+gLSORZjm6FYbDKkp1gt6T8a6NIco9NBHAZ6KloVXh+bED9n pN0Vyrm1hrLWvLqdExhVapHVifGwtfo48BR6raAHrnOntWJKIsSUxIPVSHABBRAoyGRu YtvWLtvQR/z5nUXaLF8K+r1Fabjf0pYHKK7hO3xdRe3orDiVNtySIm+eIr4Fy4qyz0TW 0u3ybxPIMDxJtvJcG0er2qrb/dUxLPZxuqNE3FoKrsOkWr/orrg+vVVIT8GZCir1J3sW T/Ww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="M+e/lanQ"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-128443-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b23-20020aa78117000000b006e69296296fsi11443640pfi.400.2024.04.02.14.40.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 14:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128443-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="M+e/lanQ"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-128443-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6BACC28ABF5 for ; Tue, 2 Apr 2024 17:41:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D859515AABB; Tue, 2 Apr 2024 17:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M+e/lanQ" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0AE17BB7; Tue, 2 Apr 2024 17:40:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712079660; cv=none; b=nt114t7+FniA0jzo/D2tGEbozDjA/e0bmzIC3xB6aaj37a69MTIWnR7fRdLrlLyvt+DNR+fS0wQYU8xPzZl5ealor/2ej53no2x2y0O0zO+R5POQokdLbM+Cm/I2tFK5jfh5Xdvw2gk0Xy/8Z6UhQEBfa9Dk16Zpn6I+km1ScEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712079660; c=relaxed/simple; bh=vhg0oaCb7THdZc8NXM2XN52ZqPajlyFdXUg7Sg0+Uu0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oEg2WNxp20ScUsNdHkrgMwhB71Z3tp7Qvz+dV+grChxEH4mPs7raxpwpc/qLf+77VObw819//AHjXnUWjxxwQxd09vuRmfECri291enOma2ALBEaWZQec8Qm4hFNjmg/zsIXw5pqY07Ti/ocuQ92H2wd50bQTaegTYLLElDzPJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=M+e/lanQ; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712079659; x=1743615659; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vhg0oaCb7THdZc8NXM2XN52ZqPajlyFdXUg7Sg0+Uu0=; b=M+e/lanQQBW/ai5nAzUL+blIz2jaRMT6cMQ8eoJBnpOnD8nmni0wLy6Q Q3BbeVUedb38HCY4oQt12BnjdfhAtUI2hmGhEo6wrLhVNGZTkkeb4zs9U 3KQoVS1jKR8Z8NHomuOMCh/jVYPSOvUk5qs73uXvPnZV1eyH7GPK2Zztn f6s03IG52IJ7fevsWap/qb3vVAfRwk5bBB0cvVjX26IjyRham0DR2ZfXg AvmI4uyl70QCjAyhcc6etWwiMMni51bEEqARFSSaTxD+M0RDr9Uzy6jyN whtA8HrRWwyD6ygpLI/NlAMQFLAYKLgzRaY45+LIlSb3c5LGspw1VDCgl g==; X-CSE-ConnectionGUID: YnCjPX6USDKQ9YIw7xQYMQ== X-CSE-MsgGUID: NM1LW2YkTNyms/T9OxeBsg== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="10235408" X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="10235408" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 10:40:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="915148327" X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="915148327" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 10:40:56 -0700 Received: from andy by smile with local (Exim 4.97) (envelope-from ) id 1rri7y-00000000stb-0xtv; Tue, 02 Apr 2024 20:40:54 +0300 Date: Tue, 2 Apr 2024 20:40:53 +0300 From: Andy Shevchenko To: Hugo Villeneuve Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH v1 13/16] serial: max3100: Extract to_max3100_port() helper macro Message-ID: References: <20240402154219.3583679-1-andriy.shevchenko@linux.intel.com> <20240402154219.3583679-14-andriy.shevchenko@linux.intel.com> <20240402133209.910f63378eb40fa27363f3ed@hugovil.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402133209.910f63378eb40fa27363f3ed@hugovil.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Apr 02, 2024 at 01:32:09PM -0400, Hugo Villeneuve wrote: > On Tue, 2 Apr 2024 18:38:19 +0300 > Andy Shevchenko wrote: > > > Instead of using container_of() explicitly, introduce a heler macro. > > heler -> helper Seems v2 will be needed, I'll fix this. > Reviewed-by: Hugo Villeneuve Thank you! -- With Best Regards, Andy Shevchenko