Received-SPF: pass (google.com: domain of linux-kernel+bounces-128739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 2 Apr 2024 23:40:36 +0200
From: Borislav Petkov <bp@alien8.de>
To: "Kalra, Ashish" <ashish.kalra@amd.com>
Cc: bp@kernel.org, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
	linux-tip-commits@vger.kernel.org, michael.roth@amd.com,
	x86@kernel.org
Subject: Re: [PATCH] x86/sev: Apply RMP table fixups for kexec.
Message-ID: <20240402214036.GFZgx7VBVD1qwp7RKT@fat_crate.local>
References: <6f0d2ccf-243c-4073-a470-21e2f404595a@amd.com>
 <359264a1-e4ef-438c-8f24-32848e131272@amd.com>
 <20240402174540.GAZgxERNxsRJUCb1yp@fat_crate.local>
 <37321af9-aee4-4ba6-81ac-0df4cef38644@amd.com>
 <20240402185039.GBZgxTfwvEP45OxVjm@fat_crate.local>
 <8daf448f-eb52-4b1f-9f98-099a83665321@amd.com>
 <20240402202118.GCZgxovu-pgPKYvner@fat_crate.local>
 <6fdb98f8-b4e2-474d-b8e9-c3092e77e56e@amd.com>
 <20240402212009.GEZgx2iZC_Plx-ajKW@fat_crate.local>
 <f1802e68-88b2-43f9-8344-d2a513e206a1@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f1802e68-88b2-43f9-8344-d2a513e206a1@amd.com>
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 02, 2024 at 04:31:30PM -0500, Kalra, Ashish wrote:
> The main issue is there is no API interface available to do that, i wil=
l
> need to add new API interfaces to update the e820_table_kexec and
> e820_table_firmware and then will that be acceptable for a use case whi=
ch
> can be handled via a platform specific quirk ?

I can't review a patch without seeing it first, sorry.

> Yes exactly, that's what the above comment means.
>=20
> =C2=A0That's why the above commit message says "may".

Yah, *never* use "may" in commit messages. This is internal speak and
doesn't belong in the kernel. Your commit message need to explain stuff
fully and properly. Otherwise I'll keep asking until it does.

> My point is that we always keep the RMP table memory reserved regardles=
s of
> SNP enablement, so these are simply fixups/adjustments on top of that
> reservation.

Yes.

--=20
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette