Received-SPF: pass (google.com: domain of linux-kernel+bounces-128743-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 2 Apr 2024 23:45:50 +0200
From: Michael Grzeschik <mgr@pengutronix.de>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] usb: dwc3: gadget: improve abbort transfer abort by
 adding more conditions
Message-ID: <Zgx8jh_Tz_dgmI1v@pengutronix.de>
References: <20240307-dwc3-gadget-complete-irq-v1-0-4fe9ac0ba2b7@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tWQpvqhZ3A9Ayrjv"
Content-Disposition: inline
In-Reply-To: <20240307-dwc3-gadget-complete-irq-v1-0-4fe9ac0ba2b7@pengutronix.de>


--tWQpvqhZ3A9Ayrjv
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 07, 2024 at 04:22:02PM +0100, Michael Grzeschik wrote:
>The dwc3 gadget driver is correctly checking the prepare and started
>request lists for potential underruns and will stop the running transfer
>in that case. However it is possible that the running pipeline will lead
>into more underrun scenarios, which can be avoided and be detected. This
>series is adding the corresponding code to ensure that an underrun
>transfer will be handled properly.
>
>Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>---
>Michael Grzeschik (3):
>      usb: dwc3: gadget: reclaim the whole started list when request was m=
issed
>      usb: dwc3: gadget: check drained isoc ep
>      usb: dwc3: gadget: check the whole started queue for missed requests=
 in complete
>
> drivers/usb/dwc3/gadget.c | 38 ++++++++++++++++++++++++++++++++++++--
> 1 file changed, 36 insertions(+), 2 deletions(-)
>---
>base-commit: dfea18989aa7beb42c2cb6344fe8787de35d9471
>change-id: 20240307-dwc3-gadget-complete-irq-1a8ffa347fd1
>
>Best regards,

Since it is not right to fully stop the ep after one missed transfer was
detected, this series is not correct anymore. We solve the overall issue
in the upper layer now.

Besides the patch "usb: dwc3: gadget: check drained isoc ep" is not
completely wrong, I will resend that one in another veriant.

mgr

--=20
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--tWQpvqhZ3A9Ayrjv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEElXvEUs6VPX6mDPT8C+njFXoeLGQFAmYMfIsACgkQC+njFXoe
LGTZFhAAv0rquu74k9lZ78qiepcQVo6Qoq8z3Awh2HIvs28vVvJ5GlRD19yeoWnF
FupjFur3kFfw+xAa1CU3zNJtDnlKiW+t9klJ/MipLhRPR9GpAjkCVXVriJGNEfpS
Y7hhB7iOZjr0nGJ/b/Wld4OZroDCjFPoF3BGxm/tISucusCuoswjLwewJF3tmAGf
q8yeOq6MQKHbbPpFQlNFEMibMWMqacgjWsKdC8ngrwcfUgF87pbxqdunF6TXwwYf
Xu+2iZUn87SiwlueUf21RjXMC498rh3hZ1qzbvDpNwjCRJIyypIK60YubHOasSsF
+uFkleYZpfJCZbENlsDBvvYpP6LqP47oFIjBsWDHYGTNuJVA+78iV26mw/Ayjdor
gY5QW79O8wnP0IjbYEuQE5w7KeMP09clWEM2s2k/hj17c3eIoqvp882iaCVXJBne
CRjNVy/WPIh4TV4jHY1vc4dk1ezX+2hJlaQtwHvoiiwMGiRv3vFSEga29ITywqpX
4zexzC05NR70ARWHrddKF32BhYgLIHuiksPUeWpnmRq3UCEfp1yFm2ka9D3HCUAL
fYpnebv/npQ0rWPmV+0r4QPPypPzSXBOLsyObeEj/AM83eonUNy+zY9YvWpIft+z
yjSNKZfc8gUSjhIQ/vsVEIKIXxY0UVVCYEB1bS/JeaGLk2IAmzc=
=P9jq
-----END PGP SIGNATURE-----

--tWQpvqhZ3A9Ayrjv--