Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2348548lqz; Tue, 2 Apr 2024 14:54:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVyykYHexS942r65pgngbjYMuUs7pmH8haO+1F/ebe1UG/ZHfxcGwIiDNEjFReWi/8CIwsgCKPRaFTXTyDR1OWfNQi+JOMEG5+RqRKqrg== X-Google-Smtp-Source: AGHT+IFjWRFeb8hnfOdy5a4e9CjRgcz/fdjsPRLZGO/JECpviNUeODhi53x/B9KWXluBQdDluBrI X-Received: by 2002:a05:6a00:4fd2:b0:6ea:bc99:c4cd with SMTP id le18-20020a056a004fd200b006eabc99c4cdmr16836456pfb.8.1712094883136; Tue, 02 Apr 2024 14:54:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712094883; cv=pass; d=google.com; s=arc-20160816; b=LZ+Q0aAOtaGqJpUcDsheKt4RE/XyRSR8KJYHMjsHr+wOU0qbqLugZOe4V3NduOoj5M Vbtoini3DRUO2DgKAYMwcTSNj262khMpqFVK9cJ6+8spaFFVLAtls2wCVHXyh96MVSXw 0eOKVnKewHr0OE3t6tBg8jGqUjArxeCoVFyKEns/c3czcJC4RL7kVOdUBMesHmZGWJIH zuNXC4O15u7ZxkrKvKCezZoMw1qzLmRpoMLdNvnPghFACEGVPcJzl3WEL1+6prQAr01h Nf4D/mYuv0QOvLLWxcVg+jhi5m/soa8iAl3/0gmN9i1C7yaNKVRFzsc6Nh33isp1xzip KeWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=19SXqQkkidmgz36P0oTIWIYcEYLj1W1NJLGqmH/uhpk=; fh=2d5Mqa0JPwwgr7x85lDg/o+0qPx+nzn0dgwlAMCBlus=; b=FfYo+qbDEkKFngm0WnQbqDK0kjtPO7ZQxzp6/Pt/pRpW2KY47du9vh/DVEx9R3fJQI ixj5RG2z0SV4YyxGQeEzyyeenjVvAKh+6fXcVhmCRAGuWlWNICZUJpKj/ZWhe5IxHx22 IRYJPWYlHIlKJGy6dpaeZdJySc1LrxTZFI+3dnGKppBFW97X+j717eG+V3+5HXnQE5Gl xRLqgO18PzGzqumZn+BkpwhnyLH/cYGocCjvDDVJkztZEdUhVH5cR9mw2Q6Nyu2fOYa4 4ZPlLJd+Ermuf8F7ii7pTp4VHRJ5wlDnplRRc/Npf8q0QGUwiHLAw89hM4SUrIrSueMR v4Cw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-128751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128751-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j9-20020a056a00174900b006ea92ac0a07si12598082pfc.221.2024.04.02.14.54.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 14:54:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-128751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128751-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C52EF2836DE for ; Tue, 2 Apr 2024 21:54:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3352C15E802; Tue, 2 Apr 2024 21:54:38 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C69E79DD4 for ; Tue, 2 Apr 2024 21:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712094877; cv=none; b=ML0xFuerAXZnMmUr0jO8HPPdZIN58p0OCaoDS6sG2cIBacmpcO/LtgCwD2Y7nsrNjLcIgnC0KRgV6Oue06PmC7XvQ+d36aMRcr62xX8u2MozsHxr+ZLtk6v1KnayfUwiPx5vCDdFRozncuPmfao1kfqbviSuRZHTDiK1gkNBi9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712094877; c=relaxed/simple; bh=pfXumYy099kiErELMn9mqWqeDvXeUZ/t+84EEBKXLQc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lNJUmZAaN6dU/5a9sBccuyAbvxPiUooBmW5hdFowLR5slXywGBznKQok+5AI46kJRW/A9i9YG0AjZAtJzQ0Q/vRxelpvCf08QnVT8Bf/ReuLZQXW2WB3RHa6h7L72/BtV4fzKtVRpqGqE99W+M/tRwi73fIvR4pnCHeFA3hWT1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4907B1007; Tue, 2 Apr 2024 14:55:05 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 08AA93F7B4; Tue, 2 Apr 2024 14:54:32 -0700 (PDT) From: Liviu Dudau To: Boris Brezillon Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steven Price Subject: [PATCH 1/2] drm/panthor: Cleanup unused variable 'cookie' Date: Tue, 2 Apr 2024 22:54:22 +0100 Message-ID: <20240402215423.360341-1-liviu.dudau@arm.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 962f88b9c916 ("drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()") removed the code that used the 'cookie' variable but left the declaration in place. Remove it. Fixes: 962f88b9c916 ("drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()") Cc: Boris Brezillon Cc: Steven Price Signed-off-by: Liviu Dudau --- drivers/gpu/drm/panthor/panthor_device.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/panthor/panthor_device.h index dc3e9c666b5bd4..2fdd671b38fd9b 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -323,8 +323,6 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded_handler(int irq, void *da \ static inline void panthor_ ## __name ## _irq_suspend(struct panthor_irq *pirq) \ { \ - int cookie; \ - \ pirq->mask = 0; \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, 0); \ synchronize_irq(pirq->irq); \ @@ -333,8 +331,6 @@ static inline void panthor_ ## __name ## _irq_suspend(struct panthor_irq *pirq) \ static inline void panthor_ ## __name ## _irq_resume(struct panthor_irq *pirq, u32 mask) \ { \ - int cookie; \ - \ atomic_set(&pirq->suspended, false); \ pirq->mask = mask; \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_CLEAR, mask); \ -- 2.44.0