Received-SPF: pass (google.com: domain of linux-kernel+bounces-128753-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <69ee112aadc8ef8ed7d819308f02dc58e56bb0a6.camel@perches.com>
Subject: Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like
 macros to evaluate parameters
From: Joe Perches <joe@perches.com>
To: Barry Song <21cnbao@gmail.com>, Jonathan Corbet <corbet@lwn.net>
Cc: akpm@linux-foundation.org, linux-doc@vger.kernel.org, 
 workflows@vger.kernel.org, apw@canonical.com, broonie@kernel.org, 
 chenhuacai@loongson.cn, chris@zankel.net, dwaipayanray1@gmail.com, 
 herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
 linux@roeck-us.net,  lukas.bulwahn@gmail.com, mac.xxn@outlook.com,
 sfr@canb.auug.org.au,  v-songbaohua@oppo.com, Max Filippov
 <jcmvbkbc@gmail.com>
Date: Tue, 02 Apr 2024 14:54:34 -0700
In-Reply-To: <CAGsJ_4x=YaGotZwRxjaRhELi=ExVcQ+euEkSiZ2GkAoLFwhMVw@mail.gmail.com>
References: <20240401012120.6052-1-21cnbao@gmail.com>
	 <20240401012120.6052-2-21cnbao@gmail.com> <87msqbvj3g.fsf@meer.lwn.net>
	 <CAGsJ_4x=YaGotZwRxjaRhELi=ExVcQ+euEkSiZ2GkAoLFwhMVw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-04-03 at 10:21 +1300, Barry Song wrote:
> On Wed, Apr 3, 2024 at 5:13=E2=80=AFAM Jonathan Corbet <corbet@lwn.net> w=
rote:
> >=20
> > So I'm not sure what your desired path for getting this upstream is.  I
> > can take it, but I'm generally quite leery of taking coding-style
> > changes without some serious acks on them - nobody elected me as the
> > arbiter of proper coding style.

I believe it is generally appropriate for macros that take
arguments to use static inlines where feasible, so:

Acked-by: Joe Perches <joe@perches.com>

And yes, mm is the usual path for upstreaming at least this
sort of checkpatch change.