Received-SPF: pass (google.com: domain of linux-kernel+bounces-128737-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 2 Apr 2024 18:37:28 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Kan Liang <kan.liang@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org, Song Liu <song@kernel.org>,
	bpf@vger.kernel.org
Subject: Re: [PATCH] perf lock contention: Add a missing NULL check
Message-ID: <Zgx6mMda_X4pcAj6@x1>
References: <20240402184543.898923-1-namhyung@kernel.org>
 <ZgxgRJdFlwfESwKF@x1>
 <CAM9d7ci7a2dbn1cz-OBkYF7P1fFA3yoBMuTzXRx=KP-yEnyfnQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAM9d7ci7a2dbn1cz-OBkYF7P1fFA3yoBMuTzXRx=KP-yEnyfnQ@mail.gmail.com>

On Tue, Apr 02, 2024 at 01:42:05PM -0700, Namhyung Kim wrote:
> On Tue, Apr 2, 2024 at 12:45 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

> > Are you going to have this merged into perf-tools?

> > A Fixes: tag isn't perhaps needed as it worked in the past?
 
> Fixes: 1811e82767dcc ("perf lock contention: Track and show siglock
> with address")
 
> It was introduced in v6.4 and it should be fine to have this
> even without the error.  I'll queue it to perf-tools.

ok, better, people trying the tool with a recent kernel will experience
this, so its the right thing to get it thru perf-tools.

Thanks!

- Arnaldo