Received-SPF: pass (google.com: domain of linux-kernel+bounces-128790-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 2 Apr 2024 15:30:22 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <ira.weiny@intel.com>, Fan Ni
	<fan.ni@samsung.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"Navneet Singh" <navneet.singh@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Davidlohr Bueso
	<dave@stgolabs.net>, Alison Schofield <alison.schofield@intel.com>, "Vishal
 Verma" <vishal.l.verma@intel.com>, <linux-btrfs@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/26] cxl/mbox: Flag support for Dynamic Capacity
 Devices (DCD)
Message-ID: <660c86fed6918_8a7d0294fe@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-1-b7b00d623625@intel.com>
 <d3bcac81-35ee-4876-8f2c-6c66a7fdd960@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d3bcac81-35ee-4876-8f2c-6c66a7fdd960@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zabQp+StPFjTLYXKU9l2j3I5LzmQJ1bkzZYUKiAxfzJ+0eoJjv/z8h9/APJ6?=
 =?us-ascii?Q?L4yacHSyoQuqtP661rr7fJvZZkxmJs9l0xy6sEz4cek+aZ3F1rMg1KXVwsy7?=
 =?us-ascii?Q?7Oow+QL5DUb+kLqXqft1Kcakg53P7F4h7Jl2bFZdFYjRBfAmfamWS055/emB?=
 =?us-ascii?Q?V+xBvanEN9JWfqUuZPLk0xrkPAzLJrO0/8OxKeA8IiUaKCWhuuwMRnvE2Pad?=
 =?us-ascii?Q?EX0PirG57gJdBBYaA9c1DH/WhiRXRRMxmOAAvJfnoXsqsOGSmSWErfy7I4vN?=
 =?us-ascii?Q?8wDEqXSzC7kPIybFGqZOgNPw5IHAXkaCXYQi9rrpgmT6u+tcTPZ3LsPEotum?=
 =?us-ascii?Q?KxkxzWKOiHGKuMwCRu9kBQKjkbUPDj1QBkY6sH+urBn42IpzLO4GjdRuBVP0?=
 =?us-ascii?Q?KGOTiTRhWFFtBJvckhBgQkdlB1eaHwWf+WTWfl9tl6unmI77qziCBT7csRpa?=
 =?us-ascii?Q?1VafbbwNL8oSroe5duXPCJQbPWZdAXfi2aZHCNUK5DJ64LkXLp87iASA//3k?=
 =?us-ascii?Q?zfU30HUsQtxuGzf4p9FXlVmzy5xTnqexuqeX8vs4Yy2xcYJniA6AtqFdegh0?=
 =?us-ascii?Q?5FJ41B7Lt1kO/iFIl8bUR/gt09PX/LPLGu92nnCfvVI/DZy+lCFZ6F3LtWIy?=
 =?us-ascii?Q?PtVAEn3gRVWKmcTnPUtdojijk0B2AJhkfClmksFQwxu9WGL1WbSV5pR92vzu?=
 =?us-ascii?Q?6WLt07hMfmgOKinIGJvn3fiYlpKM1u4GhQHeNAcCVXqPuq1t3+Wts+UVPKoq?=
 =?us-ascii?Q?XuYZAjwgiR2agj9f4mvDfaL5wzx8XMjG+No3itkZM4DxGUBlURZ/lomskljU?=
 =?us-ascii?Q?KyimHy7qALlW/lWHg7uOUsv5BW/VJ8gQRmBUe8BJQIVnRWuT4pve3wFt5VX3?=
 =?us-ascii?Q?abeSdM8YDHAPXiFVVY0hjVPZavhTwelWqei06/vu5hr6etBV5QCkizFMZ54r?=
 =?us-ascii?Q?bJYHlct4Np7x9shWT3t8rawZI6rGC8A2blPaGTV0zGB7Xwgnldb/a/p84HfK?=
 =?us-ascii?Q?QZZi5vJoXzJ0ClO/uDXldcxGbFoj/9IjYi3a9vwFGsz5m1kkyhrGIvFkPFJu?=
 =?us-ascii?Q?WRCejlkwW3z8qakLFwQs4pG/+99fWKdqQvRCMrGHWysDN4onInsnqoCS/U9i?=
 =?us-ascii?Q?eD+/vALQDlt/L1xUp31hvAoiuZpYdHNWgT3NjNOPGd+5BsyAKhwXGKanKYYM?=
 =?us-ascii?Q?3ydPOw2atT4GuAO9WxCe2IJKYDnPfN3pH26sXeRcUxKCfOiNsJNHAuKRmgY0?=
 =?us-ascii?Q?n/cQSQlHbYzQL/J0HrhIAAhNt5cioNSm7lxP8GHkFV9OCC63dblhES6cYrgo?=
 =?us-ascii?Q?FcVRCoKwwq1hNJVP6PYtWkb0NERNBqB8BK087xhWkhrZ1P35bxeGLWN3+wxV?=
 =?us-ascii?Q?dx04mIXwkrtgcTWM4TYBUrZ/94HYUqNwnQn1U4dqzqzSq8ghK4k0sspbbbqa?=
 =?us-ascii?Q?gc0aog1ivYBxyeOSyUV0Vy/b4r6GwTYygtn3UnWu6PiiiVBUKmvVuEdPFATH?=
 =?us-ascii?Q?S8sa8SzEv9ZvG87lKN7f6XOzSTXw7cK8MqBldyrhqvcAbRRIGWU034qR3ppB?=
 =?us-ascii?Q?1dLHxb38JqFp1TRjpOx5VbZ1aAbIe12lwSB3zLPL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1556c53d-d7d8-4cba-65f7-08dc53647e3b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 22:30:26.0819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tBmj4OXk4f47SWxxkxqIFWlJ4sU29xDV0hqkD1UE8UWUP5XyUJDhiJntapj8zN5dRtxMpLDB5qsrOnou/O63vQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7591
X-OriginatorOrg: intel.com

Dave Jiang wrote:
> 
> 
> On 3/24/24 4:18 PM, ira.weiny@intel.com wrote:
> > From: Navneet Singh <navneet.singh@intel.com>
> > 
> > Per the CXL 3.1 specification software must check the Command Effects
> > Log (CEL) to know if a device supports dynamic capacity (DC).  If the
> > device does support DC the specifics of the DC Regions (0-7) are read
> > through the mailbox.
> > 
> > Flag DC Device (DCD) commands in a device if they are supported.
> > Subsequent patches will key off these bits to configure DCD.
> > 
> > Signed-off-by: Navneet Singh <navneet.singh@intel.com>
> > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> 
> small formatting nit below
> 
> > ---
> > Changes for v1
> > [iweiny: update to latest master]
> > [iweiny: update commit message]
> > [iweiny: Based on the fix:
> > 	https://lore.kernel.org/all/20230903-cxl-cel-fix-v1-1-e260c9467be3@intel.com/
> > [jonathan: remove unneeded format change]
> > [jonathan: don't split security code in mbox.c]
> > ---
> >  drivers/cxl/core/mbox.c | 33 +++++++++++++++++++++++++++++++++
> >  drivers/cxl/cxlmem.h    | 15 +++++++++++++++
> >  2 files changed, 48 insertions(+)
> > 
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index 9adda4795eb7..ed4131c6f50b 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -161,6 +161,34 @@ static void cxl_set_security_cmd_enabled(struct cxl_security_state *security,
> >  	}
> >  }
> >  
> > +static bool cxl_is_dcd_command(u16 opcode)
> > +{
> > +#define CXL_MBOX_OP_DCD_CMDS 0x48
> > +
> > +	return (opcode >> 8) == CXL_MBOX_OP_DCD_CMDS;
> > +}
> > +
> > +static void cxl_set_dcd_cmd_enabled(struct cxl_memdev_state *mds,
> > +					u16 opcode)
> 
> This seems misaligned.

Fixed,
Ira