Received-SPF: pass (google.com: domain of linux-kernel+bounces-128813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240329215812.537846-1-namhyung@kernel.org> <20240329215812.537846-4-namhyung@kernel.org>
 <ZgyBwTWv8OZlbl9m@x1> <ZgyCkETBtsTX3tA8@x1>
In-Reply-To: <ZgyCkETBtsTX3tA8@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 2 Apr 2024 16:03:33 -0700
Message-ID: <CAM9d7cgyeaeTPyw5fZjX2OsVrGqv-VrqpU_RPgUu8yWN+qTDsg@mail.gmail.com>
Subject: Re: [PATCH v2 3/5] perf annotate: Split out util/disasm.c
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Kan Liang <kan.liang@linux.intel.com>, 
	Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 2, 2024 at 3:11=E2=80=AFPM Arnaldo Carvalho de Melo <acme@kerne=
l.org> wrote:
>
> On Tue, Apr 02, 2024 at 07:08:04PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Fri, Mar 29, 2024 at 02:58:10PM -0700, Namhyung Kim wrote:
> > > The util/annotate.c code has both disassembly and sample annotation
> > > related codes.  Factor out the disasm part so that it can be handled
> > > more easily.
> > >
> > > No functional changes intended.
> > >
> >
> > Unsure if here, will check and fix later, detected with:
> >
> >   make -C tools/perf build-test'
>
> did it, added the missing env.h header to disasm.c

Thanks a lot!
Namhyung