Received-SPF: pass (google.com: domain of linux-kernel+bounces-128844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 3 Apr 2024 00:52:44 +0100
From: Mark Brown <broonie@kernel.org>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 6.8 SPI Chip Select Regression
Message-ID: <467644bf-85d0-429a-bd11-7155b1cb5fbc@sirena.org.uk>
References: <Zgx5glZznSCheksj@euler>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yKmDki0JYO3XvI4S"
Content-Disposition: inline
In-Reply-To: <Zgx5glZznSCheksj@euler>


--yKmDki0JYO3XvI4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 02, 2024 at 04:32:50PM -0500, Colin Foster wrote:
> Hi Amit,

Amit, please respond to these issues - you never replied to the mails
about the other regressions this introduced either...

> [    3.459990] omap2_mcspi 48030000.spi: chipselect 0 already in use
> [    3.466135] spi_master spi0: spi_device register error /ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/soc@0
> [    3.477495] spi_master spi0: Failed to create SPI device for /ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/soc@0

> Is this a known issue? Is there anything I either might need to do to a
> device tree, or something you might suggest to help troubleshoot this?

This is not known, and given that you say there's only one chip select
in use on the system seems clearly bogus.  There were some regressions
with trying to use more than the hard coded maximum number of chip
selects but they have a different error pattern.  It's late so I'll not
look properly right now but...

Do you know what chip select 0 is - if you add a WARN_ON() to
spi_set_chipselect() it should show a prior call to the function, or is
it some logic bug that somehow is not manifesting on other systems that
use chip select 0?  Though looking quickly there has been some factoring
out since that commit was merged...  just to confirm, did you bisect to
find the problematic commit?  If you could show the DT for your setup
that'd help, especially if this is a GPIO chip select.

--yKmDki0JYO3XvI4S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYMmkwACgkQJNaLcl1U
h9C7ugf+NYa3Oer0QJuuMbd9DVStpdXnyTAl8KM/vPEDBPt6ux/DAUBgbFohe1FF
7J+HArHr/ORgXcNuXn91SjjuhmQ0f2/E6l8r31DawceOrD7weSpwwxjG0HTB1HQp
NPdoeCiXMfC99pvFvqvQH5nB3yco7G9HonnYdj17+WLKNA7QkcBkzZRAd3m6iSDS
YLPv84McisH22eDM2E+26EG0JYJ7fSaxAcgndAIjrNYi/2TDB8WTS5R67OJ5fvnP
yRCXkt51gXiECR6B3C5EkmV/UbapKv/xVkHEiRojpbyrOHx2LSwbteJSRPTtsCgV
+bgVB3MraL0E+pWEGKu7nOTjaZ6swg==
=2p7w
-----END PGP SIGNATURE-----

--yKmDki0JYO3XvI4S--