Received-SPF: pass (google.com: domain of linux-kernel+bounces-128848-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i5ec1447f:Fastmail
From: Luke Jones <luke@ljones.dev>
To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, corentin.chary@gmail.com,
 platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject:
 Re: [PATCH v2 4/9] platform/x86: asus-wmi: support toggling POST sound
Date: Wed, 03 Apr 2024 13:06:17 +1300
Message-ID: <21854739.fSG56mABFh@fedora>
In-Reply-To: <0c8635b9-db16-9125-63bc-7761800e3e96@linux.intel.com>
References:
 <20240402022607.34625-1-luke@ljones.dev>
 <20240402022607.34625-5-luke@ljones.dev>
 <0c8635b9-db16-9125-63bc-7761800e3e96@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

On Tuesday, 2 April 2024 11:47:08=E2=80=AFPM NZDT Ilpo J=C3=A4rvinen wrote:
> On Tue, 2 Apr 2024, Luke D. Jones wrote:
> > Add support for toggling the BIOS POST sound on some ASUS laptops.
> >=20
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > ---
> >=20
> >  .../ABI/testing/sysfs-platform-asus-wmi       |  9 ++++
> >  drivers/platform/x86/asus-wmi.c               | 51 +++++++++++++++++++
> >  include/linux/platform_data/x86/asus-wmi.h    |  3 ++
> >  3 files changed, 63 insertions(+)
> >=20
> > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > b/Documentation/ABI/testing/sysfs-platform-asus-wmi index
> > ef1ac1a20a71..41b92e53e88a 100644
> > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > @@ -194,3 +194,12 @@ Contact:	"Luke Jones" <luke@ljones.dev>
> >=20
> >  Description:
> >  		Set the target temperature limit of the Nvidia dGPU:
> >  			* min=3D75, max=3D87
> >=20
> > +
> > +What:		/sys/devices/platform/<platform>/boot_sound
> > +Date:		Apr 2024
> > +KernelVersion:	6.10
> > +Contact:	"Luke Jones" <luke@ljones.dev>
> > +Description:
> > +		Set if the BIOS POST sound is played on boot.
> > +			* 0 - False,
> > +			* 1 - True
> > \ No newline at end of file
>=20
> Add the last newline please.

Editor removed :(

>=20
> After fixing that, please add:
>=20
> Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>

Done and done.