Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2416183lqz; Tue, 2 Apr 2024 17:45:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXyRzgcy8LlqfKXiKloWmmPLa4Fq4iurxDGTaDDa4ge5uph2AOd7xCMsFRSlYORbeoRrsmrk5kaE59y/KariChTTnxb3YCtXf5nZ085Ig== X-Google-Smtp-Source: AGHT+IG4H3XEFPLkO+viM27u876P1vW+wqIQvzE3oCr5Zvv0Q2bUq3Wedfq0gzqYfLRXjlEAlfXZ X-Received: by 2002:ac8:5990:0:b0:431:503e:4139 with SMTP id e16-20020ac85990000000b00431503e4139mr1534182qte.14.1712105147425; Tue, 02 Apr 2024 17:45:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712105147; cv=pass; d=google.com; s=arc-20160816; b=ifzry2Eisdjf4RlufgO14sQhFriiIGWHDEUfRNkPRzEt9F44c7Zow3Rl2Q+3KXjI2h gBa08dJ5nOY0hjy3qPnohMg8T6wFywTf9L6W7zQisZYuwVLW02/uGkDDYkPB8v0+FvVs MGTDg7KNF5Ysaj4yPq50vSEC/TEziKoeq+52SfiDOj+Nd0ITg/QlqyA0fCyEGq2kkgAM utXACkCaQ8fW7n7xpReGC1Mo3tEZk/yeHNk0fAq43/caxquu0Xw4RdWvyWKn2eq58fSn i36tZhSRqohwYiQyLHJsOliWn7705GIUOIjAhXmhCN+/35QzI1NILHSR655rbUdAX4Wv GTVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=+S+1J8aMKazQxbr+2V5XSLxrt461yMUugzmakro0N2Q=; fh=l+ojS9GQ5L8EfvKaNBfuBMfvWVH+l6PGo5oqz+mgfxk=; b=qoemtZnxkuhDl3MLORztudrJwUhiuEYpzMCbzzZl6PU6kC9kHKh6ihvq4SRkdiMd/9 qbdG+IkntUdppyalRyQeSEnvAurVJfWEwBAY1oUFixlEMY+6KpPHzNTsqigUvlN2/EMF Q2ifUDM4oxSjM8UKn8WL693CBANj3dERUl+slQ1uRqj6mT1gt+y0Mr1f4xFKAvrXhR09 2EMvswgh8qBlba0iRLK11Sw32SEL/MqzS7muojtsAz2895O2VXt8rc9L06/D3YfH6umD azOpmNahru3GB5FQRQSTqQMoiYQzMn4Ra9tkTPofQEEDUloDFFpAX5X34rbZwu4lipq5 nS3w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o23BVmGE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128896-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j4-20020ac85f84000000b004313f7816b8si13270152qta.364.2024.04.02.17.45.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 17:45:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o23BVmGE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128896-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2E23F1C2234C for ; Wed, 3 Apr 2024 00:45:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7563FD53E; Wed, 3 Apr 2024 00:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o23BVmGE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98AE812E47; Wed, 3 Apr 2024 00:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712105138; cv=none; b=t5JY05QFdqhTypWYWFilaxo5mGDqH8tS+EJcrFHGvdSH1YMntv/hh1szIRWKnH+xf2s85KAVt/hIM5UK9mLoLgsRF2dTURCOXluHBkE0pOJS2Z3PkBpEGhx+b12AZZCsz9V8jYGuTUaTsKc5RbwfLU6alHZNIQ2/+3gWDqaIzHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712105138; c=relaxed/simple; bh=1iP1fkRum/nFXhcUmp2itsi1QhT9K7/xfja8hI0pYKU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZW45sbZpZXrMppPcZRgD6ahaey8+sEce5o5FBKRX03VT1pOqR8DjqhphfUsyroy6ePeBQzCo4mxTXJ8tsBxUnxQnAhWfLAp5VFKEWhDYmKB7CY1UDi5p/C3Gtv8kV/9vwpaEzFgyoI9sB2bfBzAk1Uj84R/3/tKKyyAgUEr0qsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o23BVmGE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E208CC433F1; Wed, 3 Apr 2024 00:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712105138; bh=1iP1fkRum/nFXhcUmp2itsi1QhT9K7/xfja8hI0pYKU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o23BVmGEARVXMcTI63k8Ku8hl1/4DIdGxDB0thK6nl1dswtD2nxNw5ODAnGs/9IVJ VCVV+gPtUdXGE/hqCVJuVqym3Rh86EvSH8roe8TzHOswlGR+7UQvy2yacAopZQ9XmQ NBwkIxJwpJYmZrm3bXrNParV4RxRpeYXpK/x5IGgx19jfdUsmexRZBIsoaH3DAzbB0 lXkLufrVXj0vjWePK5VYtTt4Ad7wPZOOCKSW3i4VZLErqyFurmalKAip6nbAB67f1C y8y1scvP4sQOmpY6riRUEQUbQOrFK8c4kms2DYpdS4TvOAEQ6deFbyd4oHBDDwU8mV EFO7kBHoZiJFA== Date: Tue, 2 Apr 2024 17:45:36 -0700 From: Jakub Kicinski To: Catalin Popescu Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, m.felsch@pengutronix.de, bsp-development.geo@leica-geosystems.com Subject: Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends Message-ID: <20240402174536.75cbe074@kernel.org> In-Reply-To: <20240328133358.30544-1-catalin.popescu@leica-geosystems.com> References: <20240328133358.30544-1-catalin.popescu@leica-geosystems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Mar 2024 14:33:58 +0100 Catalin Popescu wrote: > -static int dp83822_set_wol(struct phy_device *phydev, > - struct ethtool_wolinfo *wol) > +static int _dp83822_set_wol(struct phy_device *phydev, > + struct ethtool_wolinfo *wol) Why the underscore, you can all this any number of things maybe dp83822_config_wol() or dp83822_apply_wol()?