Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2428999lqz; Tue, 2 Apr 2024 18:24:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWFWI9aj7S+oPqjF0h92vfQ67sk4p/6XS07a4SX0vWYOl4i9sGs/Jz3HQlXXRU3Ztd4uW7xDCODpeAt7g0yyxhUry6h+1/rTxSV+NwtgA== X-Google-Smtp-Source: AGHT+IFI+TxvVTYWMiKoud+FNnMuILzM4szooX6pYvS11MO2PvltS2w/ydh/kGtlbKa1Q9Bl6jBT X-Received: by 2002:a17:906:4f0f:b0:a47:3afd:4739 with SMTP id t15-20020a1709064f0f00b00a473afd4739mr1044536eju.6.1712107443450; Tue, 02 Apr 2024 18:24:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712107443; cv=pass; d=google.com; s=arc-20160816; b=M+UrnJMY1XMfEVZH+efTo7jOrOEVsgjbA3AZ//qU7eda5bOkH9DYXrdNC3AC2NdChg RM8I6Zb/VM291TkrT7M8pwD6zO8YCIhuW+V8ieBdyQxLhB8gOQyL+2RLM+ywt0SJAzO/ 0OURGkwjWC6fXehptKPPEa2cHmW2OxXJMeuVRsbgvx70xaPZ2sIVhNsDNN2do5Rz3hTK zuAJWx/qZMsVlxX34FAAmCMQJf/Z5+7EvZ7JrcBC5XdxpOn2LrFLJcOeUzwrzeTN01nG gk+RNd5P1xdh0QrdDpADddQIGfKBzxEUcoumdmab/BBsoNxxMJrI82RmDyd2aPTgj66w wr4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=L1gdUkcdWSM7GQ56lwn54zmsi3MqWplX7TZq1R7rS58=; fh=6efYo0EtQAYgc4OJNr4ukNEXrNr2GQ5TAylkVL6dQZU=; b=INmJQOC13ZrQeodUbeOcmmtOJumI4Zc6m9ggpA0ghQpi4MUpZba1WrHpHCr6zxLTQu EDh/UMvsb8Dr3wY8VX6hWObW41t3P6SIzGaAyceUf9ytE49FW2KrpgdzpcS/fE2IPvhs 5mmqhgQznfCLQGAqhA+HB9alWG0rMmuJwze21K2b0rXMXzJ6YV2yDNw/wtzA+PLqkIQn D8FVm2iRH0cSj5xm5xkMbeL5vMQUYEkdb+j/j9wf6hZW2uBuymyj4iZAvY164AW5gzv9 Ez5ixx2C8FaXgUUWuPyL+1vTM0pV2KOkhQt7gx8BQpS18/EhfiERdxDYC+Ku7wGKT52V +kdQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SIWb1X+D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128927-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id w14-20020a170906d20e00b00a46ce65a8f0si6107501ejz.622.2024.04.02.18.24.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 18:24:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SIWb1X+D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128927-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2C8D41F2563D for ; Wed, 3 Apr 2024 01:24:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4BC8F14016; Wed, 3 Apr 2024 01:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SIWb1X+D" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E42CE56E; Wed, 3 Apr 2024 01:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712107433; cv=none; b=ADR8MG1a01D7q9Tr7cVF2SWOuPBeb9R/x8OT3lbTdLXfYZMIwurkgEZVhJn8jCgzsu6r5t0egtyCwqhvPk/+LKwL4rouo2R6x3dPzZ13R60c/IPrQY+Pobv5Q75B8bwZQQ1ypXHPVFCO62ZzGcHfSJi+WQmwca2Bd5Mk6mgR6go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712107433; c=relaxed/simple; bh=Yy3W35jtTdyObIhJ/w2Brxj+AIW5aDDLh0ei+LhZZUo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=drom+z7sAIejHcBeR1T009EmVa5NNBjuY9drx4sdbY+56FFTRLZVljTXP0eT+aHwAeIBVf+ASoeHFfRrQyl4rQabGAvzepQjcJWgLbuPS67kg1mPIhRVaP0IA35zPqPbxZP9IglikOCeEDZvGS0S2uxfI3d1u4RVXQCndwxtjNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SIWb1X+D; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 769A7C433F1; Wed, 3 Apr 2024 01:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712107433; bh=Yy3W35jtTdyObIhJ/w2Brxj+AIW5aDDLh0ei+LhZZUo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SIWb1X+DZwHj4mHi9J3FOltBIYLuYyWy5XHMgk6IGbuxD7JDxd6Vcze3wRIHkmlKB eVMUSkF1MF+ueaF6HjJq9TqXB7TcgnrlyhXUeUlbgFd/3UcxAGIcc59vEhd3gfA6jt S1IyofvTDw5rTYFznLP0lY8gYUSo8n/fU10QO0F3rPnxqfFJx0MoaoEgJT3VtFgocD sZ6QcH0rQNEjgoWY8RZTdedkLHdatfzIrPLETbDluALQGK4SMzLxMHW52E0LwET4yU kRrhTYOLHEv9S5kuwUUp4e76ZIExuJXfW0j3VPBA9cxD7+1gLGx3r6Ga1fdwxN8vOx qnzAvh/pG5eGQ== Date: Tue, 2 Apr 2024 18:23:51 -0700 From: Jakub Kicinski To: Minda Chen Cc: Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] net: stmmac: mmc_core: Add GMAC mmc tx/rx missing statistics Message-ID: <20240402182351.031f5b59@kernel.org> In-Reply-To: <20240401024456.41433-2-minda.chen@starfivetech.com> References: <20240401024456.41433-1-minda.chen@starfivetech.com> <20240401024456.41433-2-minda.chen@starfivetech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Apr 2024 10:44:56 +0800 Minda Chen wrote: > + unsigned int mmc_rx_control_g; What's control_g? If it's number of received control frames it should be reported as MACControlFramesReceived from ethtool_ops::get_eth_ctrl_stats.