Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2431853lqz; Tue, 2 Apr 2024 18:32:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX5tHSrVqj4k2bUVIfTTse7nWg3n67YjD/ANsrCc7X+jwXsuSq7/p670BT9CK7uR5MzA5U//KywHGlyCvrl6GfHfWgxgDY0+H+myuXFBw== X-Google-Smtp-Source: AGHT+IGVzn40Y3byuAh7ndZsrw1ruu1EHbwkqGIkXJzSeJrUeda+iNBdPtgQ+T1msrOFnopyjV/G X-Received: by 2002:a17:906:c2c2:b0:a46:8daa:436f with SMTP id ch2-20020a170906c2c200b00a468daa436fmr811711ejb.69.1712107974102; Tue, 02 Apr 2024 18:32:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712107974; cv=pass; d=google.com; s=arc-20160816; b=SO8/jatpk2J2ksuij8weX+bWr9VU9k4FpgmOiRSNQ9laKKiZ+midKsYLyqtXmwZd3g 0eydJhFGagYkvIGYQET2jmJMaoNZYgD558vumOw04d5+3A8TNTV/k1OPrCER1hfxLjUn CgCd250pFc0O2Le9krEY+5o1L0qYH29nzS9joQz4JGZBg9iIcJSRhYLJTLIKnKn5hOK7 mQfXyDDSvMROEFu9MkMH8ZOg9QwLx90LPNfNJS2K5Stn6IwFJtq+eAdI5r2y9GbPzT8x e+uH97rFKWGyHmjp5A2hPdUb1noxSxgeZPtMs4EqdEQ+pEj13WoQS/5YqM2HA9KIQi28 g37w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=oRpbO58bS6wgbOM+0F42odqHDtYYl/Zrv/VrwRCbV6o=; fh=zudqKqeNNpdKjCLyoJWFQUwCshpKX4XIlb/eUhOpeDI=; b=ADMMjePgdjOKdF579Ff7Y/RHkuYGVFFbT1S4wSBgi9tlhpWhzkiFI2hAUiIf9fTHgv PvjWzUQYCErM6qe9VuiBuIVQBGN7wwMYWmy5Ywd6xfKuhb6O0JEbi+HRUujfDSq7H1vW IOBh0hx1lyTJXL3C3wqxOwG4NYMRAtyWzI80don6MWDXKLSyYEGRRxDcPum8+bmeO8ln zxL2etJg7zcDdMuH4GqizUdpVelfoKTwW0gbZYXfEaMbZVDPFFluJkBP2gEF3xfHhSlw RdmWJh6VM/TjHKZdSNHDxLgFG7CAe1QA8TbSjC9cGlin9WIHuiKO/LA/+xtzN6cP01YZ uV7Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="He5l/yN1"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128933-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128933-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lr9-20020a170906fb8900b00a4748fc1457si5913932ejb.845.2024.04.02.18.32.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 18:32:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128933-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="He5l/yN1"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128933-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128933-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B2C201F229AF for ; Wed, 3 Apr 2024 01:32:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DCD2C168DA; Wed, 3 Apr 2024 01:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="He5l/yN1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 057E7125CC; Wed, 3 Apr 2024 01:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712107959; cv=none; b=YWRZO12ZmVUQlTbTHhPkFbDs7ptUz/W0Rmkh3FpljZb6SWIRPFkgWI2Mb1APlaQkhSlGXD3Exx8EH6Rzq6fvsYq68F/5PVqmp6dqaoCsv5YnDaEeNNmCsWC6JxC+ia2FhDw+oQg5ykblaSYFzDNWxFr5emM21W/Ns1R2IlHLqpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712107959; c=relaxed/simple; bh=Oboaa00MtZpqJcZQ4Qg/6jeTJtT/d7JbGLI3XZvpfR0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HMEyaH0v1oAHAAaBF3tPgYrVqdp6L/AILc1FRke+yq9qpWlUXr7Qbe8PU+IkwdSa4KnpH4EXkhfZtozl78r/aM/Ph4kUcCLKaTzTu8Euzs4V7ubIfBybb+YGJFGQ4qWVLc5dnb2lx3pw0146FzqYV8ktrbRbCPvEnxqv/4X/dpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=He5l/yN1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F789C433F1; Wed, 3 Apr 2024 01:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712107958; bh=Oboaa00MtZpqJcZQ4Qg/6jeTJtT/d7JbGLI3XZvpfR0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=He5l/yN1ZyEm5maG6+l8s/LFRBCDTt0AY7sH2PPSoULJHn+m/op4bQY9iLI3yXcjD YmpvCEhrq/bs+bh+lzpkGCWbzcuLEOSD3wm4XyW+IeprpX/Jz/zprpAw3F3xqNZpcm RFpbyxrUEOEqp0J8T//wUMoae2i7psHmtwJE3VFgpnnI7gmian1VYO8feDGCB/TAFo WO96VKK9aG+P/1z+5Cm7OdsBsPfufEZbym2+9WWLy87G8VqQhRdjNZsFgnvtTjYlcf jStSAGuLB9yqBDL0pQJ83urFSbhX6r8hXLXqq5bo+2fdmPyZbrDESQTxEU1xi10A1/ 3oRiEH6lA7TOg== Date: Tue, 2 Apr 2024 18:32:37 -0700 From: Jakub Kicinski To: Jose Ignacio Tornos Martinez Cc: horms@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3] net: usb: ax88179_178a: non necessary second random mac address Message-ID: <20240402183237.2eb8398a@kernel.org> In-Reply-To: <20240401082746.7654-1-jtornosm@redhat.com> References: <20240401082746.7654-1-jtornosm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Apr 2024 10:27:25 +0200 Jose Ignacio Tornos Martinez wrote: > If the mac address can not be read from the device registers or the > devicetree, a random address is generated, but this was already done from > usbnet_probe, so it is not necessary to call eth_hw_addr_random from here > again to generate another random address. > > Indeed, when reset was also executed from bind, generate another random mac > address invalidated the check from usbnet_probe to configure if the assigned > mac address for the interface was random or not, because it is comparing > with the initial generated random address. Now, with only a reset from open > operation, it is just a harmless simplification. You need to wait for the other patch to get merged, then on Thursday after that the trees will get merged together, and then you can post this :( Otherwise we'll have a conflict. -- pw-bot: defer