Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2433900lqz; Tue, 2 Apr 2024 18:39:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWce+1UO4MnsDP7DbQ5Jxj+6kyvTTshGxIzgP7p+YfNu1nIvddsBOwQm9lLhf0lEPP3JnXdCuAZI34iuYRy9kjc1uDk4rFsBijBe1AFqg== X-Google-Smtp-Source: AGHT+IHq13Lt0xt9RPoVIRDhCjnHYibKw/3RA9gfe+h8ZZiEHUUwyuaR5UnG9wGkr1OgCep3i+Oo X-Received: by 2002:a05:6a20:5485:b0:1a7:c31:2695 with SMTP id i5-20020a056a20548500b001a70c312695mr9192817pzk.50.1712108366592; Tue, 02 Apr 2024 18:39:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712108366; cv=pass; d=google.com; s=arc-20160816; b=wE36thNpMg7UiP5sf9w+G4m+1jF6l7o1vX4HxbdVnnch7IzFvBFE+/LgHakmqwEuxW sEYirPMDnLGDVzxfmnw8FBeWkaFYs4ki2qbAFp/HIklLiWsYQ57zCG9jexydE1HvYbF+ H3Gzc2BpeLJpZvHtScrQBwn6LJ5JLokZdoQLsunDcOlj4k+/tpMAk+CsaXSee56iENYk HOKNoIletgx+C9XnxM0Kpe0U4qqY5yNdIH2B1Tn66S04DBuWJy+2twSZT81zTILshipC 5zwxZfPyFHjzzXXJROretA8bi77CK7RPqCal458b8j4ZMaT8MTm6GUBiPxBfx6jIwhzY dciQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=0Qrgt3WqdCsmD7UYqN+2rkvfQa3UpVD76nel0UbifuA=; fh=KKyn6VGWu3LdUXeoLjuzG9u6smk/63nUTwyjRVx4MIc=; b=LObomSWMy8kUAOZA/zo7LL4sETdr47rqnhLWCUpYFj1Pz3bGWU16jf7p8dF3aDgfcp SWUvnuKVV/fXYMWciyZnIDBRGTkOOIkF5qwOp1Yr8BvO7jplGY0+xZy23q/PX04Z2Oh3 KexDSUHQ7IaKqDqrniOvGYdBORguvGWaG2tIayFx4Pxi8SR+CcK8savoZ7LQBFRGkQSq eH2Xe3u9JKYWak0G2Iuu++iBjeUh7WwHdL4kJS214ZsTwutY60D+2sIFszDDwN4GomBE whlsJsCApOL3n8VH+s2vC2TlwBEjhPG099UeJjC4xK8JNKO//z9++Wy/R6v5+fklHGtI 0eOw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jl3xGZLw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128932-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a1-20020a17090abe0100b002a041630ff8si12450131pjs.134.2024.04.02.18.39.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 18:39:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jl3xGZLw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128932-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F315128B3B2 for ; Wed, 3 Apr 2024 01:30:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 338FB17579; Wed, 3 Apr 2024 01:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jl3xGZLw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4943DD29B; Wed, 3 Apr 2024 01:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712107814; cv=none; b=vDl0Y1KDURI+X07d04JmT6ZtrCJqJ2R4afKEjaTgWfIlcmjjch2NChHvg/BxMc83tH5lDEEWQ3jw98ZXGzY7uxoUIN75XRhtveXCsMiXgKoaDvmbvBVXpira+GpfFetJEl2LBuKiE+wwq0zuslGyfMpDOb4osS1QjyRAGBtYN1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712107814; c=relaxed/simple; bh=+Scx8EcFtqXCkuZhNG7HB6hgS11bWyDfN85ejbuaZGY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ilTQ+FJ3sD9rRbyFpgnpf3zHxMb9hyxmazvYK4BZ11BXtdGFxYz1sJsMNsE856AXGQifzQY0HGYiMFFNdPpWkz8Gj8G/n9BIsObh83SxrRpgdkxvKIegDD1nB4AKFreOWKs3IGjtYJoseA1jBZAZNGD7+6/9VgJsQqiQAsef6As= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jl3xGZLw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 994A3C433C7; Wed, 3 Apr 2024 01:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712107814; bh=+Scx8EcFtqXCkuZhNG7HB6hgS11bWyDfN85ejbuaZGY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jl3xGZLwHRdq3HJ4l18gIV5tMaEgAQLiN2uE4FtRW4ODespwlXylnOqPRC9BmW6Dk ERcsEkkyXl64D2zPJjBH074Q9jerK0TABNGhZ5vzoI6x2c3UOeUCdUd1ILAFFNXqxo eiKNHlVpIm6vN59/qSYRpI1IWvMUb/82uleiNUPJssaSYeBHTa1GAAFMN/ix8AjVo6 xrGwVcoqeuQI/Irn0IP/13nu/wVX0sS4D3klZHw0/lFczJM4MortEkG5w+uEydsxFc hJdL8AWAx4kAUmR3wR1o0MWB7TeaQeHmgfjUX9/VI4sVKMqeOu1xABnDKMAPZodS2d ukKgR3g/zS1bQ== Date: Tue, 2 Apr 2024 18:30:12 -0700 From: Jakub Kicinski To: Jose Ignacio Tornos Martinez Cc: horms@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dave Stevenson Subject: Re: [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address Message-ID: <20240402183012.119f1511@kernel.org> In-Reply-To: <20240401082004.7412-1-jtornosm@redhat.com> References: <20240401082004.7412-1-jtornosm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Apr 2024 10:19:50 +0200 Jose Ignacio Tornos Martinez wrote: > if (is_valid_ether_addr(mac)) { > eth_hw_addr_set(dev->net, mac); > + dev->net->addr_assign_type = NET_ADDR_PERM; Are we 100% sure we won't read back the random address we wrote earlier? Maybe let's put the assignment under if (!is_local_ether_addr(mac)), just to be on the safe side?