Received-SPF: pass (google.com: domain of linux-kernel+bounces-128947-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Minda Chen <minda.chen@starfivetech.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu
	<joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Maxime
 Coquelin <mcoquelin.stm32@gmail.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] net: stmmac: mmc_core: Add GMAC mmc tx/rx missing
 statistics
Thread-Topic: [PATCH v1 2/2] net: stmmac: mmc_core: Add GMAC mmc tx/rx missing
 statistics
Thread-Index: AQHag96avQqP5Wam70CUDUnMD23smbFVw26AgAAE1KA=
Date: Wed, 3 Apr 2024 01:41:09 +0000
Message-ID:
 <SHXPR01MB086358DEAFDD853ED4103D57E63DA@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn>
References: <20240401024456.41433-1-minda.chen@starfivetech.com>
	<20240401024456.41433-2-minda.chen@starfivetech.com>
 <20240402182351.031f5b59@kernel.org>
In-Reply-To: <20240402182351.031f5b59@kernel.org>
Accept-Language: en-US
Content-Language: zh-CN
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?gg4UoGmpQbAzyybkDbyXxRcmbi9wBRTRNu35KUSeLfvwtzjdlLBQB3K/U+Nq?=
 =?us-ascii?Q?8Kf+sJ4RfKPK0qN9OCTiQ7eYxbJTMT/k11Bilf6U9b0JzcgAHMHapawyFuSv?=
 =?us-ascii?Q?eD5puz7GoOa3ItaW+yOT2inSsfeRuVCnIGUOSk6NLarVSI79/D4TnLWuV6sz?=
 =?us-ascii?Q?QWYc/ihuZpNxdwIDd7dnigQukIBjLUZ7zQuvalT016KDCZxI3SuY0YjdDVZZ?=
 =?us-ascii?Q?4Nwj5mmNvofncD+14U0BXJhEg5/DwQ06+Y4WAiW2A5YUfFiqf1u4FLD36ltp?=
 =?us-ascii?Q?rr/Cz7IaRcZgttgd0y6QFqZL/bpXeVG3mGYwcirtKnjA3usUqkEU8/zbPq98?=
 =?us-ascii?Q?W/iZfhY4rqqr6pcVr2pJyQV2HBHDPiDRql2fjUt03IdgLM36lyMNM0oALTUN?=
 =?us-ascii?Q?kIuX1i8vODPxfY+A/Zczpns0CEHu4JHitZ91NdRzjt+5hF33c6CUgcovjlnD?=
 =?us-ascii?Q?q4kSR6J9qpPqITSodVg7tPjAwNSgeukisRTJWL+yzZ76HrjYjghAeQGmFwaF?=
 =?us-ascii?Q?nJKYx3MjGP7Cp7FLNMFW1/FIyKM+ElBXqbI9SJSeKm3PwFtzxQEZYSFX5+cG?=
 =?us-ascii?Q?PiCE/B9RwdxZRB7Dc4VvB6pJLsrpEhYAV+tnC6KAN1Bk/zjBx7jRour+Qi7s?=
 =?us-ascii?Q?E5AK4YXCY2TJiSpjEY1L5DehWWu7Al7nCyBaEc1iCg9IbcRuh4Z+dQuEE7BN?=
 =?us-ascii?Q?HpFQNcCUMr+jlJt5spAJokEc1lFsAZ5hKO3Z8ysmtkF5OEI0lbKtbwmkzNDx?=
 =?us-ascii?Q?f1T+K1D/ToFaEI1QX69iSrL49BWvC2DmE2rcj+rJ0xvygDE6QoF5AyGBYLNo?=
 =?us-ascii?Q?4j59ddhLM5tICTUDI6XolR0JLdFh2YuCNVk3dYJ+qmGR+/wkW7W9brm4/vdb?=
 =?us-ascii?Q?Bjt/+K9d9Y9+aUz6vemR7oQvc66ijdaavt4k8dmK5mFc7E2vXVooHc/jvb33?=
 =?us-ascii?Q?9Uvmq5uIUMwzdmWWnyv71FUgNYkgi4O+Yjm+5xe6rCexhOpZCi88sJPWvCJO?=
 =?us-ascii?Q?G03XtsWH8iuHOUTtcF4E+8KbBs2kT/tp+zaCh6ivyfk+D7cBKHQlQiILkEAe?=
 =?us-ascii?Q?09uwRBQAItKBbLRL/IVFFEZTTV/XmO1KRL7E9jOG8aXn/Opvc2COzBJTomkd?=
 =?us-ascii?Q?QHVQIxWaYo5obk5gzlQN9DLHkJtiaYLeDyrD3l+m5JzW1I9BUUFj0qI4Qb7T?=
 =?us-ascii?Q?QAqYij3ZQlBYYmqsV53myaJa12RUMYaBRfn2ugF6fB3kdSEXH6EE6hX79E42?=
 =?us-ascii?Q?nbqi3PsR2lWzuNAZFl/3Kdux1WntHEcbxa5KDHvx0GTU/yIKPLVixg34NMkG?=
 =?us-ascii?Q?YSOoQg96q5m/rjM5J5Du5zB1vRQxqcO/BpozIAma5h2wrleNdi/cv1Wyv7lO?=
 =?us-ascii?Q?85G+UdS5DHsHs3BL9BOVOaqQ/dbTgmkS/lnb4oPgtzDrf6lSB9/LZvGTrBkf?=
 =?us-ascii?Q?BvevyTSx5zzdfwnW7bFuKoUOuEN6B3Raf8qM2QaaeoNTVVUi9omcJRHlH6RM?=
 =?us-ascii?Q?c4TMtHyyiukj2jFdSxMpq5rUEGjYolza3GrBP2l1cX3ZHl5AJqlN3rk3O8+G?=
 =?us-ascii?Q?F123x2Ke9ZlIva8Nf0Agl82THGXfw5CDO1OaONgW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: 24d8e265-8c25-4e1d-203e-08dc537f2335
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2024 01:41:09.5990
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vCO3hJOhLkbOkZIzPloOI3v3h63zvhPy1CMrIXTddTiBfmsjxXhowZNlDSHBWF0steGtm9RwQAkXZkoCF6NNUL/hDs/tz6iE2k1QkDmXMkI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SHXPR01MB0847


>=20
> On Mon,  1 Apr 2024 10:44:56 +0800 Minda Chen wrote:
> > +	unsigned int mmc_rx_control_g;
>=20
> What's control_g?
> If it's number of received control frames it should be reported as
> MACControlFramesReceived from ethtool_ops::get_eth_ctrl_stats.

This is explanations
Rx Control Packets Good
This field indicates the number of good control packets received.

It looks it is number of received control. But I don't know register offset
in designware XGMAC IP.I can't implement ethtool_ops::get_eth_ctrl_stats.
I will delete this first