Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2446521lqz; Tue, 2 Apr 2024 19:21:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV4WXAfa9U+fkuN7IkD3XGNmsw9PmEkv4Yb1dJWvuiFpl5mhRb1Zw1wjoc6Lf+Dzw8sP2QKh+MkTPnbz2AvrrGPC50iKU0PRYcB0Z8tuw== X-Google-Smtp-Source: AGHT+IEFAqXaHf+RSYJhw0oQkjsYRQ2oJBBuBWrc2S3vo9nr+1I8Tr3xQ+yIBXgi55jU4nOJTFZP X-Received: by 2002:a9d:7841:0:b0:6e8:9db4:26b6 with SMTP id c1-20020a9d7841000000b006e89db426b6mr1480480otm.29.1712110860940; Tue, 02 Apr 2024 19:21:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712110860; cv=pass; d=google.com; s=arc-20160816; b=alnkdJiF3BSef9VZjzWpAr/8T/RlK9eUyDHY7SD3SOAZFohQ9JYrzcpD+PNUw62CsV 3e/8LruGZBm5E7z/LbeerzeBQpS1cRlpmEPQ9h5kaa69q9aeuhhkiMpDGJ82aQIuicmM GNOPXf2+JXCembsa/k0thDHHJBO1rXhchlc4UH6vhB2aoGVeYorQlSKtHnBAsEvRBVvg vizyj5VvMC6JAjoIEJp7d3PTPtDL7Dc9SHpEpoP/kgAH7p6h4C2u5odLIFOANwxAUcOp drkeZ9DD8khIIeSwGLV8tHnpO6k4tkpnsnAU5hE4NXbCx/gnrSEnhesMLM0ERBLjJtVk 21CA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=TGusFRF8CyyRPjbVN6c3keIl2wcorkZc+wRf8z30m5w=; fh=jf3czSX9Za2KbvZptI2hYMh5uxhsL2TaVuBrJSBIMq8=; b=HCWk4axYEbrO0zzdzknUF/4TsdowtIB4EKgziqUGk1W4FmaT3XMHAt8luj4aocEqCF iewnVuPbBqZUZbIUX/JxZDM6ikIYq6c1ZXQofROBX7QH1lFZy7KbZ1fPd4bonVxzsmiy uaeJKJ3kcNSHrecIHlXP1on7FdsmXfumIZKtyxRwm+OkcOcF7/sXGcteXSkhN7bD/Sqx 5bNMB011T5pT4U/xALDyVPvcZFk+h02CvrQKvDnq7dPQLHHnuwap5nKZMiZx57lUCWho AiOgqlbHHEIdPuQPNERr4Ntq1bw8AK9/o53z6LDJZdVRwvlvAsPbQqH7IDXuKoTh4W+q VByA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ldzThvtW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128971-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128971-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l9-20020a633e09000000b005e47afd5c60si12249805pga.646.2024.04.02.19.21.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 19:21:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-128971-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ldzThvtW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-128971-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-128971-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 250A5289FA2 for ; Wed, 3 Apr 2024 02:19:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4908D1A28C; Wed, 3 Apr 2024 02:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ldzThvtW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E19B259C; Wed, 3 Apr 2024 02:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712110725; cv=none; b=QhmFOPoTaoEMs+ArM4DC+P1HsemRkxSh4TuH6JPOiGvzIOJ9jZ3ELPGfXUleEO2zumaPfJnxPTJk9KdtOPldyw6+4L4FdldKorqpgr4McsWJewevaK0pcnTFYyN7vn+SynvxKiGMRrYAN2VPZGoQhG5Rqk7e4hWBNP0qPl7dYzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712110725; c=relaxed/simple; bh=R9fYilqkrq8iygPPfkADp53ieAs4A1QmT22VdM+Kzx0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NdI8dlEBE0c3Drazw3K7CQqyw9X+BEK7fS175bgNll5L/lv5baDOuYi6ASltyf8dE6IQkyiGnavtJ8PgH7NR9sH/ZQFLIjNifOhM05MwBSXbrUiu2q5GeUDmgzBk9NYUVa44795TEZp50pL8cS+cOXP3zs8zHdLJrC0I0inONuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ldzThvtW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46777C433F1; Wed, 3 Apr 2024 02:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712110724; bh=R9fYilqkrq8iygPPfkADp53ieAs4A1QmT22VdM+Kzx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ldzThvtWNA0erTrSs7uhEuDgTYSgBfZOqKybUyWm1XIYfMZAfKiWR42lAFxRNy/Bv BvQn/gzakiVqrug9ujsyKqUbp6QZxK1ovb6Nq7+ZLf+Bj0rxRln51+iRYcNV6iY8fz o7mZHaszxC5zhBo+mYDxHB40nE5Qz6bGV+4n/aR3E9AMTmrc5WLqAknrShG8wyJ+t0 nAW//8QRJECBqoAVa1dpfVuq7GKCPckzMgTVSxK5xbM6Kk+q+9ZH6kZ0GmOBN7xAPN zDOHPyA+IRksao/mg0dD/CuKqo7LmuEHSu40ukRA+FBmNVfh4xp1E1SNgoMd98l5Cq mTlHPTSY51drA== Date: Tue, 2 Apr 2024 19:18:42 -0700 From: Jakub Kicinski To: Rahul Rameshbabu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, ahmed.zaki@intel.com, aleksander.lobakin@intel.com, alexandre.torgue@foss.st.com, andrew@lunn.ch, cjubran@nvidia.com, corbet@lwn.net, davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com, gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com, jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com, kory.maincent@bootlin.com, leon@kernel.org, liuhangbin@gmail.com, maxime.chevallier@bootlin.com, pabeni@redhat.com, paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com, rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org, tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com, wojciech.drewek@intel.com Subject: Re: [PATCH net-next v1 1/6] ethtool: add interface to read Tx hardware timestamping statistics Message-ID: <20240402191842.66decfd3@kernel.org> In-Reply-To: <20240402205223.137565-2-rrameshbabu@nvidia.com> References: <20240402205223.137565-1-rrameshbabu@nvidia.com> <20240402205223.137565-2-rrameshbabu@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Apr 2024 13:52:01 -0700 Rahul Rameshbabu wrote: > +/** > + * struct ethtool_ts_stats - HW timestamping statistics > + * @tx_stats: struct group for TX HW timestamping > + * @pkts: Number of packets successfully timestamped by the hardware. > + * @lost: Number of hardware timestamping requests where the timestamping > + * information from the hardware never arrived for submission with > + * the skb. > + * @err: Number of arbitrary timestamp generation error events that the > + * hardware encountered, exclusive of @lost statistics. Cases such > + * as resource exhaustion, unavailability, firmware errors, and > + * detected illogical timestamp values not submitted with the skb > + * are inclusive to this counter. > + */ > +struct ethtool_ts_stats { > + struct_group(tx_stats, Doesn't seem like the group should be documented: include/linux/ethtool.h:503: warning: Excess struct member 'tx_stats' description in 'ethtool_ts_stats' -- pw-bot: cr