Received-SPF: pass (google.com: domain of linux-kernel+bounces-128983-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 3 Apr 2024 10:49:56 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 106/130] KVM: TDX: Add KVM Exit for TDX TDG.VP.VMCALL
Message-ID: <ZgzD1FPZV4A45m/e@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <b9fbb0844fc6505f8fb1e9a783615b299a5a5bb3.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b9fbb0844fc6505f8fb1e9a783615b299a5a5bb3.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ski7kFSPm7QVNF+EMQtLtuOfYpEO9Z5jue2MOwYxE256pWIxm2PaSsyGijk2?=
 =?us-ascii?Q?P+qGt8eGrWKKR9MXrZe9KQZEDmyeB5i3VDt6LSFlhkmtCTvfWL4VMsC98WxV?=
 =?us-ascii?Q?akkxrUuyPo1MC7EJP203i/vFEGoC/c7YgODSYkpuUYPc0yQz07tkjHMtONKo?=
 =?us-ascii?Q?X4z3b58y96iS1iXsPdnYfjp9t1DNRCOe40xMmqc/H0LeqVtqbKkVFi4O+ymw?=
 =?us-ascii?Q?fOBaVtlcjXTKJsy/gYX7K/41bnA95A/5/t6n3KNA3UprYz3ktgTd1N8Sw1gJ?=
 =?us-ascii?Q?x7j32+q9o2pSrExVEBD0Hvcod5LwkwxzvuKCnxfsUiDu/ZEcX8ij235CZIVU?=
 =?us-ascii?Q?mtRvrARsaBem6FaUrM1kheMtxUN1HBJZfip9QdUjqQdrx3E//O8sohWZrFon?=
 =?us-ascii?Q?Z2ZyhLWaxsPnInU6jos/ENy8nhh/1bHKLoAHFxujql/G3EClZhMF3BieuO4A?=
 =?us-ascii?Q?sN3nrAmReCQC+0aT/G3S7WotZlo+KZ6axDuKvvF+og82a0sOwxD3ITPDwlkV?=
 =?us-ascii?Q?E+ajzbTzSNkQguMfVB/pGuwW9Y+Z4XMgrHy9ks2aoBmD+GapI+OsrRkN4MJ0?=
 =?us-ascii?Q?FykgsAgg1j1N9oqC1iImlPV6Iquevvje1tImVCTy60PZrKQfc5wfDm9n+dK7?=
 =?us-ascii?Q?NSmT2nKhARYqiT/eAlVnZGgi+Yo+aQetPEhd9/EEzJB7gCLPBJSe1jO3TnA7?=
 =?us-ascii?Q?1o25BCcOH/vSXG02WgaewzWIb/gpxZEJIVIyXnvDfxlHNKIP0TpcncFHuHWa?=
 =?us-ascii?Q?DLxWWoqQ56Z44npsoyAH0SQOEZP6DUhdGeTf9daVntykby09opGxD+qoQHxm?=
 =?us-ascii?Q?0d4scZ34rB4SRgZzkgN/rFD2j3szOcbo8P4atIJfdx0nEtbB8euQMEygFqZZ?=
 =?us-ascii?Q?mI63dvVwsgeIy8fpYg75VH6gRmBAx3oLpF10L1xcCTB3TCvBdRyeVTBpInoI?=
 =?us-ascii?Q?ask5UCe44HguAUTTp/Iv6JiKlVfOr4O5/2ZT1PnRljpFJHNRRBhvsMvyD4hX?=
 =?us-ascii?Q?J4XggsR16VLV8BGE0JbpVDHfn/UogVE2JLkNPXddCrUr0LyeaAufkDExnYGO?=
 =?us-ascii?Q?tgcusqmj5xFDw0Bnav5kRAK+GIwbDNd79s/bK0VWDMQBCWmu70Eyk3oZFuvo?=
 =?us-ascii?Q?ukwf9MHAQqHKt8rXehElGknD4luSYHKjmyLFe86Alp1NskZOzfjv5h0d5BDP?=
 =?us-ascii?Q?gCApPGAWuo27RCD2neJfBjO8dDMfck+RovJMgDI8TYKwM8r+GoKFRe/xMasX?=
 =?us-ascii?Q?RwaRu7T+z5t+TuXwNuqRzLAeOLA5L299f75SNCFicfSDBzx7Mn60xz9JYoZp?=
 =?us-ascii?Q?hcTf+8ChBMvh97d3DTlvNKeXtpN8OPKETwMhrc7R2+Jm0Rh9KNoRdjItwabJ?=
 =?us-ascii?Q?Yss3KkWOrOMNE+B1YoKk20frzXUfodJksemMirYY0ElCpRogNyevu/guzlvf?=
 =?us-ascii?Q?9bsVcXEJR10MdMzniDcCcmptKeziOmD4kKRkWwPcbN1ozdAbt8GqK/QmWFtO?=
 =?us-ascii?Q?tvxsLmpij1uvOA5escGAj+8LslmOgRYsdVCkSx8tTJeB0HI4YMc+Pla9fEAJ?=
 =?us-ascii?Q?4YzSsRQRECK4mXobov4KSAUFoi7gPhnHFtVbCt48?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d0396396-b6e0-41a0-906c-08dc5388c499
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 02:50:06.0319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gZ+setJ8ImzGm+FPjgE+3OYx1Uck8jjGEjm8BeWli568k9d93LMFYZqQxAIn6+xw6/oxDrZvHxw3RaWhUFL7lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5142
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:26:48AM -0800, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>Some of TDG.VP.VMCALL require device model, for example, qemu, to handle
>them on behalf of kvm kernel module. TDVMCALL_REPORT_FATAL_ERROR,
>TDVMCALL_MAP_GPA, TDVMCALL_SETUP_EVENT_NOTIFY_INTERRUPT, and
>TDVMCALL_GET_QUOTE requires user space VMM handling.
>
>Introduce new kvm exit, KVM_EXIT_TDX, and functions to setup it. Device
>model should update R10 if necessary as return value.
>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>---
>v14 -> v15:
>- updated struct kvm_tdx_exit with union
>- export constants for reg bitmask
>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>---
> arch/x86/kvm/vmx/tdx.c   | 83 ++++++++++++++++++++++++++++++++++++-
> include/uapi/linux/kvm.h | 89 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 170 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
>index c8eb47591105..72dbe2ff9062 100644
>--- a/arch/x86/kvm/vmx/tdx.c
>+++ b/arch/x86/kvm/vmx/tdx.c
>@@ -1038,6 +1038,78 @@ static int tdx_emulate_vmcall(struct kvm_vcpu *vcpu)
> 	return 1;
> }
> 
>+static int tdx_complete_vp_vmcall(struct kvm_vcpu *vcpu)
>+{
>+	struct kvm_tdx_vmcall *tdx_vmcall = &vcpu->run->tdx.u.vmcall;
>+	__u64 reg_mask = kvm_rcx_read(vcpu);
>+
>+#define COPY_REG(MASK, REG)							\
>+	do {									\
>+		if (reg_mask & TDX_VMCALL_REG_MASK_ ## MASK)			\
>+			kvm_## REG ## _write(vcpu, tdx_vmcall->out_ ## REG);	\
>+	} while (0)

Why XMMs are not copied?

Looks you assume the guest won't use XMMs for TDVMCALL. But I think the ABI
(KVM_EXIT_TDX) should be general, i.e., can support all kinds of (future)
TDVMCALLs.

>+
>+
>+	COPY_REG(R10, r10);
>+	COPY_REG(R11, r11);
>+	COPY_REG(R12, r12);
>+	COPY_REG(R13, r13);
>+	COPY_REG(R14, r14);
>+	COPY_REG(R15, r15);
>+	COPY_REG(RBX, rbx);
>+	COPY_REG(RDI, rdi);
>+	COPY_REG(RSI, rsi);
>+	COPY_REG(R8, r8);
>+	COPY_REG(R9, r9);
>+	COPY_REG(RDX, rdx);
>+
>+#undef COPY_REG
>+
>+	return 1;
>+}