Received-SPF: pass (google.com: domain of linux-kernel+bounces-128990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 2 Apr 2024 23:10:07 -0400
From: Frank Li <Frank.li@nxp.com>
To: Shawn Guo <shawnguo2@yeah.net>
Cc: Fabio Estevam <festevam@gmail.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Philippe Schenker <philippe.schenker@toradex.com>,
	Max Krummenacher <max.krummenacher@toradex.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Joakim Zhang <qiangqing.zhang@nxp.com>, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices
Message-ID: <ZgzIjziArPh8wnHA@lizhi-Precision-Tower-5810>
References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com>
 <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com>
 <CAOMZO5AJrQ5jyV4A-tvX93-R0_nEWpEO9YY3f5DpeXaAFO4cSA@mail.gmail.com>
 <ZgwfnZJDRYmYy7Qt@lizhi-Precision-Tower-5810>
 <ZgyzxmuMIK87C2nW@dragon>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZgyzxmuMIK87C2nW@dragon>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?dDQ1dWtteHhZWVppUUR4QnVnR0VGTS83Z1I4T3hGUmRucXBldlFHeHg2UVZt?=
 =?utf-8?B?c0NOQTdxZHhYTklkRXhxQUFzS3B3RUlaWTcxVmNTKzBaMlJSRWpPTGRjZE1E?=
 =?utf-8?B?S1ZWTTFDNjBHM1pEQi8wQnRoMEZjLy9lQnpsY0p2MGlEalhTNzJSbU96L0FV?=
 =?utf-8?B?eEY4dWhDSzcvUzNSVy9IbndnNkhXQlJ3YVc1REJ4T3FkendsYXVFWklDWWVt?=
 =?utf-8?B?K1NzOUwrUjVESCtxMndXa1lvRFV6cmNsQlo3blJ0RGxYekhGR3gwL3o0YU94?=
 =?utf-8?B?VFRWZm0yS090TVVvR2dPL3NSUXNGbGt5RUVRYVdqdlJRMG5YN09HcS9mV0dy?=
 =?utf-8?B?cjNZU3drb1R0aW5lK3pXakNnRHhrK2hzL2c3eW5zZEphREMrdDNoYldzejF6?=
 =?utf-8?B?Z1dtbzRIdHNTbTVQcHR3K1JzQ1FhTkVjMXRsczhkOHdhOHBYbEZBUnl5cGQ3?=
 =?utf-8?B?cVJrNk5oTGVxckgvcHNhUzQ4cTQ4T0Q0MXVIakdOa0xzb0k2OHZXMTV4VjhK?=
 =?utf-8?B?TlIxOE1lc1NyTi9DeWVuN2xpTkpLR2JzYnZha0lzOVdyc0xvbTFpZkV0WWlX?=
 =?utf-8?B?cWUzSyt2NlVRZ3NXd1JHSzFwSzNSaExmd2NlWWVrT1RFT1k1cFBTcDV3Tmhr?=
 =?utf-8?B?WWZ2YWFCb1lxVlM4UXByMEY3R05hSW8zMVRvVFBvUXNxcXh4bnJWMklXRHVp?=
 =?utf-8?B?bE01WGNUOUtCMGh4QW9ZdlduaDQyWTB1OVdCZjk3azdVVi82SDgxcmtmV1BE?=
 =?utf-8?B?WjVrd25kQmN6VnpSZzdmZHVwSGs1WloxRUNZSlhFcDNyelRRTEJCK09ZK1hs?=
 =?utf-8?B?czJEV0pUWkFFVmJmbUlzOUtaWUx2MHRyNEgvbUNIcitzUFRWNHdHdlNOMk9o?=
 =?utf-8?B?NzA5NTBxSlRhYlczUkppQTRDdG5yQzRjRXQ2VlRVVmhqMGdTVm1WaFRlaFIz?=
 =?utf-8?B?S3BweHdRR1dTNjJVR2NTclNuT1JmQzYwNWZOSzFjcFpKbUNrU2tsRWZBU0tM?=
 =?utf-8?B?V1hRaS91N2ZVTVN6MUZIbW4vdVVpUFhxYklzK1k3M3lCU3VJK3MvTFRRQXpX?=
 =?utf-8?B?UFZmbjkrZnIvZkg5UW1yemw2SU1WT2dPbTI0SENDdk52RzRTR2dGZWpDUDBs?=
 =?utf-8?B?VncwdExUL3RxQ0FOQ2RDd0RUd3oyQWlBZklvQnRqemdGd3ZySUxyMm14ck5V?=
 =?utf-8?B?TE1hU0JrM2lUcEtiZVBOVWJDcGIxdGZ3WXVGRDNjclJxditMN0MrdDdzV3RL?=
 =?utf-8?B?VmlFMDcvSnVicU9wZm8xYVBvVjZZSHBUMDgxYkZ3MndKT1ZoamFVcFArV1hl?=
 =?utf-8?B?QklocVFtVUZjSmR1OFIxd0JaKzdEdTJGM2JFdzRkV0tkTFFmUjg1R1lKQUox?=
 =?utf-8?B?THJmSUVCRWtqVXdNdUNCZ25KMUZFUHE1dE5TcmJ4eTVqMzVvYU1KaG1BSWJG?=
 =?utf-8?B?UER6cXY2cHczUVV1aHVQdWtGK252dnZtVkJnS1BPQjFHaitHMnEyK0ZxckhR?=
 =?utf-8?B?NDljVjFETldQYSs3UGl1bWlTbUg2WEtYNklZbnlwb1FnTHdYN2lGWlBURHlr?=
 =?utf-8?B?MkFIZmdWa3F6ODRiZmtYS1dUa1ozaUdTVGprVDBDblpzQ0N6bFgrR21BTDNC?=
 =?utf-8?B?QVMwb2FxZE1BSm9oQncrdDZrQnlsZ0RDZ0pRTHhNQjlvTWdSa1EzTXY2ZmE3?=
 =?utf-8?B?a21kMG1pcU1UQnN6bnNxaHdmTXRJQjdNUHZLWVJ6Qm1MMVgvK1BNQUxYUTVn?=
 =?utf-8?B?TDVONnpVSjF2VG1wOFBYRTRQYUdqR2p5S1RyUldtblZZZmo2M3Y2MEhTdVpF?=
 =?utf-8?B?QmdTeHVsSzd0UGM3UXdSZ1c1WEdLcFRTbmdzVWZTU1Y1Zk5LdWhLN1RZZ3g0?=
 =?utf-8?B?TFUyQUZ4eDJ2K2lLU1lKZ3IxUnJVK05UNmFGaDYzUmdmZ3RGbTJ6d25ndFg0?=
 =?utf-8?B?UTZxb3l0NmNNL0lKT2J2dmE0Vm4yS1JwREhIalBMWUs0RkZOL0x1V0xhR3ZO?=
 =?utf-8?B?ZlpjMkNyTXkrTiswSEVEOUNMejQydVhMd0lRRjQyemJkUXhrYklHYlMyd1Vt?=
 =?utf-8?B?R1J6bHBpdkxpYjFKaEtLSXRPL1VtUS9CY1VHOURRVUcxNFRIWW9qamRvMWln?=
 =?utf-8?Q?M40ma4AJ6cAtwH/hcu6syxn4p?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3db6170-68ed-4e57-0220-08dc538b96e7
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 03:10:17.8788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: INZHysp6mSFcdNSTRVKmsQvRcAWOn2Fi/VgZzkVf1FY9PdVEHgkd+IzBm15qXUXrv1cTr52yc976RxQlsV5kQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9227

On Wed, Apr 03, 2024 at 09:41:26AM +0800, Shawn Guo wrote:
> On Tue, Apr 02, 2024 at 11:09:17AM -0400, Frank Li wrote:
> > On Mon, Apr 01, 2024 at 08:04:56PM -0300, Fabio Estevam wrote:
> > > On Mon, Apr 1, 2024 at 7:25 PM Frank Li <Frank.Li@nxp.com> wrote:
> > > >
> > > > lpcg's arg0 should use clock indices instead of index.
> > > >
> > > > pwm0_lpcg: clock-controller@5d400000 {
> > > >         ...                                                // Col1  Col2
> > > >         clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 0     0
> > > >                  <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 1     1
> > > >                  <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>,  // 2     4
> > > >                  <&lsio_bus_clk>,                          // 3     5
> > > >                  <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>;  // 4     6
> > > >         clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_1>,
> > > >                         <IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>,
> > > >                         <IMX_LPCG_CLK_6>;
> > > > };
> > > >
> > > > Col1: index, which exited dts try to get.
> > > 
> > > I cannot understand this sentence, sorry.
> > 
> > This base on downstream dts code.  Downstream code use index in 'Col1' to
> > get clock.
> 
> So s/exited/existing you meant?

Yes, sorry for typo. 

Frank

> 
> Shawn
>