Received-SPF: pass (google.com: domain of linux-kernel+bounces-129009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 3 Apr 2024 09:09:32 +0530
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Paul Barker <paul.barker.ct@bp.renesas.com>
CC: Sergey Shtylyov <s.shtylyov@omp.ru>,
        "David S. Miller"
	<davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Niklas
 =?iso-8859-1?Q?S=F6derlund?= <niklas.soderlund+renesas@ragnatech.se>,
        <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] net: ravb: Always process TX descriptor ring
Message-ID: <20240403033932.GA1652207@maili.marvell.com>
References: <20240402145305.82148-1-paul.barker.ct@bp.renesas.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240402145305.82148-1-paul.barker.ct@bp.renesas.com>

On 2024-04-02 at 20:23:04, Paul Barker (paul.barker.ct@bp.renesas.com) wrote:
> The TX queue should be serviced each time the poll function is called,
> even if the full RX work budget has been consumed. This prevents
> starvation of the TX queue when RX bandwidth usage is high.
>
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
> ---
> Changes from v1:
>   * Use the correct 'Fixes' tag.
>   * Call the new variable 'unmask' and drop the unnecessary initializer,
>     as requested by Sergey.
>
>  drivers/net/ethernet/renesas/ravb_main.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index d1be030c8848..48803050abdb 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1324,12 +1324,12 @@ static int ravb_poll(struct napi_struct *napi, int budget)
>  	int q = napi - priv->napi;
>  	int mask = BIT(q);
>  	int quota = budget;
> +	bool unmask;
>
>  	/* Processing RX Descriptor Ring */
>  	/* Clear RX interrupt */
>  	ravb_write(ndev, ~(mask | RIS0_RESERVED), RIS0);
> -	if (ravb_rx(ndev, &quota, q))
> -		goto out;
> +	unmask = !ravb_rx(ndev, &quota, q);
>
>  	/* Processing TX Descriptor Ring */
AFAIU, TX is processed without any budget. This wont result in rx work starvation if
TX traffic is more ?

>  	spin_lock_irqsave(&priv->lock, flags);
> @@ -1339,6 +1339,9 @@ static int ravb_poll(struct napi_struct *napi, int budget)
>  	netif_wake_subqueue(ndev, q);
>  	spin_unlock_irqrestore(&priv->lock, flags);
>
> +	if (!unmask)
> +		goto out;
> +
>  	napi_complete(napi);
>
>  	/* Re-enable RX/TX interrupts */
>
> base-commit: ea2a1cfc3b2019bdea6324acd3c03606b60d71ad
> --
> 2.39.2
>