Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2468946lqz; Tue, 2 Apr 2024 20:43:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVYDKcVB3GUzWiRUSixEs7srhDxA13J1mYRuVE/xCtCFKCdU7XdPz9jPNiE8WK/me4LIX6Ev6EHI68o4Nd3Qp2o82i2XeQCeprOYJdaRw== X-Google-Smtp-Source: AGHT+IGVYwElseQQCig5WscJWMsAbI6A4tM7cmAmh7wjbBgyLTVbAcBxzE4BnQ2qu9POBSceMHEo X-Received: by 2002:a2e:3e17:0:b0:2d6:a5cf:367c with SMTP id l23-20020a2e3e17000000b002d6a5cf367cmr7602406lja.38.1712115837805; Tue, 02 Apr 2024 20:43:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712115837; cv=pass; d=google.com; s=arc-20160816; b=FSWexEdqqpkF4sOb9fd6NOZUHicXL2lKFZyy2732dy0zYfld8S0ozh0wDZaTvjisTy 39n2/BkXXUsslCwNAGOPTJYowAx7dLliOVg/kF5kC6hxiKkj7C1CyseRo6X4glH7oTLq qdGp+B1p/oTy/fRHBdQlJlvI+DuD8RVn/NJjtV1ssCB+9L9YhNcw02V4L2NSu61yk3Nx 01lW3ckNsnbyHtnCPQtN3Ibwqw19IaAm0IyMKRBSJ+44361BVSYNhezl/STpZOBLA0Yj yOwTTgGkhTWy082lbstTq6LzG/xa2zCpB00aPwRdkTxBSxUqoNRHqAszkH8+ST6s5uzd ep6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=/e7KOLhI4rU5iMg9J02tWnGqEOVAuwzm2XFqQIPvHFU=; fh=/lR0hEwZmfEI4Z6xe1Yq0940k88PdHXiOBF4OYo5r/c=; b=wbAbDmqIDN3FqVgDLHYz5ZNkMXMDzFAzV7VvBIGbeTPMvFOujFkuSNoomTL7yNjaSq reqf61tMKpwKXcy9eU6uRzZZmQ52F/5GroHCfH1uum4e19jotYfJgubWwXtf8OydcVC9 o+b3fFkM/PlQeyUW5rakv1RlqmEiNbngokCoM1j2xEA8vGJjXxA4ri8NsCztk+fL6LQE V8EKJLfxSdsuntA2VZpzARjVA5m/tUCIH8wtozn/ArET0CkbElcB50pjRIFdzbYTJx7F wZPDmelFNgvxNmJ42oTBGzSlmdz87P08nh5Qevq4AVGEGWxE5EXtVEK+xvzrOn0Thiki MbuA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=iscas.ac.cn); spf=pass (google.com: domain of linux-kernel+bounces-129011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129011-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id n2-20020a056402434200b0056bf3214558si6314293edc.664.2024.04.02.20.43.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 20:43:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=iscas.ac.cn); spf=pass (google.com: domain of linux-kernel+bounces-129011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129011-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7E96A1F23100 for ; Wed, 3 Apr 2024 03:43:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A711F3FB09; Wed, 3 Apr 2024 03:43:48 +0000 (UTC) Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E01D544C87; Wed, 3 Apr 2024 03:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712115828; cv=none; b=p3Fo07ZnyBkabxYeuVohnZD8SI0REMz+5omgB/3mKNZ1TJib2iHNc/3W3QJKOvLCA5lruwDPuxnrGQkpkLg/tAoV2ehjuLyvZ+0L6PHhrmgw5DZoT82PFL/5eTYh/bYmMVAHr8q3vyWO7BKUOFU/ruASkboHtcqB6v8GtMQbiYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712115828; c=relaxed/simple; bh=cCZHvqKkhlOhXtkzMr3sHyNUhpsIPdpG23hP2ekDxno=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=F40tHsOy6o43/UpYhPKLM8O6PjQY87sCysoJLaPdnaXqVy8O+eO0fSRORLAPduHtHAjOVFT3pPiOWw/o0ju/nbrgT3ch2vWRwBzXc415QRCbFQARGvgyiK6JTGeaee5DQgX6S0R3n9fHGqQ8gApFy0VCux5uvnIGYausvBInzq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-05 (Coremail) with SMTP id zQCowAC3RBJr0Axm87geAQ--.6190S2; Wed, 03 Apr 2024 11:43:40 +0800 (CST) From: Chen Ni To: linus.walleij@linaro.org, dlemoal@kernel.org, cassel@kernel.org Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] ata: sata_gemini: Add check for clk_enable Date: Wed, 3 Apr 2024 03:43:14 +0000 Message-Id: <20240403034314.3623830-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowAC3RBJr0Axm87geAQ--.6190S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr47tF1xGF13Gw4UArWrXwb_yoW3Grc_Ca y7XwnavryYgr4UK3W7Wry5ZFy0kw4vvrn7ua4IgFZxt3yUJr4kXrWjvwn8Aw1qgr18Wr9I yF4DJ3sYkryfujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbz8FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V AvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU5WlkUUUUU X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ As the potential failure of the clk_enable(), it should be better to check it and return error if fails. Signed-off-by: Chen Ni --- drivers/ata/sata_gemini.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c index 400b22ee99c3..4c270999ba3c 100644 --- a/drivers/ata/sata_gemini.c +++ b/drivers/ata/sata_gemini.c @@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge) pclk = sg->sata0_pclk; else pclk = sg->sata1_pclk; - clk_enable(pclk); + ret = clk_enable(pclk); + if (ret) + return ret; + msleep(10); /* Do not keep clocking a bridge that is not online */ -- 2.25.1