Received-SPF: pass (google.com: domain of linux-kernel+bounces-129021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <679e665c-73cf-4dfb-ad86-efc799b3f8e3@kernel.org>
Date: Wed, 3 Apr 2024 12:56:17 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ata: sata_gemini: Add check for clk_enable
To: Chen Ni <nichen@iscas.ac.cn>, linus.walleij@linaro.org, cassel@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240403034314.3623830-1-nichen@iscas.ac.cn>
Content-Language: en-US
From: Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <20240403034314.3623830-1-nichen@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/3/24 12:43, Chen Ni wrote:
> As the potential failure of the clk_enable(), it should be better to
> check it and return error if fails.

Simplify please:

The call to clk_enable() in gemini_sata_start_bridge() can fail. Add a check to
detect such failure.

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/ata/sata_gemini.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
> index 400b22ee99c3..4c270999ba3c 100644
> --- a/drivers/ata/sata_gemini.c
> +++ b/drivers/ata/sata_gemini.c
> @@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge)
>  		pclk = sg->sata0_pclk;
>  	else
>  		pclk = sg->sata1_pclk;
> -	clk_enable(pclk);
> +	ret = clk_enable(pclk);
> +	if (ret)
> +		return ret;
> +
>  	msleep(10);
>  
>  	/* Do not keep clocking a bridge that is not online */

-- 
Damien Le Moal
Western Digital Research