Received-SPF: pass (google.com: domain of linux-kernel+bounces-129027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <29030dd5-ccd8-48cf-a25a-e98966bf57bb@amd.com>
Date: Wed, 3 Apr 2024 09:45:43 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/5] x86/sev: Fix SNP host late disable
To: Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>,
 Ashish Kalra <ashish.kalra@amd.com>, Joerg Roedel <joro@8bytes.org>,
 Michael Roth <michael.roth@amd.com>, Tom Lendacky <thomas.lendacky@amd.com>
References: <20240327154317.29909-1-bp@alien8.de>
Content-Language: en-US
From: "Aithal, Srikanth" <sraithal@amd.com>
In-Reply-To: <20240327154317.29909-1-bp@alien8.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Yy9qMld0MVF0SU1Fd09WTkllZ2sxTHNOcHdtM3Z5dFV3YnV2WC9aYU4vWkgr?=
 =?utf-8?B?b3VSQ2E0S1FhNVM0NVRrZUtDNzRXaUpwTkRKdDRWdjhVQW9PQW16TFNiSVkx?=
 =?utf-8?B?NWg0ZWJrVGVFR3VmcFFMNVdKK1JXZnhUcEZQQkRTTjZPY0JtQ1hWTUQ3Yjc4?=
 =?utf-8?B?MjRIVmx2eGpRTFBqNmpxMHlScnlVSG9RYVp5UThtMG00QXd6TkpXN3VYc0J4?=
 =?utf-8?B?TjNRNGluZ0Iya0FCbkdyKzBCOG5TbnduYml6V2VsT3JZbFdZRUtGMHlFUXF3?=
 =?utf-8?B?eE45bkUxOEFFbGRQVjNNakZzWTUzdXBJWkpxTjl6Z3BZK1Q3R0NBVGtoeERo?=
 =?utf-8?B?clBOdEJSSHgzOEhWbnNrOC9WMjM1QXVhUDJjVnJMTDhxK0k5cng0dWJIMFBt?=
 =?utf-8?B?dUhtbkVrY0liSUFYM1E0N3pTYjlEOUwzbDRIZFdINFNkREVKVlFhbkF6Vkcy?=
 =?utf-8?B?WSs2ZXk2a3h0RmRKSmFZaWo1cTNqck1GYXpoTVpIcVFoRWxUQjQ4NWF6bnB3?=
 =?utf-8?B?NW1JbXpHUUh1UTdPbVhYV1VhVjhuT09DVlM5Mk9KdFFwWWpqMHZkOWZkcjE4?=
 =?utf-8?B?Q1FmVVdwZllDcFlPZzRQY1RKejNpSlRVc0YvV0lqN2puTWZYUlJUYXhKL0Fi?=
 =?utf-8?B?MkxBZVFHbHlkNEFiT0ZvVHMyOXB2cm5RckcwSWIyR0FoQ09ZcTgwTWZUL2g5?=
 =?utf-8?B?aGJMTHZpS21LdVorZ3BNMDJmRjBTMDJUYWc5cWUrZjZ1c0FMUGVDcWxzcXZR?=
 =?utf-8?B?Ni9zR2FnQThZaWtNY284cFFidFpTdWpnMnErTmlWclhKTkxwblIzcXhlR0lJ?=
 =?utf-8?B?bkFDMmVsMDhlMDJVREZTSWtrdzNNMGtyUkJYSEtBb3M5VTJKQmJzWFg1S0V3?=
 =?utf-8?B?TW4xT0llcWtMMUVaTElObnBYbHNYSjRTRjFPNXdmNDEycERZSGpBQlA2R1lJ?=
 =?utf-8?B?cG40THVrSWVwUUpGVk41UHArVTVmS3AzVm04Lzd0ekFQQ010SjVIc0x0TXhi?=
 =?utf-8?B?Z1ZPV25CaTc4UWMwTGZyc1VLekk3ODZybWZXR2FHZFo3YkRFQi9haWxlVGVX?=
 =?utf-8?B?NnZUT3N1cmtpY2hXbUxRQkMzaStEaDZEQW5MNk83a1J6TmVLM09CWUZwNWYv?=
 =?utf-8?B?d0lhQXlkK2lDU2tBTVNUODhHYmlPdFJ6Vkx4RXZYbVVNUG5CdkRLQUVVMHJP?=
 =?utf-8?B?KzFhTnRVSGhLWldGbFozQjJScmtWSjMzWXVCM09ObEQ0ei9qV3kybTgwc3l5?=
 =?utf-8?B?ZGdrNmFhcVJVMERsQXJFbjFObnIrVmhMTzdnTkJGSnkybU5kRUgyb29YRWxN?=
 =?utf-8?B?WXVmbzE1ZjlzcmJobVA5cDBXclljV0M2cFBDbWFqbkxudjVKYzhqYmRabmds?=
 =?utf-8?B?bVRyR2R4cnhoMFNrL1BHOXNKRkF3c0dhVmNUWTRZRmFiZkZBb2FPQ3ZmZmxQ?=
 =?utf-8?B?VTV0YUFEcmM3SzRhcllXZXdTZTdsUlZMb2dLSmlKQXBPbDlVelRNck5IUjB5?=
 =?utf-8?B?blNISTFpdmh3V2F6TkFBS0h1YXJPc3psL3FPQ3JqdGRkMCtDbGs2ZlBLR1pa?=
 =?utf-8?B?K1FMZFowUHpKMFNTYmpRYmxoZFJkMm41Sk1LQXRsT0ZSeEZRT1licmo4a0hw?=
 =?utf-8?B?Y1V4SWZHZG5oRFZVSXd4V0dZbk5nT21hMjUxZzFlVnJwMzB0aS9PQlBCRUN5?=
 =?utf-8?B?Z2FyaE9YaFU4bVRHcXhrZ2pvZUpubHAvNXRwL1ZSUG9YZ0dyN2tuZ0wyVGRL?=
 =?utf-8?B?eFVtZzNveU9oNDhzdGNjNE9jYm4vdGd0UWlDa1d4VkhGdlJFMmZ1anlHMU1B?=
 =?utf-8?B?alVDa0czRk9jeEs5cUF3ZFpVc2JYS09wTFZ2R0c4bUxvbU1JaldnN1hiUXRP?=
 =?utf-8?B?WFZQb1lNN1VxclpLaGhUYXZ5NzNMa2ZHdGNTVllMend5VWJFTTJobnJaeUo5?=
 =?utf-8?B?c01uWEc1WGJmWG9ZK2VLeVpUbjlEdnY5L2tUU2FsS1pHWjFSQytXQW4xYTJM?=
 =?utf-8?B?WnFHcHhoZ1Fvdk1EVzJPMGdyTDdnOVpWMUoxckhkbkNhcmNwVHRaVC83QnRG?=
 =?utf-8?B?Y05KUUF3ZkFTdE5PMk1XaGlXeUFXTFRQWVBGemd6VXNOSkkvaWlZOGg1WkVy?=
 =?utf-8?Q?UniW3/1T7xTrbANRSsC2iJ23P?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20a9e25f-7138-483a-520f-08dc5394bfba
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6460.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 04:15:52.0071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EXV0cYDyKMMNReL3eKGyEniDwAW6vna3mNQRahE1bk623OpiZM00IPSuG758eaXMxnYR47l+iuwSQp6OrH4iKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8926

On 3/27/2024 9:13 PM, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> Hi,
> 
> the intention to track SNP host status with the CPU feature bit
> X86_FEATURE_SEV_SNP was all fine and dandy but that can't work if stuff
> needs to be disabled late, after alternatives patching - see patch 5.
> 
> Therefore, convert the SNP status tracking to a cc_platform*() bit.
> 
> The first two are long overdue cleanups.
> 
> If no objections, 3-5 should go in now so that 6.9 releases fixed.
> 
> Thx.
> 
> Borislav Petkov (AMD) (5):
>    x86/alternatives: Remove a superfluous newline in _static_cpu_has()
>    x86/alternatives: Catch late X86_FEATURE modifiers
>    x86/kvm/Kconfig: Have KVM_AMD_SEV select ARCH_HAS_CC_PLATFORM
>    x86/cc: Add cc_platform_set/_clear() helpers
>    x86/CPU/AMD: Track SNP host status with cc_platform_*()
> 
>   arch/x86/coco/core.c               | 52 ++++++++++++++++++++++++++++++
>   arch/x86/include/asm/cpufeature.h  | 11 ++++---
>   arch/x86/include/asm/sev.h         |  4 +--
>   arch/x86/kernel/cpu/amd.c          | 38 +++++++++++++---------
>   arch/x86/kernel/cpu/cpuid-deps.c   |  3 ++
>   arch/x86/kernel/cpu/mtrr/generic.c |  2 +-
>   arch/x86/kernel/sev.c              | 10 ------
>   arch/x86/kvm/Kconfig               |  1 +
>   arch/x86/kvm/svm/sev.c             |  2 +-
>   arch/x86/virt/svm/sev.c            | 26 ++++++++++-----
>   drivers/crypto/ccp/sev-dev.c       |  2 +-
>   drivers/iommu/amd/init.c           |  4 ++-
>   include/linux/cc_platform.h        | 12 +++++++
>   13 files changed, 124 insertions(+), 43 deletions(-)
> 
Tested this patch. I could boot with snp enabled and iommu=pt mode,kexec 
as well works fine. Thank you.

Tested-by: Srikanth Aithal <sraithal@amd.com>