Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2489185lqz; Tue, 2 Apr 2024 21:53:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVgMVE9/TaCyGqUmdPrPGhQWQexR8t8QwVFVbtL7+BrC5rKDPgFUZQd/25DxEaY8Hcps0H+rQlBsOqET+gSCAu8uIwgJPdTn5r6Jy9T2g== X-Google-Smtp-Source: AGHT+IF8yjbQv/Qkwy6KPz4Xz2XeKIjxIHssuLkfF0qd1TtM3bzpebPN4zeQcmJT1+UsBWbmf9v4 X-Received: by 2002:a2e:b5c3:0:b0:2d6:b424:a634 with SMTP id g3-20020a2eb5c3000000b002d6b424a634mr8060754ljn.15.1712119980089; Tue, 02 Apr 2024 21:53:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712119980; cv=pass; d=google.com; s=arc-20160816; b=ximTSLomyHFhTuT024J4jKpLqeHT16iPuAZ+Oi4MyOaRZbNwbAuaXbBEx42ian6n3K WFut4cWrP7UzbsUFGIno7o9dcIdMKU72s0Dtd/Eij5ZQJHpygmrj5uPp2oG/ahAO9nbK Uwt9RspDA7WyclhOEEOMFozMSeuGx5Ou30KhlWOKyfcuGXZQ+6NpbzgArB+3+lLlzPZL vbty3Jj5ThCxXyftSeoZfDwx/kaiUqpvD7V/GYn6CS3n1GmJQ/ol5np5ccuik5Sgnnwn k8hW9OiwfzExi6fAYGx1X1uQnhNUtyNDIRxsc4LJ/VdhO0QGEK90yHCvI5/FceqK7lVf fohw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=8rOeL1PsvZ1IYoFoszJhXM1+I1tMuebLfF7WLmHdP8s=; fh=V93/Ne9A4U0bVfPGBHArp/0cbDzOjzjYZaLcEw/YN/M=; b=09Fm+sI1x7HyCBP6PyJtJx2vFv+Ct3D6xEIVeuMgd/BsjS43JJlHLhOnE1pZu7Aihz qT77HK0+GDB1llYM6gBw2O+WEo6xQs6j3ia37x48xlZ/QJQ3/F6QUC95HtBs2hT1th+a oIQts6cJHV45F/nYkvg1Mf+4Rs+SAyEfn7rr+AH9DR+Vr6LyvijVsgWHanaHo5RS5jjo D7maWij7couTxnOoLMHGP67JXw6cYiim0DDHN2bUFPb4qAP07LcVm/t0ArmufVnS5eM1 1I0u/o+Oa/vcqa11w+9OGoeo1p/SImLq6x2N+KObI2bTwRErdQc/nu1TcOSR0bOhPxlK Burw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=a2hi31bG; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-129042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y21-20020a056402359500b00568b925cb40si6501296edc.389.2024.04.02.21.52.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 21:53:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=a2hi31bG; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-129042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C85C01F22397 for ; Wed, 3 Apr 2024 04:52:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B449245977; Wed, 3 Apr 2024 04:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="a2hi31bG" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1591B1E880; Wed, 3 Apr 2024 04:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712119971; cv=none; b=kA/pb6qCUHKTviBiVP072vwzkntLJ6aMr7uVcdf9qdwHp1217AErV1CcEZnbMcuorZaFdkL7XUMp6oDq0o7gmBS9AZ1n+8CHJcAQoapgcVWv3mklmvFgd4OZNs7q+CX9SGAOV5CxJsneO/EumOErhVewibylYqLKSE8bYGI6Lmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712119971; c=relaxed/simple; bh=3rsE3q6dytT9So/UVsWaVTkje+2sES8TOIqAYIknR6U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=c7qxOkG1rA7KfPyGvcJ7iMc/zaVeDvhplhmSrMflh10h+QTgBFFhu2el7CBQgJP50WdUEh/knEyRjkq/fDP+bhvorcJy0p6TXA2eqSMZBUveC0/0/HoVT2RHTcFl7UKinvOu/83tMwjiVhavgj38ozm520oHi7VEXIvK9Jf+aQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=a2hi31bG; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712119970; x=1743655970; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3rsE3q6dytT9So/UVsWaVTkje+2sES8TOIqAYIknR6U=; b=a2hi31bGfDKt8z1rGcZQc1Wph0YMazrsWSNw6NWzI9imrJieu+LJ2pKE UJ1rfpF7kWRndqCjob7FSKwnhpCasXGf6ozJQreB1F0dURogtgTJEOdk5 RNtmCqA/3dkxB3+yzL7vNeh1jdbA8V/r3Aw5pRhsTq4ARaCMOAhSTtFPx JhH0cXvXac+Roj9mSRW+Gmt/qWVqHj2aHOcvHup6zzL7sBN2r2/XobuX5 pPaJqvWMNV2l2xAoheXKZyeXbBDZWN1PmALmOM3mMBZOY0drOmBOHeT40 ed9Yt3Bs1GhkKgmtngYOg8NgHTCOOwwhdOLAcRTbtHK5A3bP7T8JoRAqm A==; X-CSE-ConnectionGUID: QwUcc8FQR5Cg80zIVSRD1A== X-CSE-MsgGUID: /jA2HieqQYCAzK7uH4V2Rw== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="24786548" X-IronPort-AV: E=Sophos;i="6.07,176,1708416000"; d="scan'208";a="24786548" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 21:52:49 -0700 X-CSE-ConnectionGUID: ez+kKMdbQsWV7JEQsN8MXw== X-CSE-MsgGUID: KM0nSPTaQhyLnesGbsN+tQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,176,1708416000"; d="scan'208";a="18352670" Received: from wentongw-optiplex-8070.sh.intel.com ([10.239.154.12]) by fmviesa006.fm.intel.com with ESMTP; 02 Apr 2024 21:52:47 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, hao.yao@intel.com, stable@vger.kernel.org Subject: [PATCH v2 1/2] Revert "mei: vsc: Call wake_up() in the threaded IRQ handler" Date: Wed, 3 Apr 2024 13:13:40 +0800 Message-Id: <20240403051341.3534650-1-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sakari Ailus This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984. It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in an interrupt handler as the interrupt handler itself would be called in a process context if PREEMPT_RT is enabled. So revert the patch. Cc: stable@vger.kernel.org # for 6.8 Signed-off-by: Sakari Ailus --- drivers/misc/mei/vsc-tp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index ecfb70cd057c..968a92a7425d 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, void *data) atomic_inc(&tp->assert_cnt); + wake_up(&tp->xfer_wait); + return IRQ_WAKE_THREAD; } @@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void *data) { struct vsc_tp *tp = data; - wake_up(&tp->xfer_wait); - if (tp->event_notify) tp->event_notify(tp->event_notify_context); -- 2.34.1