Received-SPF: pass (google.com: domain of linux-kernel+bounces-129099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 3 Apr 2024 14:51:12 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 111/130] KVM: TDX: Implement callbacks for MSR
 operations for TDX
Message-ID: <Zgz8YFgD1CysKaDl@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <62f8890cb90e49a3e0b0d5946318c0267b80c540.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <62f8890cb90e49a3e0b0d5946318c0267b80c540.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NYIQh19u1X5jWqQHXGLIU1+SK/dP2x2QV4rEz0ZrzGOf4rUgXzx/L7io2xAh?=
 =?us-ascii?Q?hs3kKOO5nfSJ8SW2KIaKQzGnPNz26r26dCAbTdJLJmjpnguCGvJ/bvFHHXaP?=
 =?us-ascii?Q?SX0QC0de0t56Zz0Fdu65cRlQdUF+RgfOtaYThSuKCY7utWYYmjo8Yxa624dA?=
 =?us-ascii?Q?usAFv55jtsZu4J7r2Wd9jLZeXzJAwVssTonGZ/3FukCniP2H1WgQOO0gYwou?=
 =?us-ascii?Q?ADdMa7kWvkEzCmAJBiJbkf9P1l9cuLmAq0hkKbu7XhPlqE+UsQsEbKLZZQ9Y?=
 =?us-ascii?Q?owXNqnKjCBo1kMEfDMpVRl8FllffA7SOnIMyoa+Jjs8vO2Sfwt8Vj+8m5f2h?=
 =?us-ascii?Q?UpX2DiZZrFliLIbQHLlWKbza13FJe8WfJ5npiMPgOzi61zf8T0LotYt5WdPE?=
 =?us-ascii?Q?MoXWxORC39HZqPg8miD3ggAlW5VhzvY0gPIBqzGFmWxE6UmRsvINS8Cnv6mU?=
 =?us-ascii?Q?YfXtpvzUwnsJ6oj88o2puokE+3WbV9/l4xSqIgcqijTz00pB3oF8Rz56og1/?=
 =?us-ascii?Q?Jor0fLOvtOsfoMAjg+fxFWBoICFWEH5gNRtD+fdjVCFBpagmuK6RsAvhL9Qs?=
 =?us-ascii?Q?+7pLq3GnuXsw1DXEpdCXAs32JgtJ59E7NmTX3MPliw4hDHP/j4KpKYZ2eNNx?=
 =?us-ascii?Q?buo2U1tQAUfVg2B8NRLOV6lyqjT95R3E8uxvgWSPcPG7cUWsDB3TK3/brNDB?=
 =?us-ascii?Q?VpTwapwFQ/n1ysPMBacdA1BWSrIaSn8oPzQtjP/O4zZLfi4pLaNCCUrQ8YeG?=
 =?us-ascii?Q?iFy7KY1YU328zG9Y/xQe5M1MScI//NjASu4Bo8lGnILpKIjMGq4DOc4A3uuT?=
 =?us-ascii?Q?BRDNaaX2JSJirdCJI5kcJAMMDfN76M5H3Rd53OXV549kF+BWVocudQ8jFWji?=
 =?us-ascii?Q?ZamBN3RX0hzl3brj66viLnolxMrJ57s5mEmDpAOhmUBrX6BVj/FXPPct85An?=
 =?us-ascii?Q?b6ONIhdfdnHdMaSMcuEPB3XQInIWCJ8gCoDFTQSBb1IVrs478BJAYZsKawm1?=
 =?us-ascii?Q?x1Ls9p8YfGz9TgEy1XVz6hAaGVhNn1AiOFPgRieIBHFt8ab+l2tfIZG5Ctq3?=
 =?us-ascii?Q?u1jrPzHaN8aINRU5gWc+ox6l79xqKBzlw5g69BoizQaE54yEysHXYRfcbY6e?=
 =?us-ascii?Q?9FSymqvmquADVHJrBAwpNizhxqWcSBqNut0Ny56x6Uq3HAMUKrqDQ3grxds5?=
 =?us-ascii?Q?XesCJXKJ7aaLvYGOMjaL7L0cLPPQKosOE7DWC+Jyc+e2+ruxw9ju/rZpDoJj?=
 =?us-ascii?Q?QJ5zHFYm65FLROmlGmATAj7f1TvMIiROYm1KIuToB08JpXu90DNxrNrbgpNH?=
 =?us-ascii?Q?PlUf/fqFUAgADlnZTNgCmm+mCJhyAmse9A+wEd9SEgXzegiT89A96kjaLPN+?=
 =?us-ascii?Q?AjByMFoh/l91UCWQoGRGHgkH1lIUHOSG2L1NwM/j4JLJTjguXORkA38/TWSq?=
 =?us-ascii?Q?QaN1XOMuRW2Oa18UoOl/fMOD1gHxTEl+9uu0NAVtRTLVuE3KP0b/VsBW+8MX?=
 =?us-ascii?Q?mNFyyv+j1sUmPgcVcOQr4elSx/tYsYvkYoRvyJBZdXlmqrP90eMHvCdOz80S?=
 =?us-ascii?Q?MVe4H0vEfqhDszVFBQ60SKbts0WEBkyhekhUs9uH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bdaa8675-1821-43db-3e61-08dc53aa78d6
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 06:51:21.8123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o2bhvRwLYvWDT5c8rEtqZ5go33pJVRu9bGxIZHNUduLuiKT+fUeNU4Zm4qYPqQ5P3jyookDITYj3S3jEI8t7Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4722
X-OriginatorOrg: intel.com

On Mon, Feb 26, 2024 at 12:26:53AM -0800, isaku.yamahata@intel.com wrote:
>+bool tdx_has_emulated_msr(u32 index, bool write)
>+{
>+	switch (index) {
>+	case MSR_IA32_UCODE_REV:
>+	case MSR_IA32_ARCH_CAPABILITIES:
>+	case MSR_IA32_POWER_CTL:
>+	case MSR_IA32_CR_PAT:
>+	case MSR_IA32_TSC_DEADLINE:
>+	case MSR_IA32_MISC_ENABLE:
>+	case MSR_PLATFORM_INFO:
>+	case MSR_MISC_FEATURES_ENABLES:
>+	case MSR_IA32_MCG_CAP:
>+	case MSR_IA32_MCG_STATUS:
>+	case MSR_IA32_MCG_CTL:
>+	case MSR_IA32_MCG_EXT_CTL:
>+	case MSR_IA32_MC0_CTL ... MSR_IA32_MCx_CTL(KVM_MAX_MCE_BANKS) - 1:
>+	case MSR_IA32_MC0_CTL2 ... MSR_IA32_MCx_CTL2(KVM_MAX_MCE_BANKS) - 1:
>+		/* MSR_IA32_MCx_{CTL, STATUS, ADDR, MISC, CTL2} */
>+		return true;
>+	case APIC_BASE_MSR ... APIC_BASE_MSR + 0xff:
>+		/*
>+		 * x2APIC registers that are virtualized by the CPU can't be
>+		 * emulated, KVM doesn't have access to the virtual APIC page.
>+		 */
>+		switch (index) {
>+		case X2APIC_MSR(APIC_TASKPRI):
>+		case X2APIC_MSR(APIC_PROCPRI):
>+		case X2APIC_MSR(APIC_EOI):
>+		case X2APIC_MSR(APIC_ISR) ... X2APIC_MSR(APIC_ISR + APIC_ISR_NR):
>+		case X2APIC_MSR(APIC_TMR) ... X2APIC_MSR(APIC_TMR + APIC_ISR_NR):
>+		case X2APIC_MSR(APIC_IRR) ... X2APIC_MSR(APIC_IRR + APIC_ISR_NR):
>+			return false;
>+		default:
>+			return true;
>+		}
>+	case MSR_IA32_APICBASE:
>+	case MSR_EFER:
>+		return !write;
>+	case 0x4b564d00 ... 0x4b564dff:
>+		/* KVM custom MSRs */
>+		return tdx_is_emulated_kvm_msr(index, write);
>+	default:
>+		return false;
>+	}

The only call site with a non-Null KVM parameter is:

	r = static_call(kvm_x86_has_emulated_msr)(kvm, MSR_IA32_SMBASE);

Only MSR_IA32_SMBASE needs to be handled. So, this function is much more
complicated than it should be.