Received-SPF: pass (google.com: domain of linux-kernel+bounces-129147-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 3 Apr 2024 09:16:02 +0200
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Steven Price <steven.price@arm.com>, Liviu Dudau <liviu.dudau@arm.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard
 <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie
 <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Grant Likely
 <grant.likely@linaro.org>, Heiko Stuebner <heiko@sntech.de>,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/panthor: Fix a couple -ENOMEM error codes
Message-ID: <20240403091602.52e887b3@collabora.com>
In-Reply-To: <cf5bbba5-427e-4940-b91e-925f9fa71f8d@moroto.mountain>
References: <cf5bbba5-427e-4940-b91e-925f9fa71f8d@moroto.mountain>
Organization: Collabora
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 2 Apr 2024 12:58:09 +0300
Dan Carpenter <dan.carpenter@linaro.org> wrote:

> These error paths forgot to set the error code to -ENOMEM.
> 
> Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Queued to drm-misc-next.

Thanks,

Boris

> ---
>  drivers/gpu/drm/panthor/panthor_mmu.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index fdd35249169f..a26b40aab261 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -1264,8 +1264,10 @@ static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx,
>  	op_ctx->rsvd_page_tables.pages = kcalloc(pt_count,
>  						 sizeof(*op_ctx->rsvd_page_tables.pages),
>  						 GFP_KERNEL);
> -	if (!op_ctx->rsvd_page_tables.pages)
> +	if (!op_ctx->rsvd_page_tables.pages) {
> +		ret = -ENOMEM;
>  		goto err_cleanup;
> +	}
>  
>  	ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count,
>  				    op_ctx->rsvd_page_tables.pages);
> @@ -1318,8 +1320,10 @@ static int panthor_vm_prepare_unmap_op_ctx(struct panthor_vm_op_ctx *op_ctx,
>  		op_ctx->rsvd_page_tables.pages = kcalloc(pt_count,
>  							 sizeof(*op_ctx->rsvd_page_tables.pages),
>  							 GFP_KERNEL);
> -		if (!op_ctx->rsvd_page_tables.pages)
> +		if (!op_ctx->rsvd_page_tables.pages) {
> +			ret = -ENOMEM;
>  			goto err_cleanup;
> +		}
>  
>  		ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count,
>  					    op_ctx->rsvd_page_tables.pages);