Received-SPF: pass (google.com: domain of linux-kernel+bounces-129164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a35a0ae3-f976-4a74-aba0-2b16ecf2a61b@oracle.com>
Date: Wed, 3 Apr 2024 12:53:15 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] drm/panthor: Fix couple of NULL vs IS_ERR() bugs
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Steven Price <steven.price@arm.com>, Liviu Dudau <liviu.dudau@arm.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Heiko Stuebner <heiko@sntech.de>,
        Grant Likely <grant.likely@linaro.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
        error27@gmail.com
References: <20240402141412.1707949-1-harshit.m.mogalapalli@oracle.com>
 <20240403091729.3100a6a1@collabora.com>
Content-Language: en-US
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <20240403091729.3100a6a1@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?em9rUU15MHBZSlhhSzhWZ2hNUjdEell2Sy9GMW0xdk5TQ2FlQnkyNEdPUDhl?=
 =?utf-8?B?VjVZbjFRQ0I1U0J2dElIUW9VTzg2RGhacjVkdnovVlNhOUVIUDdGNUJsb3ZD?=
 =?utf-8?B?RTA0VU05WC9nN003QmFZcnBEQ2VxdHdTTmhIMEhOTDM4NDJnSUwwZk1vSUpy?=
 =?utf-8?B?OXg3bjVBOGFkdG0rTk4xdzZ4Z2FWS3k0a3o4bmVHYW9BdjZqbUUzTER5Yy9n?=
 =?utf-8?B?cHVzMDRjdEo4TTAzNWo2c0svNTV5MmxKZHpwNW5MaURQZ3ZVZXNwS1hiZmRm?=
 =?utf-8?B?YldxTVdtQzBybVVRZHRDSFZRdEc3c0ZRZXZrRmlHUlVsSzkwS1ZFNDhHcFd6?=
 =?utf-8?B?cVlnTHhqUGNkcEE0cFovREgzN2FWMEVJZEVmUnl0R1NoL0czSGF2TU56Vk50?=
 =?utf-8?B?VjBaMmJOMS9SYnVuQ2laSEJXUFM3dTV4ZzFoYUpDSFd5QVh0ejFlT3FwQ1Yr?=
 =?utf-8?B?ZXlsWGtwWmlDTEhWSUNxU1dUaWcra0dkWHVzWllPVlc0T3FmUTdoMmhwOHRp?=
 =?utf-8?B?S1gzd3dRUXQ1VXQxRHFBNzhkQmZiWmUvNWpqcEV1MHMzN0FxdUtlVExPRTQ3?=
 =?utf-8?B?MlcyUUl3ZVZlVlRUVUdMUGZuQzNyWHVlc0R6VkZjTy9LeGY4ZEtaTnZsVlhs?=
 =?utf-8?B?SSs1QyttQkMzNlZtemFLVlNIMCtLTzgwQ05jZE5JbHVVZEhIdFBvL3NVdXhi?=
 =?utf-8?B?RFZxdEY1R0FHWElFbWY4N2VYK0FCQTkyaXlXQWZPWHdHSnJvUEh2TGFiU0Zv?=
 =?utf-8?B?SjZvNjhwZ3pkb253RTd6TFY0eUE3R3M0amtsZ2N2L1VRS1U0b2MwaDkxZDhu?=
 =?utf-8?B?b29ONWFhV2ttU091RmxjMzIwUjdGaldReHRIc3FEQ25YbWdZTnIvWEZDdUFW?=
 =?utf-8?B?Y25LMzl0b3ppZzVLU3dES3A2M3E0RUZFTnNCTU9oOFUydURCcCtybjJuSWRE?=
 =?utf-8?B?MFYzYUlLcmZVcXI4NW5kMjNUQUFUaFQyVDcyam5mM0dUWmM2RGNLOWtONlhP?=
 =?utf-8?B?M0cxdzN2d2t4MytWWjVCL1BiQzZPakpaMUxlbFV3WWtMaFdzTW9iWW9IdEdC?=
 =?utf-8?B?Nk9ESTd1TE14dytOOWs0OHRjZG1UUDlTemtFWVZKZjdIaDhLdnpqOUNpOXZE?=
 =?utf-8?B?azR2WTNtTnhIS255ZUNnMWVDeC82V1I2Z0NCVS9XWU5jUGF3YnZzWTBObU1L?=
 =?utf-8?B?L2JzcGhEazlwVm5jTEtXaTVBQzluelQ5N3U0WG9NY2ZMbEdaem9MSkIzRHVO?=
 =?utf-8?B?RTN4bUlNa3JjQWxxS1ZJMkFyTHJjQ1IrQzNudXNvOXE4TlR0K2ZiQTYyeStz?=
 =?utf-8?B?QmdZY3pEVlNGa2JyejVQQnFIWWJhV0RoVlMzWFI2c0JCZ2xsRFF1bVBuNVBy?=
 =?utf-8?B?TUNtRmlyTFgxUzJsYUtBYnJOeFYzK2NQQ2I5WVdBeWxOakJibSs3aG94dm5H?=
 =?utf-8?B?dkRTOVo4NHlVMk9KMUJZTDBVdEpTbXFwQnRJTDB5TjE5aHVxNlBZSm0vWldv?=
 =?utf-8?B?Z2xFYUJoVkZSck8vbGlsUlRPWng5NkRqMWpBK044d205QnlBak0xTUZ1UG90?=
 =?utf-8?B?U2NxUm1vbm1wK2RVekdiRW1iclp1L1M1aVZKWDJSdzZyVHpSRVlPWEFjQzJq?=
 =?utf-8?B?aWdrdTgrMEVaczludFY0UUhBWnpXVjdwU3dHcERsTU83Y1p2dmdpcFZVUmNM?=
 =?utf-8?B?V0RYWUVSUHd3aXdWZjhndHFHU1hyQzIvZ2xjWWdZbEl0MW1LakRrdFdFanVv?=
 =?utf-8?B?SlJqVHByMS81elhNWjZsVUluUVJFQW1iTHZPTHdob2hhQWV6VHNtWGtVOGRJ?=
 =?utf-8?B?NWJQTFlkUUI4TDF2WXdNSTlsMys2RG80b044dUtsVTZRUHlRVGMvVWtDNjM1?=
 =?utf-8?B?RTlhUldvejR4bTl4YWk4YlE2SExER1FYUnl3dXpOOHkwZ0NueTB5VkFjMG14?=
 =?utf-8?B?K2pKdXJQVnN3cVp3MnVaYi9Rc0YrVEpaOGVyTzNKTUNuS3hHVkN4aTBybkFR?=
 =?utf-8?B?bndaMFl6aitxNWpIZEo5MzhpcjEzZ2p6UDR0KzMxQkxNOUpSUHhjRjVKeTh6?=
 =?utf-8?B?N2RRRjBEcGEvOFQvRmlPM3hUQ0wrY2E4OFhQcFRmZVY1RHpMaXVKTVo0Njlk?=
 =?utf-8?B?dW1aV0ZyMEhhVGc3d0ltRVNJOFJhZ0pSdXl0azc0NE8zVU55WXVuaGl5TTZi?=
 =?utf-8?Q?4N9Q0vpUw1itjj54YB596ls=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	VSrVPCcY6n+Eo0SPjDr0NesSkyzqcJEnEC7ELiOL4FbG9I9Yr5hCTOJVLmtjS6TiqpoPQ+o5L7N96yvNlavzqiJ0sDDjsXbYXDw/1rnabHfhR9cdU1G1aZ/NpoCOQO8eHUUNwlfrD9WPXQt2xe+SOFooM6+OWxR1b+xkP62UZod1CSg2Xgwygis1IhsXV31ViCQcMaHfDE1aWRNGrTFmP4n7R3cAng2xOF515uyxsMyAn6RwbyVvu091f8iBh+IcmngkzDOcMcc0Yb5PMejvXWgAsV/Qpp0AvDOPjsets2IJlzB3hI11oO8W3a5ORgVSs+UB+FpoMRj4FABvH7p3jlKA2jeFPEXEamh3or3U/11fXfShb+30YL0JLovX/PX0rpMKazogBdAq0gPTnRNALx3/pKaLv2FsHaAPAo6l2CnbiwGKbsPsJEO6TJlPUUqjK/a/aZ+srZxK4aPIyaRbLQsqGF0c1nf7XaSAkyKjVeKrCfwyVPZEi7+e8y/HWv28KFkoi9pVxBAj4bxy/S78xb+75WlMA1bRFcxk1dIkxtcDb7foXML9SbruTsumVu9xu/Yp2ULLe3o5TWDtRRHBQNSUGz77jsrIDSGJX3TyNo4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f43b369f-c50c-4b9d-32d9-08dc53aef35d
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 07:23:25.4874
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: APz0ONrzmom0UBUFIchJJxXS6ZlfHTcg6hX1GoC1Ha8spaJWSed9BJBer2JxxJYSe+LALyuU22NMMqknRrdSMTPE2sGtvoMiB0noMF/SCIipRHpkiqV47JZB7u6lfFYe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7502
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-03_06,2024-04-01_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2404030049
X-Proofpoint-GUID: o-U73DXwrpXlldMtXgxXNich36fbgrMs
X-Proofpoint-ORIG-GUID: o-U73DXwrpXlldMtXgxXNich36fbgrMs

Hi Boris,

On 03/04/24 12:47, Boris Brezillon wrote:
> On Tue,  2 Apr 2024 07:14:11 -0700
> Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:
> 
>> Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and
>> NULL(when create is false and if there is no poool attached to the
>> VM)
>> 	- Change the function to return error pointers, when pool is
>> 	  NULL return -ENOENT
>> 	- Also handle the callers to check for IS_ERR() on failure.
>>
>> Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> 
> Queued to drm-misc-next with the following commit message:
> 
> "
> drm/panthor: Don't return NULL from panthor_vm_get_heap_pool()
>      
> The kernel doc says this function returns either a valid pointer
> or an ERR_PTR(), but in practice this function can return NULL if
> create=false. Fix the function to match the doc (return
> ERR_PTR(-ENOENT) instead of NULL) and adjust all call-sites
> accordingly.
> "
> 

Thanks a lot for making the change!

Regards,
Harshit

> Thanks,
> 
> Boris
> 
>> ---
>> This is spotted by smatch and the patch is only compile tested
>>
>> v1->v2: Fix the function panthor_vm_get_heap_pool() to only return error
>> pointers and handle the caller sites [Suggested by Boris Brezillon]
>>          - Also merge these IS_ERR() vs NULL bugs into same patch
>>
>> v2->v3: pull out error checking for devm_drm_dev_alloc() failure.
>> ---
>>   drivers/gpu/drm/panthor/panthor_drv.c   | 4 ++--
>>   drivers/gpu/drm/panthor/panthor_mmu.c   | 2 ++
>>   drivers/gpu/drm/panthor/panthor_sched.c | 2 +-
>>   3 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
>> index 11b3ccd58f85..050b905b0453 100644
>> --- a/drivers/gpu/drm/panthor/panthor_drv.c
>> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
>> @@ -1090,8 +1090,8 @@ static int panthor_ioctl_tiler_heap_destroy(struct drm_device *ddev, void *data,
>>   		return -EINVAL;
>>   
>>   	pool = panthor_vm_get_heap_pool(vm, false);
>> -	if (!pool) {
>> -		ret = -EINVAL;
>> +	if (IS_ERR(pool)) {
>> +		ret = PTR_ERR(pool);
>>   		goto out_put_vm;
>>   	}
>>   
>> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
>> index fdd35249169f..e1285cdb09ff 100644
>> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
>> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
>> @@ -1893,6 +1893,8 @@ struct panthor_heap_pool *panthor_vm_get_heap_pool(struct panthor_vm *vm, bool c
>>   			vm->heaps.pool = panthor_heap_pool_get(pool);
>>   	} else {
>>   		pool = panthor_heap_pool_get(vm->heaps.pool);
>> +		if (!pool)
>> +			pool = ERR_PTR(-ENOENT);
>>   	}
>>   	mutex_unlock(&vm->heaps.lock);
>>   
>> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
>> index 5f7803b6fc48..617df2b980d0 100644
>> --- a/drivers/gpu/drm/panthor/panthor_sched.c
>> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
>> @@ -1343,7 +1343,7 @@ static int group_process_tiler_oom(struct panthor_group *group, u32 cs_id)
>>   	if (unlikely(csg_id < 0))
>>   		return 0;
>>   
>> -	if (!heaps || frag_end > vt_end || vt_end >= vt_start) {
>> +	if (IS_ERR(heaps) || frag_end > vt_end || vt_end >= vt_start) {
>>   		ret = -EINVAL;
>>   	} else {
>>   		/* We do the allocation without holding the scheduler lock to avoid
>