Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2545557lqz; Wed, 3 Apr 2024 00:43:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVxnSjyoIYy2kPIt6aun6Jmlzn0WfJryGl3SExZ0d/AKq8f/x2C5RATYpeg6j+Fef6YdGblxqfc2BD8WPXDxFU7Caw9+Y6p17H/Rh6GQQ== X-Google-Smtp-Source: AGHT+IEzmpB0GkAZbPRojB88SUHnz5ogxMU1fpkCvEyyGRjtLlxg7lQyQraB++GC93QhftmQU59/ X-Received: by 2002:a17:902:ea12:b0:1e2:3e0a:fc61 with SMTP id s18-20020a170902ea1200b001e23e0afc61mr2506630plg.34.1712130236405; Wed, 03 Apr 2024 00:43:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712130236; cv=pass; d=google.com; s=arc-20160816; b=LVqIZ06YiYgwAVBgwXZbZXVffif2r2QtC9Lx7maBkMSypo8wiGQigqBsj+Xmn9BK++ 1XMLOO+zZ9z1DRledU72bgG2SkVDAd0Or+JhxKgcVlSgDA+qUKJ9CkxQT2RMh5cgrkOt dCbMB4Pg13fccGYJkDiEau/elbHDu4c2gBDwlWcvklRcU5fpP1VzfxY4Bdl+qZNvy3Ra WuZ27A3hXjl0Mn/C/DtY9+6lTDOkSQLt57r9Wv6KB4N28f0Iam13cf5lgXZRd8vIceQK 3FyGgsTWB+8wu+rJgMWhtppE3ECOe7Fr+qU4JirUDRk68or9g/HBKJu1d+CTtkM4lhqo gf0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9mfDAy2zVNMZ2A/Na+qj4o9KwFwKiT2xCtG3Hh4taWc=; fh=p1gJBd+2okAfiF/f6rmp3dMDYVUfA0ALGM6dUvKrQac=; b=vXyltQMMKFk3FTIXQigPELj4lOvYl+3sAke+0hHQ4TSmv0z6e1DoIOIMVBiN0OU9sR NOVY6/zBE5X6MnPwZqGEfE8WALjv9ASotyNherx7BiQksouISxp9E89aJJ7wnevxoN4+ qAgJpOBVPbYnQiIY2Anrv5kcy30TUUwOT5uJvHlJumoMy4mWT2MY3U/c9DWVBMy8Nl14 IKqH+e0dW+Y/77FCSyZLxbvSy0/Dlc9YWFxON+yOEh15gYt7boR7lV8cUamoM4JEZWp8 FH4mPFc+UAQcBCpLJTLus/ZI0z+foPS6L9Dq9LmyMGc0EbkBY2QY8lXA8wQTkDYIyqm0 MGQA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZKSs+eoj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-129193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129193-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lv4-20020a1709032a8400b001e2565954casi5679805plb.85.2024.04.03.00.43.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 00:43:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZKSs+eoj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-129193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129193-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B4ECA28BA95 for ; Wed, 3 Apr 2024 07:41:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B9F46CDDB; Wed, 3 Apr 2024 07:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZKSs+eoj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20CE060EEB; Wed, 3 Apr 2024 07:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712130003; cv=none; b=dLLHcB7+LoCsApc1SqISgEDlt3S/OPMo+uMG0seMh6cOk/QTR1dYN3GnwxmQ2K2rvJeUMQ+IWXB/nlo85yHO4b4Xq0jOdknanBjud7AQWimNd6kKBWc6U3B3SInHcoXaw14KYVarbEK1ykSuajjatBjILeb7SMCatEBfYhMMKkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712130003; c=relaxed/simple; bh=ZVuJ6DGjv1sZfHRwIyRI/Qoz7UcZnpUAHZwbGFBWWpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GxPsPhkB4cdQf7KaZrDCVIQdTr9WdwwSQaaoCwH0y1g496b0804K6j5dVDruTMBcL/kuX1RZkBGZyiECnlL0xUnDLwCKGJ4x5CnMb7wmnUKxibTtUXTck2+UacVqWAnqafU2SL8H9ZDR6UlvQ+piFR0iCQposZxjBOeX7gLtYc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZKSs+eoj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AFA3C433C7; Wed, 3 Apr 2024 07:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712130002; bh=ZVuJ6DGjv1sZfHRwIyRI/Qoz7UcZnpUAHZwbGFBWWpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZKSs+eojw30+iv8jtyH8H+tBv0GCsmew07o8sznbIlDdt0Lo/4GXs34wVndt7veLt VQS9bIOt1cSBD5l1oPXWySWz5QDQ0XA6vSWhr/IOPo8XidBMCA8iexXuT3jR1PMTZt Y6R2kIbaboTOleIvQLQ4y0AJ03G83QI4pm6r+0NNe2jVANOpiWMHQgAXCxgomAhF+E xB+NWedHk0pGzZ0tdSLR1eR3mvwL5EzltGTndLJfNF00NcyODihzPF+2Mm7dFYxAhI 9+YT3O+OCwpZL6Kp6N21eBYtP7H1t6RUujC+eHdJJT60Zp9Wrd/4PY+3l3M0YzhSiD ZDYLouwkCXVlg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rrvE2-000000007dw-1iYO; Wed, 03 Apr 2024 09:40:03 +0200 Date: Wed, 3 Apr 2024 09:40:02 +0200 From: Johan Hovold To: Krishna Kurapati PSSNV Cc: Thinh Nguyen , Krzysztof Kozlowski , Rob Herring , Bjorn Andersson , Wesley Cheng , Konrad Dybcio , Greg Kroah-Hartman , Conor Dooley , Felipe Balbi , "devicetree@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "quic_ppratap@quicinc.com" , "quic_jackp@quicinc.com" , Johan Hovold Subject: Re: [PATCH v18 2/9] usb: dwc3: core: Access XHCI address space temporarily to read port info Message-ID: References: <20240326113253.3010447-1-quic_kriskura@quicinc.com> <20240326113253.3010447-3-quic_kriskura@quicinc.com> <20240402233218.5kngtj56qellnrmo@synopsys.com> <39010f95-b08f-4a57-b3af-f34eb1069865@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 03, 2024 at 01:03:21PM +0530, Krishna Kurapati PSSNV wrote: > On 4/3/2024 12:36 PM, Johan Hovold wrote: > > The series has not been merged yet so you can address both issues in a > > v19. Perhaps wait a day or two in case Thinh has further comments. > Also after making the following two changes: > > 1. Rename dwc3_read_port_info(...) to dwc3_get_num_ports(...) > 2. Changing "if (IS_ERR(base))" to "if (!base)" > > Can I still retain your RB tag ? Yes, please do. Johan