Received-SPF: pass (google.com: domain of linux-kernel+bounces-129201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Guanbing Huang <albanhuang@outlook.com>
To: gregkh@linuxfoundation.org,
	andriy.shevchenko@intel.com,
	rafael.j.wysocki@intel.com
Cc: linux-acpi@vger.kernel.org,
	tony@atomide.com,
	john.ogness@linutronix.de,
	yangyicong@hisilicon.com,
	jirislaby@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org,
	lvjianmin@loongson.cn,
	albanhuang@tencent.com,
	tombinfan@tencent.com
Subject: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties()
Date: Wed,  3 Apr 2024 15:41:29 +0800
Message-ID:
 <PSAPR06MB4952D98B1204C8591989DB25C93D2@PSAPR06MB4952.apcprd06.prod.outlook.com>
In-Reply-To: <20240403074130.93811-1-albanhuang@outlook.com>
References: <20240403074130.93811-1-albanhuang@outlook.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: PSAPR06MB4952:EE_|TYZPR06MB7169:EE_
X-MS-Office365-Filtering-Correlation-Id: 7f0317fa-8bf5-4bfc-8e5f-08dc53b18203
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XP37VQkSxDNDGSOueyR+DNbvPh4tIyjaQ5Hoe8D9JwzE4CrqBOpz3xX4EvS34V80JBm1xfxvI8yJfUQVkBNlmQRZCt1CjAt61Hvp+DLWjrRB2Ws/Z5dzSq+qT0bgOFuZKN91pW7k1WfJa3OCv4F/5i3Gypj8QpcJrxF/6QdwLOB/VihnwKk7Vt04vB0N1fGuAhDcl+PY94waOY0IhZJ6a1efePzlsVwRizfezwmKB4wDEfpJynWZhmWjNo52JlyXbA67blXBWRbZXuP0owX4/HiY/2AYHfArydxusA+huG6/fNx61dF6Corvx2T+j9ZGunsSmUiStbvFPDXwF0tZzasRsUW+jY5WsoNybwonZPfr0s15nY2rTbz0cKUgAaY+lNNupLRbbfpH02XbwozKqZ8qaP2h1rSf3nF/4sVtpNsLDC9X/dXbBLBwKI6MFH7kWrAZDcfpq6FD3Prwlc7Fm1Cn+SaK35oPn0BG4vMRhUHwwX6FNFO/Pvh0PRd9LAD5i2E5xY8x6bSshRsGlelZ0DtOMqfEEjpbPcaDRkZf5zgIRsWVUqFiWdpve9bjzDc7
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oCv6nNaNAkDF+zgr44q1J2hm1eyf3sc+xJC+eNzA03PEh7eFDjNeJ0iIRG/S?=
 =?us-ascii?Q?5U82xafrBmeym01gpJQDvw+seA9VOq7VYrQlJvkIRYfdgQ2riVCF2BCQAaR/?=
 =?us-ascii?Q?7+DupgJ8JSzHg6Ol6V4hY4yHdfiakOxAP4ZkJfk+vq4Ojg5qPjGeJmaiCNo1?=
 =?us-ascii?Q?dKx2i3q0+6DjiRmQQCtrSfrX+76S3+AQk4ymrq7vbmJ/5r0Bm0Y4HuOUNBVi?=
 =?us-ascii?Q?SbMf6BmRfXiaMywPs/kbMMFrjsGnW0ySNJCZFDDv3GpjGuJFf7VUiY0x3InB?=
 =?us-ascii?Q?iQgQZNpnzMTWHMddTWU+zLuh+XxdqrR5aHIgwiFiF2EYOBTJA5sEQCME/5cJ?=
 =?us-ascii?Q?cXGO9bQ/WHuRDy85V7vSs0x2RTwcYckwW/C67GRaZNhXMhIXzwpRZd8P/4bN?=
 =?us-ascii?Q?z33OsZzFeY7xCXgTfHBybpOM8ImBnDm0dG7uT19zUqKu1ZdD4XHjZEnsbIYv?=
 =?us-ascii?Q?SCmop7oRvSEStfnZUCWGVj/+kvs5hrUSUTJwJeO6wByCC0/8Y+LPiCkzKnl/?=
 =?us-ascii?Q?ZLjpn3c5bbmO5CQLRAGzggplIfT8pbtja2wYjkAkSZH8C5L0C8iqIfdfRVpC?=
 =?us-ascii?Q?D4v517aWrBYHHT6QltckRLZ3pH1JbXxFpGGBrCLR0nRNA/wfbLDiWmU4svKa?=
 =?us-ascii?Q?QimTt1M/BDHyQm16azQzuWvybKiRWZOaHYX0nnbHMMF52vUoTWO2Y9P3Goub?=
 =?us-ascii?Q?XR/sP5uyO1eHV0OIvEUdOimnF7LHmg7PXBF1VMtymEKada+HP4IFjx36NcZI?=
 =?us-ascii?Q?o10Y8E4GvszQ9a1CyFjQTyeklFKqYVytKOub9k0E4a99WslhLaQoDuBgfNEM?=
 =?us-ascii?Q?HWG0fwItrqZD7BeiMcdqaMYb58iKYowOORvCDmzoq8ZWdJw47UOU11tbpiym?=
 =?us-ascii?Q?2Xt72L6ZuoM3L/fZ64RY/O4N+4j2rzb8eEdupNAUDvjThK9wyIHfbV5OsuEi?=
 =?us-ascii?Q?lkCyudQeig9zT00gNy9q5Q924XLENaSxHmz0yoHIgnRUbMjhqkf3U7P8bpWL?=
 =?us-ascii?Q?hg5w/K1HlLa4+uwYYsiayjJdJDYN3G9Z23OmKhljJL+w4qYxEkpyLx0HTJJL?=
 =?us-ascii?Q?pJVdz/uRkcwLyBI6cOfpIi8xuAWTmZHiLkdgTX4lZ/TTiE4yaS9/EFT3hVTy?=
 =?us-ascii?Q?xs0vG1sr3tncTMCkZo4/Bz0YP8tqOAdSqjIQuvgbUh9yU37bdh/SplVvvyJL?=
 =?us-ascii?Q?xPRYLJfIrBf+aEW6/3tWFo3tfU4GJpBz7PdLFsBHkLZ0G9P3eMV2pH5BPKg?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f0317fa-8bf5-4bfc-8e5f-08dc53b18203
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4952.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 07:41:43.7548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB7169

From: Guanbing Huang <albanhuang@tencent.com>

The function __uart_read_properties doesn't cover pnp devices, so add irq
processing for pnp devices in the branch.

Signed-off-by: Guanbing Huang <albanhuang@tencent.com>
Reviewed-by: Bing Fan <tombinfan@tencent.com>
Tested-by: Linheng Du <dylanlhdu@tencent.com>
---
 drivers/tty/serial/serial_port.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/serial_port.c b/drivers/tty/serial/serial_port.c
index 22b9eeb23e68..6ed072d61b88 100644
--- a/drivers/tty/serial/serial_port.c
+++ b/drivers/tty/serial/serial_port.c
@@ -14,6 +14,7 @@
 #include <linux/property.h>
 #include <linux/serial_core.h>
 #include <linux/spinlock.h>
+#include <linux/pnp.h>
 
 #include "serial_base.h"
 
@@ -221,7 +222,11 @@ static int __uart_read_properties(struct uart_port *port, bool use_defaults)
 
 	if (dev_is_platform(dev))
 		ret = platform_get_irq(to_platform_device(dev), 0);
-	else
+	else if (dev_is_pnp(dev)) {
+		ret = pnp_irq(to_pnp_dev(dev), 0);
+		if (ret < 0)
+			ret = -ENXIO;
+	} else
 		ret = fwnode_irq_get(dev_fwnode(dev), 0);
 	if (ret == -EPROBE_DEFER)
 		return ret;
-- 
2.17.1