Received-SPF: pass (google.com: domain of linux-kernel+bounces-129328-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i5ec1447f:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542
Precedence: bulk
MIME-Version: 1.0
Message-Id: <a64cd887-423a-4dd7-92eb-42d9485aea3d@app.fastmail.com>
In-Reply-To: <e48c5226-9a25-ff24-45d8-5cc73d7d914e@linux.intel.com>
References: <20240403002917.2870959-1-luke@ljones.dev>
 <20240403002917.2870959-6-luke@ljones.dev>
 <e48c5226-9a25-ff24-45d8-5cc73d7d914e@linux.intel.com>
Date: Wed, 03 Apr 2024 21:24:53 +1300
From: "Luke Jones" <luke@ljones.dev>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>, corentin.chary@gmail.com,
 platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/9] platform/x86: asus-wmi: store a min default for ppt options
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, 3 Apr 2024, at 9:23 PM, Ilpo J=C3=A4rvinen wrote:
> On Wed, 3 Apr 2024, Luke D. Jones wrote:
>=20
> > Laptops with any of the ppt or nv tunables default to the minimum se=
tting
> > on boot so we can safely assume a stored value is correct.
> >=20
> > This patch adds storing of those values in the local struct, and ena=
bles
> > reading of those values back. To prevent creating a series of byte h=
oles
> > in the struct the "<name>_available" bool is removed and
> > `asus_sysfs_is_visible()` uses the `ASUS_WMI_DEVID_<name>` directly.
> >=20
> > Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
>=20
> Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
>=20
> (I know it is already among the tags but I had not given it until now.)
>=20
> --=20
> i.
>=20

Understood, very sorry about making that assumption.

Luke.