Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2569911lqz; Wed, 3 Apr 2024 01:53:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFClETSeY948X0CiRcxtlu3SimMCdZvVjCltGcph7GQwOL9yoGM6NSZwqfU2Fwcko5d7oaS5M8d/9Ut7i1eoykR+6VhAB8GTNxsiC8uw== X-Google-Smtp-Source: AGHT+IExNY/1BWmgfmpivkLOszuumApHjXtQkzL6FyachZKIZzPSU7g01grdrvqc+/YLTfSxhnTc X-Received: by 2002:ac8:5e4c:0:b0:432:c268:f3a7 with SMTP id i12-20020ac85e4c000000b00432c268f3a7mr15298704qtx.18.1712134404928; Wed, 03 Apr 2024 01:53:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712134404; cv=pass; d=google.com; s=arc-20160816; b=sgYlfIhaazP9sWo15FCPwWq5oHxPIOCdnsubn+1rJ8TKIXiZhxKpElIDD7ZA8+Iyz2 pPWGz/Ui8BGqvFF9i1qEmRS2TqJA8a9Sc3Ye2WQi6o53ZfM0CuvOOXo6E5jEgyXEW7XH qseIl4BxeiOfHrbbUtfbb8l6i+yutJmWcRNTbuiHBc5pp7M+LUYIl/h6ZGCTv+PaAqGg ZRP77UfiOOYuRdsSw7W+Nevqo+j+i9klWwFfwk8AdrCAsX+Nrun5AIQKFooQDWBjRX76 kOv4O58C6t6PaZKW/jk3Ppnk1twibdK30Hem/Mf6HJgwKP4UtCz8HQgVRe1ewav0Lp4s 8XbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:date:references:in-reply-to:message-id :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:feedback-id:dkim-signature:dkim-signature; bh=IDm9a9kuZKGr8VNhzI80ELq/9SON+I1L85BL3jH3M48=; fh=vFT8VByT7LGAwCEUyc83AyVGCRS3t5iOXflCa0DAU1o=; b=UqW4M1d0VH1zgVUbvRchLrfv5EJjWfi1VrS+BucCZebiBMdUiKSjXtvzvm1d/fJ/Bv hrHa6BT7OLBQi2JjvXvmIkYbDO7/5NRY02CSty+SV1vI+gOdCmobbwZZSvOUPSepW8JE B96FtijooeeDSC6MMlCCZhu4pRfh48k9MM1+VQEv+SHDBCR8p20nx4yiGs6Tl4Z6Ajyn QBob4uZTSG6zfDwd0ZsPRJuWGHC+q7q8yeam5RqC8EZo45qYXGCz+o5LQqOIvHn1ag+w UjDiZy3UxKYlkaHi+KnC22Wy2+t0ZQLEpo4SlXhYeC1wPEllQqgSnZAC5GToCPmPs+yD nAwA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm1 header.b=LGR2quk6; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Cjwd4uNr; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-129371-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129371-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h16-20020ac85e10000000b00430cad99fa6si13900916qtx.773.2024.04.03.01.53.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 01:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129371-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm1 header.b=LGR2quk6; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Cjwd4uNr; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-129371-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129371-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 53D5C1C211A1 for ; Wed, 3 Apr 2024 08:52:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3598D71B48; Wed, 3 Apr 2024 08:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="LGR2quk6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Cjwd4uNr" Received: from fhigh2-smtp.messagingengine.com (fhigh2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C92F6E2BE; Wed, 3 Apr 2024 08:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712134291; cv=none; b=Kwy2IvJsTmI3A60a43je0J3Qbo6s8MAaIxnmgJcao16Z4bxLBZXzVPjdUOGe1FwpYrNjDvtICZiQI6C5MPQvblob/bQhlqTNs3szJh3NzUess7z8fQn2BAm4+ffX8zJJiMAWALtFUVJPRR1TEHGsuPhVxP3/lK055AxUUdZGr3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712134291; c=relaxed/simple; bh=P1cwV2YXIakKbwCYEURhjXiCMMQo/OuU51t31+urNz8=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=EsaJoWVrAnFKJypGMKl/u/u6isb07il9U+//9Orw7AvsW3BBQMWzy/Nw+PAyruHu+G1bKOMNQxKeanvL18TjOGUFAEd/bVA7B0CieEDePuw3iW233EFJ2wH/BZY/11p4Jt5nIwVOKgXESoPp/i2DHGfrilnICEWCSeQ58F4kyHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=LGR2quk6; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Cjwd4uNr; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 71FE91140094; Wed, 3 Apr 2024 04:51:28 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 03 Apr 2024 04:51:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1712134288; x=1712220688; bh=IDm9a9kuZK Gr8VNhzI80ELq/9SON+I1L85BL3jH3M48=; b=LGR2quk6JYv7Fnxq/DHuNB2s1l 6Ys8LLJKriPHlHTWOxFB9RsOvILxcS/KYYwjrIGkGBfhIuC6uJxiMQywv0+g1Aqi 8FYEiccMNVK/JM+9/wvFtP5Fw1F8kgaiZ6gliWPO1A6/eOeKOJLqvcUF3ylLAAlv zwl1mP7HPfWIKsePCNEMejjKQxudWNwarD9rLsx0koyjvFwDf/honupj9EX9XCjy bNtk0jDvVnb/Sz0cSkLE5K7XZ2/agL3OccZ2Mc0uvhAkMZaWp7AXYNG4koim1/JO NWrCRHyNlg3Ew+NUDtI2loKoT+PAc519YKeQkoNdJP594Qu6z51d5uFo9lYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712134288; x=1712220688; bh=IDm9a9kuZKGr8VNhzI80ELq/9SON +I1L85BL3jH3M48=; b=Cjwd4uNr7CNtFCTbVUASdb/gpU8laqnra9RJirerO12G 5SOUnLJXyFizzdU931oTSlEXaZ0BkAg60Baud6Aj/II0MKvLDLlSYr2oJBrvT07G +41EN83FkxhBNyCusJQyF0Hwit7nA3+A7ni28b/dAWW0S2T/fi7/3JLNiwWI6FoM YlAJWV4vEHbP5nGTTmFZ15WoWraZadPrWUGtI7m/NHC7urjFsHeHkIwB8EZOLTct 1GrnBaR/+9Aw4G6lbtigODY6AK3nVq5QtixWUZ0iFYpkvPsWxvRW1PEUrhe7hs5X XZ7rx4ckokuvMkOPVe83besvIx+NGyfZTgpqQOR2Pg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefgedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 2F269B6008F; Wed, 3 Apr 2024 04:51:18 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <78731619-58a3-406b-9112-5eb991bc6e7e@app.fastmail.com> In-Reply-To: References: <20240403080702.3509288-1-arnd@kernel.org> <20240403080702.3509288-31-arnd@kernel.org> Date: Wed, 03 Apr 2024 10:50:57 +0200 From: "Arnd Bergmann" To: "Damien Le Moal" , "Arnd Bergmann" , linux-kernel@vger.kernel.org, "Niklas Cassel" , "Saeed Bishara" Cc: "Ma Ke" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Sergey Shtylyov" , "Christophe JAILLET" , "Jeff Garzik" , linux-ide@vger.kernel.org Subject: Re: [PATCH 30/34] sata: mv: drop unnecessary #ifdef checks Content-Type: text/plain On Wed, Apr 3, 2024, at 10:32, Damien Le Moal wrote: > On 4/3/24 17:06, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Building with W=1 shows a warning for an unused variable when CONFIG_PCI >> is diabled: >> >> drivers/ata/sata_mv.c:790:35: error: unused variable 'mv_pci_tbl' [-Werror,-Wunused-const-variable] >> static const struct pci_device_id mv_pci_tbl[] = { >> >> Move the table into the same block that containsn the pci_driver >> definition. >> >> Fixes: 7bb3c5290ca0 ("sata_mv: Remove PCI dependency") >> Signed-off-by: Arnd Bergmann > > The patch title is also not describing what the patch does. > Are you OK with changing that to: > > ata: sata_mv: Fix PCI device ID table declaration warning > > ? Yes, please do, thanks! I had first tried to remove all the #ifdef checks and just rely on dead-code-elimination doing the same when pci_register_driver() is stubbed out and IS_ENABLED(CONFIG_OF) checks turn off the rest. Unfortunately, the include/linux/pci.h interfaces are not all stubbed out here and cause compile-time failures without CONFIG_PCI, so that didn't work out. Arnd