Received-SPF: pass (google.com: domain of linux-kernel+bounces-129439-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <277decf7-d9cb-451c-a105-6ecc998f9f46@intel.com>
Date: Wed, 3 Apr 2024 11:37:45 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: include/linux/build_bug.h:78:41: error: static assertion failed:
 "struct bpf_fib_lookup size check"
To: Arnd Bergmann <arnd@arndb.de>, Anton Protopopov <aspsk@isovalent.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>
CC: open list <linux-kernel@vger.kernel.org>, <lkft-triage@lists.linaro.org>,
	Linux Regressions <regressions@lists.linux.dev>, Anders Roxell
	<anders.roxell@linaro.org>, Dan Carpenter <dan.carpenter@linaro.org>, "Daniel
 Borkmann" <daniel@iogearbox.net>, David Ahern <dsahern@kernel.org>, "Alexei
 Starovoitov" <ast@kernel.org>, Russell King <rmk+kernel@armlinux.org.uk>, Ard
 Biesheuvel <ardb@kernel.org>, Linus Walleij <linus.walleij@linaro.org>
References: <CA+G9fYtsoP51f-oP_Sp5MOq-Ffv8La2RztNpwvE6+R1VtFiLrw@mail.gmail.com>
 <CAPyNcWeu+bzyQg9S3wDb43jbfk95Su5XcSRFPzUbS2ofZ=+5Fg@mail.gmail.com>
 <347bb21e-98db-4bd5-9ca1-550eac5be9f8@app.fastmail.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <347bb21e-98db-4bd5-9ca1-550eac5be9f8@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFNhRnFYWGFXaDdDNW15RTZPNk9HanlyOWU3MnNwMjRKMFZad2ROTCsrT3dz?=
 =?utf-8?B?Q1BzMTFsYTNDdU5iVWIyVDRwOGxsNWZvdkk5VnhES0RqK2F0alB0NTV5ellL?=
 =?utf-8?B?UW5vVGN0ZzJiRU4wemtrMWY4c3NGd053UEpiU1RVMlhnVjZ6UkRkdzEvNG5P?=
 =?utf-8?B?ckhxSkFLUVZrWnpOd0Z1WXY2ZkhjSnNtVWJMcWxTYnpyT1g5eC9MRUNUeUZi?=
 =?utf-8?B?anlnamhQbUdtWFIyQ2lTdUVWbU1tdUIyZVY0a0ZaNmVsSmkyUnFRNE8zTHdV?=
 =?utf-8?B?NkFLbVoxV1BpTkFob1F2MW1EaCtacVF0KzhmRmg3Smx3eDVNK1ltMDFYcGJq?=
 =?utf-8?B?eTZBZThuTkNHQ3FrN1pCRlJpOW8yY3NPQU1xVmRoQjZkWldtTTd4RDJOZnR6?=
 =?utf-8?B?REl1U1pNSjJDWjM3UXVyQ3JlUkxKN2tBY28rV29BcjE1d2RhelNZY3VBV0w5?=
 =?utf-8?B?akNOQS9EZ2dTaVZrSG1sZlBZVSt2ODJXN01iNERaUGJ0c3prYXBwUXBLRzJD?=
 =?utf-8?B?aTNzekx0aXgyb24zczlvY2ZSN1RUZ3RSekZxcktyZE90UWovSmxUSWQvYjZJ?=
 =?utf-8?B?d0JqSWQyUEs3NTJpNmJ1ZDRHR2FZQ3NCbDM1SnZpVmUwczQxYmdTbUxuUzMx?=
 =?utf-8?B?eUVIcUVlT3FvWThjZXViNnEwR2xMWjJPZ0NSaXduUE1xWkYxaUtGZWxUVnV1?=
 =?utf-8?B?L1hHY2RYb2w3eVN6YytWMjdDMHdwRkFEclUrbi9jeFpNV1JwMkxzTEM2Z3V2?=
 =?utf-8?B?eXJZNzRBdW9rY29MdzRwSmFqZlRHZy9TZDNyMWZPTWUySUxrOGVONlN5MmNu?=
 =?utf-8?B?dnBXcGp1bTI3VEw0SVVSTEtPUWlwc3NsY0djemlqTUhmQ0MyWlVTOWl2QTN1?=
 =?utf-8?B?OVV3TkxIRm5ReUZNK2RQdUM0b1puNlArQTVuRXBqWHU4dWNpTXpBNnVJWWtz?=
 =?utf-8?B?d29zL2xISFVqcVhVenBja1FkYnZNOVRURmFXUGVqNHdlajN3Sm9pL084VUxH?=
 =?utf-8?B?SHVDY1hRQys5WGJlcmRlRmlJY0JTWityNU9HVUpxQ2QvWnZXUXQ1ODU2eFZ4?=
 =?utf-8?B?Tk9NZUUrbE1HOXNDSUw1SExNVGIrSGlpdzRxY2ZTd2FidVZMTjYycE0rK25u?=
 =?utf-8?B?QUgrbWd2eUlJdmxWQzV4TmIzQ1lLdGdXaFA1YVljQVk0MWZLU0V6UVdoaEo4?=
 =?utf-8?B?d3NUZXRoUmNxV25qVVFwUVBWN3F3d045V04zNlg4WVR3dXJabi9xOUZBbGlD?=
 =?utf-8?B?OXJHRWJxc09SSVlZNVRVcldSN01KeFFlR3dPZU83Y05KUGpETSt5R3FVY1J3?=
 =?utf-8?B?UlNuT0Nvb1JaUzNLVGhqWVU1Wkx5b0MxejBRc0FlV0RLelczOWl2dVBIODVK?=
 =?utf-8?B?M2VUeHdNVDhJRDBVNWZRWVFjNDB0QXpPdTFjdDJHRGt2d2xhUktURkpLS1dU?=
 =?utf-8?B?d0RHZlNrUGdRSkplbzg2SCtSdkRsajl0UnlxRTRsa2duTVA0bUlPWkw4Q1VL?=
 =?utf-8?B?cUdFVWxseGdON3NNZnBGSVVZRzdvNTFDYVN5eHF3MVhVbkpVajU3aHVRcXo5?=
 =?utf-8?B?dVhMR0FuK0xxa3dPWFB4YU1GRzVEaXlDcHA3Y2tiUnJYTHNoaWRlYVI2em16?=
 =?utf-8?B?bllpdzJtNjIvK3JNazdxaUJzZXIvVVNyNEc5djUwMisrc1hrUE9sR2lQaVZt?=
 =?utf-8?B?MlVnL1Y2OE5PQ0xqVzJYWXhWSFZDWGcwM2k1RitibEpNL2RjOTVOeHEwQlM3?=
 =?utf-8?B?akpiSUNjM0lueFdZaXpqelpPSGZwaXhDTkgyanpjM0JuQ04vc2xJa2dNZU5Y?=
 =?utf-8?B?TDdveG1VaW5rY1NVZEZmMnN6VG1ZU1N5U0dCUEc3NlI2Y0JlWlYvb1ltRlhK?=
 =?utf-8?B?aGJQVHNsd0FtRGdWbWhIVFhGZmFHYjZCRVZpbWlLcVJ4YldPb2tEUXRPbDdF?=
 =?utf-8?B?MHNQQzNSemFQa2llNG4yUnd1Nmc0NmUrUGV5dENLYjJ3QnlXQks3OFlZVWlY?=
 =?utf-8?B?VHRUQzJKckxCWmp2N0J5c2tKeENCY0xwNXorZWpWcUpJcEU3S0tUOVdvSDI4?=
 =?utf-8?B?TklZN25Mci9OWTNJeGlFeFdoVUVwb2V2cFUwOTAxTkp0N2VZaE04MVJLZmtB?=
 =?utf-8?B?Qy9pOXJFVHpCSklQRG82WmdjVnRtaVRPU2VLRVkzWVlqWkIzK0tZVjl1dkM5?=
 =?utf-8?B?aHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aa6ac31d-a972-4b8a-dffb-08dc53c1e2a7
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 09:38:57.8087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gFFHUWp9how0vjPI4XEXzggOgqWXifU2XtF4znVA2gpKKGK1XSab3pRvfBqI0z15+sGZqQlVqlexQsjVL4tgmOL6ZNXR0Vs9w+gyoFqXfQI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5946
X-OriginatorOrg: intel.com

From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 03 Apr 2024 10:45:36 +0200

> On Wed, Apr 3, 2024, at 10:10, Anton Protopopov wrote:
>> On Wed, Apr 3, 2024 at 10:03 AM Naresh Kamboju
>> <naresh.kamboju@linaro.org> wrote:
>>>
>>> The arm footbridge_defconfig failed with gcc-13 and gcc-8 on Linux next
>>> starting from next-20240328..next-20240402.
>>>
>>> arm:
>>>   build:
>>>     * gcc-8-footbridge_defconfig - Failed
>>>     * gcc-13-footbridge_defconfig - Failed
>>>
>>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>>
>>> In file included from include/linux/bitfield.h:10,
>>>                  from arch/arm/include/asm/ptrace.h:13,
>>>                  from arch/arm/include/asm/processor.h:14,
>>>                  from include/linux/prefetch.h:15,
>>>                  from arch/arm/include/asm/atomic.h:12,
>>>                  from include/linux/atomic.h:7,
>>>                  from net/core/filter.c:20:
>>> include/linux/build_bug.h:78:41: error: static assertion failed:
>>> "struct bpf_fib_lookup size check"
>>>    78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>>>       |                                         ^~~~~~~~~~~~~~
>>
>> Thanks, I will take a look today

Naresh,

Could you please remove that static_assert() and dump bpf_bif_lookup
layout from pahole?

Anton unionized { smac, dmac } with __u32 mark. On x86_64, the offset of
smac was 52 (aligned to 4) already, so I don't really get what AEABI
does here. IIRC it aligns every structure to 8 bytes?

Maybe we could just add __attribute__((__packed__))
__attribute__((__aligned__(4))) to that anonymous union at the end.

> 
> The problem is CONFIG_AEABI=n, which changes the alignment
> of sub-word struct members. I had assumed that AEABI is enabled
> by default for everything already, but it looks like footbridge
> and a couple of other defconfigs still have it turned off:
> 
> $ git grep -l  CONFIG_ARCH_MULTI_V7.is.not arch/arm/configs/* | xargs git grep -L AEABI
> arch/arm/configs/assabet_defconfig
> arch/arm/configs/collie_defconfig
> arch/arm/configs/footbridge_defconfig
> arch/arm/configs/h3600_defconfig
> arch/arm/configs/jornada720_defconfig
> arch/arm/configs/neponset_defconfig
> arch/arm/configs/netwinder_defconfig
> arch/arm/configs/rpc_defconfig
> arch/arm/configs/spear3xx_defconfig
> arch/arm/configs/spear6xx_defconfig
> arch/arm/configs/spitz_defconfig
> 
> Russell still has machines with an OABI toolchain, but I'm not
> aware of anyone else relying on it. It does cause other
> problems as well, so I already turned it off a long time ago
> for my randconfig testing.
> 
> We should probably make it the default for everything, except
> whichever defconfig Russell uses:
> 
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1159,7 +1159,7 @@ config ARM_PATCH_IDIV
>  config AEABI
>         bool "Use the ARM EABI to compile the kernel" if !CPU_V7 && \
>                 !CPU_V7M && !CPU_V6 && !CPU_V6K && !CC_IS_CLANG && !COMPILE_TEST
> -       default CPU_V7 || CPU_V7M || CPU_V6 || CPU_V6K || CC_IS_CLANG || COMPILE_TEST
> +       default y
>         help
>           This option allows for the kernel to be compiled using the latest
>           ARM ABI (aka EABI).  This is only useful if you are using a user
> 
> Or we could go one step further and make it 'depends on
> EXPERT', short of removing it entirely.>
>      Arnd

Thanks,
Olek