Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2592991lqz; Wed, 3 Apr 2024 02:49:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWBDgBF7+EdvE16p1kKg/cfzDdkLhZwjwspich1fVIytYJuN9/Wflo9440JAYGvAZ29Ox5S2mBDmYlSmz9ezlUbFK4ncZ3tEtvbAqVK9Q== X-Google-Smtp-Source: AGHT+IFsMUM5z4Ty42MIAJA+oq8BgWGLiLK7tghuJY/HVTcvRom41RaEwBsViDivxqOzPO+Smo81 X-Received: by 2002:a17:906:da8e:b0:a4e:379b:753f with SMTP id xh14-20020a170906da8e00b00a4e379b753fmr11144240ejb.23.1712137761687; Wed, 03 Apr 2024 02:49:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712137761; cv=pass; d=google.com; s=arc-20160816; b=dDCKaJlI5ylRgkTY90C4lZMJisHsWUuygho6jHZDp/XHjD/8exapJI8qnS9WXrFXx+ eTdDMS6ohKvGNb9S72gWbOQFcmTpHqFVNPR0FT86GU5+TOLKul5LQg4EeIPUQklJwIRc Wyos8l9VYstXxlpQb8jGEnpKKRQRmgyDjZMRpDZcZH0s//XVdUt6QnDUMn9TXOYyTu15 qhAhS+oMFXtSDst5U1KnkxwvVHDU3D8Ihn0VeufcWn5bk7ABjwesANmtwWXZVHIQin8U MqNaUSmz3oVMtw7086ANiOEku4l8uj6iCrhO8aZCs5Cy/HqdQqADXyn5v5tf6AC5FGP0 UePA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=3tvxwcGEaXlq9t2qggBvOm4jDfIobjVvvQgoLk34JPw=; fh=a1O6qJHcKBYP622SFLDNyNRcL6S2DnqdO+y2rKO8XyI=; b=dKZMhYLcRKfhGeE2Al9dT/uuPAMeaYonAGorbY8DGiaXfDkQ8Q5UQuILDvm95t7DTD rWnvSk0GFoQ4BgGwqMCAg9Txsjtvch+SMijVWDFJ3/UHsGKlP4NBGhUiBTPGgCuhxldI 4t3vne6bdT4JDgEZSulh2k1/NIzh+mYgRk0cb8IM5kDz+wy5DjZEpdobXv6iSu7vsQgy NQhjFqc8r2Zp5btfO1r9EPYep52ZvaW+Aj8bjwci1UNayC2gAr1Bzh/gzV4wEUZ7Ea4J W4HvPEsxsufH1wVaQGj/1DTlwLVAeeOZo8jk+EemgOqFFaix3/o+Dl0mTGdNk1ifyYac h9HQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gyS0iJV4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-129455-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129455-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id j21-20020a1709062a1500b00a4e78093336si2395242eje.103.2024.04.03.02.49.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:49:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129455-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gyS0iJV4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-129455-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129455-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3E5CD1F28015 for ; Wed, 3 Apr 2024 09:49:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2C08554725; Wed, 3 Apr 2024 09:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gyS0iJV4" Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA0F8134CE0 for ; Wed, 3 Apr 2024 09:49:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712137753; cv=none; b=VzeYrpRLOn1rUIKCuzO4nV0q/huAms/PgikO4jVmccuF5FC09LRJHzcaeXJCQvvwTTYa7iU/ufEyVOGIqL7jnoqcepkrfMgsMek1kR3069sxQ9ZhYzanu5wP8gep/F5fKiVYRpXcbDwsJJWUAcMzrgixxjgDbdDyvEYB/KMRUDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712137753; c=relaxed/simple; bh=I/lHK07ldnCHYwMXK+O+modiLmcQLlhWwsMZypnyawE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=A0GNRORoGJXNwA7FIh6eH+1/0gNvcXwbrsHrBPuctDX0QJXQqPz8GcbEYmULlndN/UwuRCfYmz3lc7IxvAnaqYUF16zrggfFYd0jeQ4evC1C/i1IYd2zVfW2k4twRHc/AY511AHFEOp6BtqFxaBsB19pb0yDnP8vbXd3trXB5Zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gyS0iJV4; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-ddda842c399so4894485276.3 for ; Wed, 03 Apr 2024 02:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712137751; x=1712742551; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3tvxwcGEaXlq9t2qggBvOm4jDfIobjVvvQgoLk34JPw=; b=gyS0iJV4JbOjl0nH6c1arzmrIy2B2zK5JHKy20mJ4XpVh6oFLhihKxk4fybz8dH7ZG 3PhWDUbdNqQV8jAUXiruBp6dmZcruQhQDVdd7DgriRSI8C6LIRvjL/o3a2bPNQmZXkA0 v5yD01WuIkOxY0cQQVSxz6ue1fvgcknQF63fbdZrT9kW9jShKeW3RgnBR/o/id315Sdc Q84gc858fOJNfUeLczirbYsfq1U5259rAGPRISCfbCmMWxSpHojVq7xHdyF8bMOFiTaK glElAzOh59YwnqmQX1RCSeFbeEGsyQmGS5JkyY+myrn1t9BlcAZ+zKvJfXei/pRC6dOl sNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712137751; x=1712742551; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3tvxwcGEaXlq9t2qggBvOm4jDfIobjVvvQgoLk34JPw=; b=jSY6jymQvT8iu1TgjolFvisRxkdxWHubReltD2bioyyWAb42bJBmxLRCoYu0lsJaZJ UA4HYiS5TcJ704y3FadXJR5pUN1kqh/D4XdtIsFWIP2y8KI7b+mp1t+1B2aDMKvxd/5O +e66oteKdOawbYcrIDuBASmQJRTNc3adurqkZX1RwC3E8lfhLZ8QkKr46NFy+FrV7rLd TEUvxEynRNgYfvMDnun16NGzpC3VV70wxk957EQ0MAa3TXZeJc2R+kPh1Tw+obwMRL3i IIYng55uJS9ndEZQYFBrzssgCDTqnzRJgWoLyHgTlO7UZaRCn2oSvcOv8cLqbdwhVNiN PuXQ== X-Forwarded-Encrypted: i=1; AJvYcCU0VuJmaS84XO9kkoF/q7p8qk8bxt442IJ9eSZsw+gxUNv+IvO1gDn/qmW4QJoSxW8SsHoyPO6Mu+EMYlzNlKImlC3Y8a9FYEEgXbMg X-Gm-Message-State: AOJu0YzbGsRM3qdmiMj1L0sCM+giHaUcRKP953x1Ln7+y9UzZMiVYhKN Z/RuFILP7YZ1gmMth+6J98RgwDZa/qdyYrGF18Oy6YrgEjeJ1SpxjZkafRnHGmhEkv8noEUCkAN OpLfqODm1pg2FMAm0dt8Wr+TC4u6neMdhlrJE3g== X-Received: by 2002:a25:b989:0:b0:dbd:8f9:a71 with SMTP id r9-20020a25b989000000b00dbd08f90a71mr12861423ybg.28.1712137750746; Wed, 03 Apr 2024 02:49:10 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240403-msm-drm-dsc-dsi-video-upstream-v1-0-db5036443545@linaro.org> In-Reply-To: <20240403-msm-drm-dsc-dsi-video-upstream-v1-0-db5036443545@linaro.org> From: Dmitry Baryshkov Date: Wed, 3 Apr 2024 12:49:00 +0300 Message-ID: Subject: Re: [PATCH v3 0/6] Add DSC support to DSI video panel To: Jun Nie Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Jessica Zhang , Vinod Koul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jonathan Marek Content-Type: text/plain; charset="UTF-8" On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > This is follow up update to Jonathan's patch set. > > Changes vs V2: > - Rebase to latest mainline. > - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in > latest mainline code. > - Drop the bonded DSI patch as I do not have device to test it. > - Address comments from version 2. Which comments? "Adress comments" is the worst case of changelog. Also, what do you consider as version 2? Jonathan Marek has only sent v1. > > Signed-off-by: Jun Nie > --- > Jonathan Marek (5): > drm/msm/dpu: fix video mode DSC for DSI > drm/msm/dsi: set video mode widebus enable bit when widebus is enabled > drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC) > drm/msm/dsi: add a comment to explain pkt_per_line encoding > drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 > > Jun Nie (1): > drm/display: Add slice_per_pkt for dsc > > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 +++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 +++++ > drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 42 +++++++++++----------- > include/drm/display/drm_dsc.h | 4 +++ > 5 files changed, 44 insertions(+), 20 deletions(-) > --- > base-commit: b1e6ec0a0fd0252af046e542f91234cd6c30b2cb > change-id: 20240403-msm-drm-dsc-dsi-video-upstream-1156d110a53d > > Best regards, > -- > Jun Nie > -- With best wishes Dmitry