Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2594067lqz; Wed, 3 Apr 2024 02:51:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUoJh4BNJ3c4rQvHyEUx+qth7jfplwVf7njzsKgp6fCMxX3l2jrpPak2iIIkLH+w9DmvjDRzsBlIIkClMvOltEL210vLM5X7Qvq5us08w== X-Google-Smtp-Source: AGHT+IFi4BDEPM1Flzf72+sR7jxw3x7oqgL27Xsa8lYUpmzs26oQkly2W54g3d9cqBHgrwq+XxzW X-Received: by 2002:ac8:598a:0:b0:432:b568:4218 with SMTP id e10-20020ac8598a000000b00432b5684218mr2667131qte.7.1712137904620; Wed, 03 Apr 2024 02:51:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712137904; cv=pass; d=google.com; s=arc-20160816; b=OEVBpv8woX2otL0Rv2mWjYb82q0xrBu6NPFbokJ468RIzD17apZ5/H3wQbAOQFoMUk rlFICV6lMPYyJIy995+eLO+i30VXGdmXKiSFTx+/TcSxIt69csqEOJOu+hu5t0cWZuX3 SySt11BPay9D9Buc9D9qf2U6Yjf1zU2XvyAZpLOOjysbKbh/01myvgebMVpEEGuPjgwy 9GIOk0NV61zCP6kn1rG+LLZFIVN78hlkhyKIKoi3xMle0cJAPsW6c0I2vbOua3RewCER 8+XSdkKF+EjMfoNS9Xq/P4FyRvTMhnpErf4jwg0KS0DWgiwhKCgCSoshDdBzsjEjwQOu SmGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=GdBEK5rBi6lDA78Fluo4Gz0gjag2zt4nH0XY21tO29w=; fh=Div9J31vGSr4PuJZY/dWsifsI2HhKQ40ZNrUdnKw14o=; b=ItEMYWsG/hvpJ39aTdeoJNgWQ5jtyVOC2AY/pP7V5+3Xm2NifyNGUAQ4y+0qoBsTXY /f6QSCcSCTxUUZwnPci6xmY/kGoyQNItqCA6AoYKuQFns0Sy6zVEoq5E6QnS4qqv58TL /Axa4p+qIEd4YW9EMhPDHIU/SmNzlL7jRgac1TqmnICro2CqddaofjyYB5SOM3w10hSG gx8Qp4O+iQ4UhwpBwVholRBWzTcBvv98kRqdukeyq/Y/JZcmJ3OHy4tyAet21BKye1bq 5FGr+H6cFIJoT/+9YxVxpNyrPP21reursLyo0Q87W7cPjPGcttGFCyoZZZ6tnR2qgodP RLyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JBwZKkMS; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-129456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dj7-20020a05622a4e8700b00432c273cfd0si10639646qtb.741.2024.04.03.02.51.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 02:51:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JBwZKkMS; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-129456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3A0201C219E8 for ; Wed, 3 Apr 2024 09:51:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA4F41350C7; Wed, 3 Apr 2024 09:51:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JBwZKkMS" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B4C134CEC; Wed, 3 Apr 2024 09:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712137898; cv=none; b=mUBdwdI4qLqohIaF4M9NlV1G5DWKw7OB8VpNcyR6sp8nD9LlbXXFxACj727xmm2d0BqAQm2OjSXx+4dKKpTSZLoKnhNbZ3M8XixYoRVwM3oWAcxefl7CphO6tFDNTCSEoikQL4hgdP7wZ+55I7MW8k+u8vzQwaCKm85h3F0P3RA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712137898; c=relaxed/simple; bh=UlQ5M5jQ/y1l1+Nge/gyBDCwSh9jn4Yk2MPadvINEZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ko6hcVTRySgEOrQRyGU+P5GdIreNlk9ZPlCrJN47D3q0xb7e/O9pPbmVdlzH4L9lWsZ46XjUdBCQBxKm+CtEbUUrTRkkBnnMMo9MrKlPyYWS/CKIS621lWmNx3cBMJaz3XQisDEucwrW6nmyfIebcYcNlKs+5QQ69GwXZxWMFC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JBwZKkMS; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712137898; x=1743673898; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UlQ5M5jQ/y1l1+Nge/gyBDCwSh9jn4Yk2MPadvINEZA=; b=JBwZKkMSSU38nnixv0KV5FmxVoyCTchVSObSAXBF7Jqt+SuVcU3xkYJ4 78KE/R6S/OSA9sgcY341dKqvZwZeEfuVxiAxfRaWIxKyJH2SVkcFJxKNT c4TvVYd/1QUndihLAEjrVvUa/LKeSjPIlOAL2vpJQB7r0736ojBKdKP8F q9mJdQKf6k130YC12eTD/fFsqPZMtGNqgnhOnqJgwi+Pp6vwUG1suSRIy 7bi79qq6HIFG3+FLIgoCvKKwzHuBkG61TzBsj/RTcp3t9XHqgjIHZIRhM hcoZrM6iIUg550eYOdOZ2NQ8dFFXoduXjFeqLq1DcqsvTfKAod8P1N8WD A==; X-CSE-ConnectionGUID: qNIAhV15S+aDxV5vPHevdg== X-CSE-MsgGUID: oens4BLFROeAQi8lo/gqFg== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="7484189" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="7484189" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 02:51:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="915176741" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="915176741" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 02:51:35 -0700 Received: from andy by smile with local (Exim 4.97) (envelope-from ) id 1rrxHJ-0000000154H-0VG5; Wed, 03 Apr 2024 12:51:33 +0300 Date: Wed, 3 Apr 2024 12:51:32 +0300 From: Andy Shevchenko To: Chen Ni Cc: vkoul@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: idma64: Add check for dma_set_max_seg_size Message-ID: References: <20240403024932.3342606-1-nichen@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403024932.3342606-1-nichen@iscas.ac.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 03, 2024 at 02:49:32AM +0000, Chen Ni wrote: > As the possible failure of the dma_set_max_seg_size(), it should be > better to check the return value of the dma_set_max_seg_size(). OK. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko