Received-SPF: pass (google.com: domain of linux-kernel+bounces-129501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 3 Apr 2024 13:06:22 +0300
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Guanbing Huang <albanhuang@outlook.com>
Cc: gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com,
	linux-acpi@vger.kernel.org, tony@atomide.com,
	john.ogness@linutronix.de, yangyicong@hisilicon.com,
	jirislaby@kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, lvjianmin@loongson.cn,
	albanhuang@tencent.com, tombinfan@tencent.com
Subject: Re: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to
 __uart_read_properties()
Message-ID: <Zg0qHs-wzG9y0lQt@smile.fi.intel.com>
References: <20240403074130.93811-1-albanhuang@outlook.com>
 <PSAPR06MB4952D98B1204C8591989DB25C93D2@PSAPR06MB4952.apcprd06.prod.outlook.com>
 <Zg0nSz7QSBjIQ_XP@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zg0nSz7QSBjIQ_XP@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Apr 03, 2024 at 12:54:19PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote:


One more thing, the Subject should start with "serial: port: ..."
And also should have PNP IRQ (capitalized).

> > The function __uart_read_properties doesn't cover pnp devices, so add irq
> 
> __uart_read_properties()
> 
> PNP
> IRQ
> 
> > processing for pnp devices in the branch.
> 
> PNP
> 
> ...
> 
> >  #include <linux/property.h>
> >  #include <linux/serial_core.h>
> >  #include <linux/spinlock.h>
> > +#include <linux/pnp.h>
> 
> Keep it ordered (in this context it should go before property.h).

-- 
With Best Regards,
Andy Shevchenko