Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2609568lqz; Wed, 3 Apr 2024 03:25:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUYEFMc73xrzv4qkJ3fOuGfSp2yxu5MDpIi2XX65kaLXkT176OLgSOLbihuefTImMfl3z2D3S2eiAg48oVWs7b+c/iF0drNrJQ8GXMpJg== X-Google-Smtp-Source: AGHT+IEgdFfZJL0dYrhOvP718/pxOCoPQFjsIyuAjwe2jsaCyrjFKiS7gjKgKyG+HfFNFyEylFcU X-Received: by 2002:a05:6a20:12d0:b0:1a3:c8ab:5a7c with SMTP id v16-20020a056a2012d000b001a3c8ab5a7cmr2917662pzg.22.1712139920113; Wed, 03 Apr 2024 03:25:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712139920; cv=pass; d=google.com; s=arc-20160816; b=XUYqQQn3TND/0+JI9mRFLaZgjCwYkVIHEhSMQizSn5/8L7L1iLrrWEGXnbTbMs+4j9 lhv9xqG15IHg4zl0KeeLfh8lyP8oHGoyT7UF+yzDvlS5HEYjvwECzCOvnySDsKo+VFNZ oQfv0/1PJdxqMi0VsbC9XlMVDTo1cMcsn3PhnytAhMqzkYUkckSAmnhg4IFEWLyn5srv CvMCsSnQ05m5fC2r+a7gA0+ZdCU7GSBXg0KGtXaQMAHHjHPDeTqq0unV97MYNziWTOZH sZQImPe/tj7+3SJTm8lnWnGdFhyNdOQhAg/gSlfjDSUBoLjk4Kz91zfRgC+IO9rGkUMl /UvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ENZFk8OXOtjF22+Z4ymb7ODvoxHn8Hzco+qGjJmtf3U=; fh=mlhNWjEbCQGRTq+1HSmYY0t3ADCzHx40ZhecFCF4oPk=; b=fZ0bTcSV2YEqBFyQZwirgSmLvbEnOs23G8KTKoVRPyNxJWBqAfadFrnsTk8+SI1/m5 DQADeOUfmtCM/f2jJRvYHClWfPXdWAZXpRq0bLxZm5QEkLMABcGI/7Ekp+MlAeZE2Bwa OOKfX/a7m8BUuYpqM34b39b82SAYNLhI0oejJeOoHElt676QM8hYLN0V6VH6fvOqpUeM GBTibYZ6U3FK/lz+5PuQD7zv+3zhVsVPKTv2sKiBl+7G/LUIBN8BYKzhL4yLVhwCZH5r DZtrMOrZk4O7E3QFnv8mlNgAeHWQkGSFjTHR3u2t0mLraxRjZZs+O8M1wVTQWoLfNOZA 8FpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gLUONVuK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-129530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129530-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 16-20020a631550000000b005dc4af11fedsi12805782pgv.887.2024.04.03.03.25.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 03:25:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gLUONVuK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-129530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129530-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 232F128B02C for ; Wed, 3 Apr 2024 10:25:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EC3BF1386C9; Wed, 3 Apr 2024 10:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gLUONVuK" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E51A259C; Wed, 3 Apr 2024 10:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139901; cv=none; b=QQJDBaVj9vPyExEoOQSWkgb8kTfAo/QBWsap7rQlEJwuWMaOaiZaf8m4zCIohs03dRmTk3tL9G6JEr3FK6WoPyiEUiNFdlsY9rBlOlg9aeaySptgqpi18q+RLU8bKXD5RM1netmNEbqBDwhNmWU3bXjUiwhIZ5FFSwFtQIff0+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139901; c=relaxed/simple; bh=i7EVMi2k6asX/CslsBvhJo87LJVDLcOCeMymckLgdy4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VvgA4PdR0mo++IzDafJsAUwUVYPvvsCEFHjuXcNpF2ptZLk1vnSTZf8mzJ3L28baCwXAk2APB4g7MLBUUOULRnz7NoRMYvfDyQ3TMpq5nrX8a6boX47fz3f+Rr0mazeYdFFQag9abb4bOSF9rVuAWE8N+KhIBNEffcRZI7mqpMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gLUONVuK; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B1B8C433F1; Wed, 3 Apr 2024 10:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712139900; bh=i7EVMi2k6asX/CslsBvhJo87LJVDLcOCeMymckLgdy4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gLUONVuKkysU9vnwUm2raqV+9g2rbvK/nPiMr1UiwLRFR1UcsXrZNzjKpVWrMNaQ7 4xLCu7UAqk5O6VEd6gw3eSTrdQLoqD0XWhqL4TGCDJv7KRqVPSyfTe9ARiEXIJh7nd XZGbhcZXT5lJ5jNU8XYtoWwg+UytGA83pOxlMpuAurnaYg+3ojP0N2535E4j0OMls9 53eoGC47pSFWS3+M4cdIxAx2GvuXb+FyrQV84XwbKLqjVYDf7wuj4lHP8pg8yEVVrj AcP60S7UN1V7xxZT6wLX5Szi+WlaoKkMHupHGUZhXOb8fRp1LGcAjjDv7DVlHIZP6O d8HnLNo6nFJfA== Date: Wed, 3 Apr 2024 11:24:55 +0100 From: Simon Horman To: Nikita Kiryushin Cc: Michael Chan , Pavan Chebbi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Rafael J. Wysocki" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Michael Chan Subject: Re: [PATCH net-next v3] tg3: Remove residual error handling in tg3_suspend Message-ID: <20240403102455.GU26556@kernel.org> References: <20240401191418.361747-1-kiryushin@ancud.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240401191418.361747-1-kiryushin@ancud.ru> On Mon, Apr 01, 2024 at 10:14:18PM +0300, Nikita Kiryushin wrote: > As of now, tg3_power_down_prepare always ends with success, but > the error handling code from former tg3_set_power_state call is still here. > > This code became unreachable in commit c866b7eac073 ("tg3: Do not use > legacy PCI power management"). > > Remove (now unreachable) error handling code for simplification and change > tg3_power_down_prepare to a void function as its result is no more checked. > > Signed-off-by: Nikita Kiryushin > Reviewed-by: Michael Chan Reviewed-by: Simon Horman