Received-SPF: pass (google.com: domain of linux-kernel+bounces-129662-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 3 Apr 2024 13:26:52 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Martino Fontana <tinozzo123@gmail.com>
cc: djogorchock@gmail.com, benjamin.tissoires@redhat.com, 
    linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, 
    Ryan McClelland <rymcclel@gmail.com>
Subject: Re: [PATCH v3 RESEND] HID: nintendo: use ida for LED player id
In-Reply-To: <20240318110145.18490-1-tinozzo123@gmail.com>
Message-ID: <nycvar.YFH.7.76.2404031326430.20263@cbobk.fhfr.pm>
References: <20240318110145.18490-1-tinozzo123@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 18 Mar 2024, Martino Fontana wrote:

> Previously, the leds pattern would just increment with every controller
> connected. This wouldn't take into consideration when controllers are
> disconnected. The same controller could be connected and disconnected
> with the pattern increasing player count each time.
> 
> This patch changes it by using an ID allocator in order to assign the
> player id, the same way hid-playstation does.
> 
> Signed-off-by: Martino Fontana <tinozzo123@gmail.com>
> Signed-off-by: Ryan McClelland <rymcclel@gmail.com>
> ---
> Changes for v2:
> 
> ida_free now frees the correct id, instead of an id that got moduloed.
> 
> Changes for v3:
> 
> Destroy allocator when removing driver.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs