Received-SPF: pass (google.com: domain of linux-kernel+bounces-129665-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 3 Apr 2024 13:34:50 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Christina Quast <contact@christina-quast.de>
cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>, 
    linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, 
    linux-kernel@vger.kernel.org, equinox@diac24.net, 
    Daniel Beer <daniel.beer@igorinstitute.com>, 
    Michael Zaidman <michael.zaidman@gmail.com>
Subject: Re: [PATCH v5] hid-ft260: Add serial driver
In-Reply-To: <20240216-ft260_review5-v5-1-36db44673ac7@christina-quast.de>
Message-ID: <nycvar.YFH.7.76.2404031332560.20263@cbobk.fhfr.pm>
References: <20240216-ft260_review5-v5-1-36db44673ac7@christina-quast.de>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 16 Feb 2024, Christina Quast wrote:

> Adds the serial driver for FT260 USB HID devices, providing direct and
> simplified access to UART functionality without the need for FT260 HID
> report format knowledge.
> 
> This chip implements an UART and I2C interface, but only the latter was
> previously supported with a kernel driver. For the UART interface, only
> FTDI example code using hidraw from userspace was available.
> 
> This commit adds a serial interface /dev/ttyFTx (FT as in FT260), which
> implements tty serial driver ops, facilitating baudrate configuration,
> data transmission and reception, termios settings.

I don't see a dependency on CONFIG_TTY being added, and I believe it 
should be there (even though !CONFIG_TTY configurations are likely 
super-rare).

Thanks,

-- 
Jiri Kosina
SUSE Labs