Received-SPF: pass (google.com: domain of linux-kernel+bounces-129675-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 3 Apr 2024 13:38:12 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Yaraslau Furman <yaro330@gmail.com>
cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>, 
    Lucas Zampieri <lzampier@redhat.com>, 
    =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@riseup.net>, 
    "open list:HID LOGITECH DRIVERS" <linux-input@vger.kernel.org>, 
    open list <linux-kernel@vger.kernel.org>, 
    Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2] HID: logitech-dj: allow mice to report multimedia
 keycodes
In-Reply-To: <20240222101811.18921-1-yaro330@gmail.com>
Message-ID: <nycvar.YFH.7.76.2404031337250.20263@cbobk.fhfr.pm>
References: <20240130111700.11666-1-yaro330@gmail.com> <20240222101811.18921-1-yaro330@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 22 Feb 2024, Yaraslau Furman wrote:

> Multimedia buttons can be bound to the mouse's extra keys in Windows application.
> Let Linux receive those keycodes.
> 
> Signed-off-by: Yaraslau Furman <yaro330@gmail.com>
> ---
>  drivers/hid/hid-logitech-dj.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index e6a8b6d8eab7..3c3c497b6b91 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -965,9 +965,7 @@ static void logi_hidpp_dev_conn_notif_equad(struct hid_device *hdev,
>  		}
>  		break;
>  	case REPORT_TYPE_MOUSE:
> -		workitem->reports_supported |= STD_MOUSE | HIDPP;
> -		if (djrcv_dev->type == recvr_type_mouse_only)
> -			workitem->reports_supported |= MULTIMEDIA;
> +		workitem->reports_supported |= STD_MOUSE | HIDPP | MULTIMEDIA;
>  		break;

CCing Hans who introduced this explicit check back in 3ed224e273ac 
("HID: logitech-dj: Fix 064d:c52f receiver support").
Should it be made device-specific?

-- 
Jiri Kosina
SUSE Labs