Received-SPF: pass (google.com: domain of linux-kernel+bounces-129689-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 3 Apr 2024 13:48:37 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Allen_Lin <allencl_lin@hotmail.com>
cc: dmitry.torokhov@gmail.com, robh@kernel.org, 
    krzysztof.kozlowski+dt@linaro.org, conor@kernel.org, 
    benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, 
    devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] HID: Add support for Himax HX83102j touchscreen
In-Reply-To: <TY0PR06MB561132DF147C037093A1B94D9E3E2@TY0PR06MB5611.apcprd06.prod.outlook.com>
Message-ID: <nycvar.YFH.7.76.2404031347540.20263@cbobk.fhfr.pm>
References: <TY0PR06MB561132DF147C037093A1B94D9E3E2@TY0PR06MB5611.apcprd06.prod.outlook.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 2 Apr 2024, Allen_Lin wrote:

> Hi,
> This driver implements for Himax HID touchscreen HX83102j.
> 
> Using SPI interface to receive/send HID packets.
> 
> Changes in v2 :
> -Added power description in YAML document. 
> -Added ddreset-gpios property in YAML document.
> -Added firmware-name property in YAML document.
> -Modified the description of pid.
> -Modified the example.
> 
> Allen_Lin (4):
>   dt-bindings: input: Add Himax HX83102J touchscreen
>   HID: Add Himax HX83102J touchscreen driver
>   HID: Add DRM panel follower function
>   HID: Load firmware directly from file to IC
> 
>  .../input/touchscreen/himax,hx83102j.yaml     |  100 +
>  MAINTAINERS                                   |    7 +
>  drivers/hid/Kconfig                           |    7 +
>  drivers/hid/Makefile                          |    2 +
>  drivers/hid/hid-himax-83102j.c                | 3071 +++++++++++++++++
>  drivers/hid/hid-himax-83102j.h                |  460 +++

My only nit here -- could we please call the driver just hid-himax, to 
follow the pattern we generally use in this subsystem (drivers named after 
vendors).

Please add Ack from Rob, rename the driver, resend, and I'll apply it. 
Thanks,

-- 
Jiri Kosina
SUSE Labs