Received-SPF: pass (google.com: domain of linux-kernel+bounces-129690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3e8f39e2-ef6d-485d-9a39-a36b04266a62@gmail.com>
Date: Wed, 3 Apr 2024 13:50:21 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH net-next 0/4] net: route: improve route hinting
Content-Language: en-US
To: David Ahern <dsahern@kernel.org>, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, willemb@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240307171202.232684-1-leone4fernando@gmail.com>
 <9ce73c04-ee8f-4aa5-ab15-c31dbe409401@kernel.org>
 <4bf87e9a-71a4-4586-a112-43f8ce20eb46@gmail.com>
 <2893a096-c07d-4ba3-85a8-db18616810f3@kernel.org>
From: Leone Fernando <leone4fernando@gmail.com>
In-Reply-To: <2893a096-c07d-4ba3-85a8-db18616810f3@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi David,

> 
> For the rest of it, Jakub's response was a good summary: it is hard to
> know if there is a benefit to real workloads. Cache's consume resources
> (memory and cpu) and will be wrong some percentage of the time
> increasing overhead.
> 

I understand what you are saying here.
Do you have an idea for extra tests or measurements to make sure
the patch also improves in real workloads?

> Also, it is targeted at a very narrow use case -- IPv4 only, no custom
> FIB rules and no multipath.

Implementation for IPv6 is almost identical. I decided to start with IPv4 
and I plan to submit IPv6 support in a future patch. 
This patch basically improves the hinting mechanism that Paolo introduced
and it handles the same cases.
Adding support for FIB rules and multipath is a bit more complicated but 
also possible. I am willing to keep working on this patch to meet the 
remaining cases including IPv6.

Thanks,
Leone