Received-SPF: pass (google.com: domain of linux-kernel+bounces-129696-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: "Wu, Wentong" <wentong.wu@intel.com>, "sakari.ailus@linux.intel.com"
	<sakari.ailus@linux.intel.com>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Yao, Hao"
	<hao.yao@intel.com>, "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] Revert "mei: vsc: Call wake_up() in the threaded
 IRQ handler"
Thread-Topic: [PATCH v2 1/2] Revert "mei: vsc: Call wake_up() in the threaded
 IRQ handler"
Thread-Index: AQHahYLJaiVrRgbWd0aEvs3QZGIaRbFWceTg
Date: Wed, 3 Apr 2024 12:00:28 +0000
Message-ID: <PH7PR11MB7605A0653F755C3D5ABFED9EE53D2@PH7PR11MB7605.namprd11.prod.outlook.com>
References: <20240403051341.3534650-1-wentong.wu@intel.com>
In-Reply-To: <20240403051341.3534650-1-wentong.wu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gPt1fcFICwX+isoKBtn1+j9h+kgyNJ8bYp6LlEAgMgsxezRnE7tclouGDTSs?=
 =?us-ascii?Q?6GowQrgFDrYDDP38KQnso8f3BFsVcIzuRMq+Oa7Ycdexcl47nJFMC4l5IOJw?=
 =?us-ascii?Q?IG2rQeHBZX5U7zW2QrHDKoO6UYPPtaVnCZ3bs/hcd2boFmBmpHh/ikjL4fjM?=
 =?us-ascii?Q?DZYzLKGy3nSxArs4xFbicypBJYdx9PWYSXIv8lbZDSkMWNEqawbrq2LS0hx4?=
 =?us-ascii?Q?L1vo3EUGhkOe120Iub5IdiYjJX+3aCuZmtDErByrt0H9g3EHp0BPJwNAe3Vh?=
 =?us-ascii?Q?y4GhVe4p30pb5cQj4bYRpuGpYJ6hHoVYGJXFoBPrSEcN04DY8YoJZ4W0OIvC?=
 =?us-ascii?Q?4fHO6m6yqC3s3uHy+Z3K+Sm+g19q+pgNhe8UjdSGMs+kbD0loLmpi2jt1kx8?=
 =?us-ascii?Q?uHwNBStP79HNFxwqi/rnYmkSMJMOMmijAKw+njtpxvHSpUHXCZ3jRKI6WlDp?=
 =?us-ascii?Q?OJYV/0DG+2w02g4+bmC7ICCJR5pVbg9mXtWG0SV1/FkPwjYZPDvMMiKr+Ney?=
 =?us-ascii?Q?uczIoAA3MUDw3uqjbEzi/VWnEG+pvb+WTi6cBH+IL1cxkgx9QmMNiDztGYpJ?=
 =?us-ascii?Q?sV+NXwKrZQevv48bUzW/nXcBrwxPr7i0bKpPAoAeC/6UGQotFF7s/eCCSSWz?=
 =?us-ascii?Q?TGKKX2NrKQewGlUtC91nl7TZZrGCG/0LDJRpjKNq9FJVfeVS40P5IES/BvN0?=
 =?us-ascii?Q?4FTwDPi+IN75OTVMfiWw2aqVV1KnYO5SR19KKZDUL4RVJaSYX/lh9pfhrbqV?=
 =?us-ascii?Q?8kiTEEJCt80VB1AsluADyTyCEnpipGwdpBPf8zItHAXJkvZdsRwEIq+Hw/8N?=
 =?us-ascii?Q?J9feFuOwWzBna5hEz50LYU7rc9trDaimdpP0p/2wDu4ASWcTUoRIoqjatrnx?=
 =?us-ascii?Q?G0FpW8Mu+3l/UmeXu996xYTLggze1fyGcabym8z/9uTSR1LoEKTbYNzs4M9D?=
 =?us-ascii?Q?gpaWdXS6MinCdbLDAPg347vIy4jYhvhsLHk6/ZQihUmeH0Dbdbi7q7zRnI0p?=
 =?us-ascii?Q?AHmE3qXzd9iNu+3z8wmmdkQbVUoL9nVGs6AZVc5Yto5ykW12Ke5H7oNBHRnl?=
 =?us-ascii?Q?jBmhGQhs3YWIaskINPcUezgAk6ivVthB5urCFbbXO/gUdbJNa/IPaGoB4xzr?=
 =?us-ascii?Q?N2JrKOFrw2r5MfyW1fjptxv/ugDV7aLZvIXLkYDzKoSPX3ro0zovYRPgCzyC?=
 =?us-ascii?Q?1riqoBGIaYTwwW3prSbKqnOYmL/c/jIrSCpYaAokUZ8/dnJBpBZ26J8yaQYM?=
 =?us-ascii?Q?vb/5w8mCidi/fi666p4W3ms4QS9Ie2fqO8jae1YRs5ghJr69FM++in71OFtf?=
 =?us-ascii?Q?4M3AheqEb1mzN3dCu9Kehf2LF+OCyT3bb2P7mmbWh3CA2ODQ8sjDDspEEmNi?=
 =?us-ascii?Q?pOwlaXZDZ3LPyDHFIq4JiFfL0B2teXLjP5wbqQmBoWqM4liNKkPDv3oFK437?=
 =?us-ascii?Q?eTJ0XfFdUE1ypRSHD76jh1QVFSiY7sFtHIbofRzp+HRC2Uy3xvOF185vlw8I?=
 =?us-ascii?Q?Q+31h4x4BC7fGCzJzMiYdFdNvy6DxyDliK7x27ajXtm0bcyX8PIe8CWjF1ed?=
 =?us-ascii?Q?6xIMaJxGHBg3vVLAPaDmRxsSwQGbDZsd0vbAXfMu?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB7605.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ade5054-03cb-4a40-2dd2-08dc53d5a7c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2024 12:00:28.6940
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Vk8pNLsphGxq3aCf7io+n/VeHFDKQNVOGHUmxMaM7ILbPtMfUcP7FcIZyJx0HS56i+EgQ4ta92LsZ6dn712GBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7771
X-OriginatorOrg: intel.com

> handler"
>=20
> From: Sakari Ailus <sakari.ailus@linux.intel.com>
>=20
> This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984.
>=20
> It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in=
 an
> interrupt handler as the interrupt handler itself would be called in a pr=
ocess
> context if PREEMPT_RT is enabled. So revert the patch.
>=20
> Cc: stable@vger.kernel.org # for 6.8
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/misc/mei/vsc-tp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> ecfb70cd057c..968a92a7425d 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)
>=20
>  	atomic_inc(&tp->assert_cnt);
>=20
> +	wake_up(&tp->xfer_wait);
> +
>  	return IRQ_WAKE_THREAD;
>  }
>=20
> @@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void
> *data)  {
>  	struct vsc_tp *tp =3D data;
>=20
> -	wake_up(&tp->xfer_wait);
> -
>  	if (tp->event_notify)
>  		tp->event_notify(tp->event_notify_context);
>=20
> --
> 2.34.1