Received-SPF: pass (google.com: domain of linux-kernel+bounces-129320-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 3 Apr 2024 11:21:02 +0300 (EEST)
To: Luke Jones <luke@ljones.dev>
cc: Hans de Goede <hdegoede@redhat.com>, corentin.chary@gmail.com, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/9] platform/x86: asus-wmi: store a min default for
 ppt options
In-Reply-To: <4555327.yiUUSuA9gR@fedora>
Message-ID: <678014c5-5d2d-7128-88ea-c71a71410dd3@linux.intel.com>
References: <20240402022607.34625-1-luke@ljones.dev> <20240402022607.34625-6-luke@ljones.dev> <89b0c0ea-30ce-28c6-19d2-ebd113b17935@linux.intel.com> <4555327.yiUUSuA9gR@fedora>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-667445792-1712132462=:1449"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-667445792-1712132462=:1449
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 3 Apr 2024, Luke Jones wrote:

> On Tuesday, 2 April 2024 11:49:50=E2=80=AFPM NZDT Ilpo J=C3=A4rvinen wrot=
e:
> > On Tue, 2 Apr 2024, Luke D. Jones wrote:
> > > Laptops with any of the ppt or nv tunables default to the minimum set=
ting
> > > on boot so we can safely assume a stored value is correct.
> > >=20
> > > This patch adds storing of those values in the local struct, and enab=
les
> > > reading of those values back. To prevent creating a series of byte ho=
les
> > > in the struct the "<name>_available" bool is removed and
> > > `asus_sysfs_is_visible()` uses the `ASUS_WMI_DEVID_<name>` directly.
> > >=20
> > > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > > ---
> > >=20
> > >  drivers/platform/x86/asus-wmi.c | 127 +++++++++++++++++++++++++-----=
--
> > >  1 file changed, 99 insertions(+), 28 deletions(-)
> > >=20
> > > diff --git a/drivers/platform/x86/asus-wmi.c
> > > b/drivers/platform/x86/asus-wmi.c index b795f9c1941f..c80afa385532 10=
0644
> > > --- a/drivers/platform/x86/asus-wmi.c
> > > +++ b/drivers/platform/x86/asus-wmi.c
> > > @@ -262,13 +262,13 @@ struct asus_wmi {
> > >=20
> > >  =09u32 gpu_mux_dev;
> > >  =09
> > >  =09/* Tunables provided by ASUS for gaming laptops */
> > >=20
> > > -=09bool ppt_pl2_sppt_available;
> > > -=09bool ppt_pl1_spl_available;
> > > -=09bool ppt_apu_sppt_available;
> > > -=09bool ppt_plat_sppt_available;
> > > -=09bool ppt_fppt_available;
> > > -=09bool nv_dyn_boost_available;
> > > -=09bool nv_temp_tgt_available;
> > > +=09u32 ppt_pl2_sppt;
> > > +=09u32 ppt_pl1_spl;
> > > +=09u32 ppt_apu_sppt;
> > > +=09u32 ppt_platform_sppt;
> > > +=09u32 ppt_fppt;
> > > +=09u32 nv_dynamic_boost;
> > > +=09u32 nv_temp_target;
> > >=20
> > >  =09u32 kbd_rgb_dev;
> > >  =09bool kbd_rgb_state_available;
> > >=20
> > > @@ -1020,11 +1020,21 @@ static ssize_t ppt_pl2_sppt_store(struct devi=
ce
> > > *dev,>=20
> > >  =09=09return -EIO;
> > >  =09
> > >  =09}
> > >=20
> > > +=09asus->ppt_pl2_sppt =3D value;
> > >=20
> > >  =09sysfs_notify(&asus->platform_device->dev.kobj, NULL,=20
> "ppt_pl2_sppt");
> > >  =09
> > >  =09return count;
> > > =20
> > >  }
> > >=20
> > > -static DEVICE_ATTR_WO(ppt_pl2_sppt);
> > > +
> > > +static ssize_t ppt_pl2_sppt_show(struct device *dev,
> > > +=09=09=09=09       struct device_attribute=20
> *attr,
> > > +=09=09=09=09       char *buf)
> > > +{
> > > +=09struct asus_wmi *asus =3D dev_get_drvdata(dev);
> > > +
> > > +=09return sysfs_emit(buf, "%d\n", asus->ppt_pl2_sppt);
> >=20
> > Use %u for u32 values. This applies to all sysfs_emits in this patch.
>=20
> Thought checkpatch or the compiler would catch that. Done.
>=20
> I've added your reviewed tag due to the simplicity of the change requeste=
d. I=20
> hope this was okay.

Hi,

Please don't add Reviewed-by tags automatically in the future. Its=20
meaning is not that the person has looked the patch.

--=20
 i.

--8323328-667445792-1712132462=:1449--