Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2684947lqz; Wed, 3 Apr 2024 05:58:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXq1ws3fDZy0OYDmCsKRaAxEzrHRSTTPPUiANlXffBop8biVq9uX3Q62jQi/ifhU3TfsP0VxnhfSl4POuDywxX8387FPKxv0DOxSW4m/g== X-Google-Smtp-Source: AGHT+IF0x2Wfxg8ZiWxG0eqp72HqJSHr/C4SUEPAzA6Y+/q3EhhKyySsY+5r5FVtZeDmqYocAWv+ X-Received: by 2002:a05:622a:156:b0:430:e9fb:2c37 with SMTP id v22-20020a05622a015600b00430e9fb2c37mr2584428qtw.46.1712149120271; Wed, 03 Apr 2024 05:58:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712149120; cv=pass; d=google.com; s=arc-20160816; b=WXhupngWmTNARV0Aq7dlf2YIR2AAb0UC3/dYmQlyUBHsIO2TTK3lkE1SskaH5Ecae5 6UiVhO5qZYlvtydTJXuQ5WP7PMPGN6JtzMaZFlgL/uCHs3jqMXsJMuBttjsqEcwaRd/N xFE8MZjNEmYaY3rTxgJcNIpJn3cRwtoWUpxkor9Ly/37ihLyJ0tJDG0EziHCleqdrreE blzhEA0CG6jBNROFW1/pNiHtohHNRCSXoiylCPlXU3R7zY5P9mQBvDHHSseHhriGTtnk n6wV9SYxBkckWWiJxDj1In5zHwb5S+LAJiyKXzBALekWQNFoReHDTHkFrbTyDlASwnyx alzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=5DGnORPv79MmjGVc5naevaHP+scfzBDnCLP3n2Z3Y4Q=; fh=OTg2WMHJtOqcpGTWyrCVDzG+wPN5q7xsQc52pUkpGv8=; b=YF9wGpPRV9+j4V9MABpuKapZGvBXubFCP+642Z2r4JyP5eUMQfdvWdmUG5PAhpmZd5 xQh1zYyYoqD/PuIFC4C0Hn87DBLrnZCa2uEopIWSWckzhTIcT3ibkmmZmLE3kw3yB0s1 +0LadouEcwQIQmrPJpt8xbmJF6xfKyOONrt6toLj8FcU6oUcaSeB0AtmiKnzB9TqEyq0 oXrqSxZvoPTldHM/x8ilC/pbuuQOIqKc6GJTQWpqRJySeeHdOU0csl8rMyqofxvvvYcM MEIxaFZa2my+43g2QZBTC0gyFyxYIA7Ahty2zag4o3VOx25j3qnyJvNXBxs0OdkyXQxZ F2rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eLOuqIBk; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-129762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129762-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h8-20020ac85e08000000b004315e7602d3si14361295qtx.611.2024.04.03.05.58.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 05:58:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-129762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eLOuqIBk; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-129762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-129762-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DDFBF1C20C6F for ; Wed, 3 Apr 2024 12:58:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 220D1147C98; Wed, 3 Apr 2024 12:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eLOuqIBk" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC7DD146A63 for ; Wed, 3 Apr 2024 12:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712149109; cv=none; b=D2nR7V051wse0PZEOpqHKAaGiarB2HhfresI043rPNFIiefj2qf053Y54Q9UkqIEWCX4Aj30hq6Yd+W/mGbdqO57fwVDBVFv2w56cPmrlzn8vlJyJB8wpx/uvIspS9Yvs8C6oiUygcFPvsueODc0otQ7LxrGIoyGxJIKzmZDKzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712149109; c=relaxed/simple; bh=DAkeTo88/Q8SBcOAB+webgQsBX2i+Ci1XmPfSwoxQ0Q=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=eCrmS+WYIS7YGelIkry33EJyp0vdq7MlWhOAQBClf9UIC0no+n7gUSpIIX9x9RM99GMYixrmnceI6FaRdyzm+Ilt4CXTFMwoe3yODLpdKRYB5N3H96kFRG+c7L41aAeMpmgQJsx9fycJh2bKqf3onOxOWr16y8e22J6JTUtqViU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eLOuqIBk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712149107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5DGnORPv79MmjGVc5naevaHP+scfzBDnCLP3n2Z3Y4Q=; b=eLOuqIBkzgg08Ss24ikz2T0ftxc9pO9Ihm+V1lFUSLfwiF+xwUn93GwkiCj9X+dgHhNotq /+XpHO4HNpP4zGLZQGIa8NytakpI3PbYpMqz3t3wUtDlO5p1v2lSEtcPa4aZx6yeedu/vA CN8IGDbZ9uqC0wyS7JlMFsxf4h+wt8w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-dz7FoxU5NrCenslQwwmFtQ-1; Wed, 03 Apr 2024 08:58:24 -0400 X-MC-Unique: dz7FoxU5NrCenslQwwmFtQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E932785A588; Wed, 3 Apr 2024 12:58:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id E17DAC04122; Wed, 3 Apr 2024 12:58:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240403124124.GA19085@lst.de> References: <20240403124124.GA19085@lst.de> <20240403101422.GA7285@lst.de> <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> <3300438.1712141700@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3326106.1712149095.1@warthog.procyon.org.uk> Date: Wed, 03 Apr 2024 13:58:15 +0100 Message-ID: <3326107.1712149095@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Christoph Hellwig wrote: > > So why are we bothering with EXPORT_SYMBOL at all? Why don't you just > > send a patch replace all of them with EXPORT_SYMBOL_GPL()? > > No my business. Clearly it is as you're gradually replacing APIs with stuff that is GPL'd. > But if you want to side track this let me just put this in here: > > NAK to the non-GPL EXPORT of writeback_iter(). Very well, I'll switch that export to GPL. Christian, if you can amend that patch in your tree? David