Received-SPF: pass (google.com: domain of linux-kernel+bounces-129833-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 3 Apr 2024 15:27:01 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-kernel@vger.kernel.org, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, 
	Alexandre Torgue <alexandre.torgue@foss.st.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Arnd Bergmann <arnd@arndb.de>, linux-input@vger.kernel.org, 
	linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/34] Input: stmpe-ts - mark OF related data as maybe
 unused
Message-ID: <wmd4z6bgy25tdzfch5a5p2gxtj35qyljo5t6babc773yaajeja@tefjvvrshykl>
References: <20240403080702.3509288-1-arnd@kernel.org>
 <20240403080702.3509288-8-arnd@kernel.org>
 <gh4slqpbzul67vni6hv2opjuvccokfwqnnroxbpqt5oc3kiz65@nbqaxhwltb3z>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lwhm5g33cm24lkxt"
Content-Disposition: inline
In-Reply-To: <gh4slqpbzul67vni6hv2opjuvccokfwqnnroxbpqt5oc3kiz65@nbqaxhwltb3z>


--lwhm5g33cm24lkxt
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello again,

On Wed, Apr 03, 2024 at 03:17:32PM +0200, Uwe Kleine-K=F6nig wrote:
> On Wed, Apr 03, 2024 at 10:06:25AM +0200, Arnd Bergmann wrote:
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >=20
> > When compile tested with W=3D1 on x86_64 with driver as built-in:
> >=20
> >   stmpe-ts.c:371:34: error: unused variable 'stmpe_ts_ids' [-Werror,-Wu=
nused-const-variable]
> >=20
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touch=
screen/stmpe-ts.c
> > index b204fdb2d22c..022b3e94266d 100644
> > --- a/drivers/input/touchscreen/stmpe-ts.c
> > +++ b/drivers/input/touchscreen/stmpe-ts.c
> > @@ -366,7 +366,7 @@ static struct platform_driver stmpe_ts_driver =3D {
> >  };
> >  module_platform_driver(stmpe_ts_driver);
> > =20
> > -static const struct of_device_id stmpe_ts_ids[] =3D {
> > +static const struct of_device_id stmpe_ts_ids[] __maybe_unused =3D {
> >  	{ .compatible =3D "st,stmpe-ts", },
> >  	{ },
> >  };
>=20
> I'd suggest the following instead:
>=20
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchsc=
reen/stmpe-ts.c
> index b204fdb2d22c..e1afebc641ec 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -357,21 +357,22 @@ static void stmpe_ts_remove(struct platform_device =
*pdev)
>  	stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN);
>  }
> =20
> -static struct platform_driver stmpe_ts_driver =3D {
> -	.driver =3D {
> -		.name =3D STMPE_TS_NAME,
> -	},
> -	.probe =3D stmpe_input_probe,
> -	.remove_new =3D stmpe_ts_remove,
> -};
> -module_platform_driver(stmpe_ts_driver);
> -
>  static const struct of_device_id stmpe_ts_ids[] =3D {
>  	{ .compatible =3D "st,stmpe-ts", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, stmpe_ts_ids);
> =20
> +static struct platform_driver stmpe_ts_driver =3D {
> +	.driver =3D {
> +		.name =3D STMPE_TS_NAME,
> +		.of_match_table =3D stmpe_ts_ids,
> +	},
> +	.probe =3D stmpe_input_probe,
> +	.remove_new =3D stmpe_ts_remove,
> +};
> +module_platform_driver(stmpe_ts_driver);
> +
>  MODULE_AUTHOR("Luotao Fu <l.fu@pengutronix.de>");
>  MODULE_DESCRIPTION("STMPEXXX touchscreen driver");
>  MODULE_LICENSE("GPL");
>=20
> I wonder if with the status quo binding via dt works at all with
> stmpe_ts_driver.driver.of_match_table unset?!

I missed the discussion between Andy and Krzysztof when I wrote my mail.
I still think this should be considered and if .of_match_table should
stay unassigned (e.g. to allow dropping stmpe_ts_ids in case the driver
is built-in?) I think adding a code comment would be appropriate because
having an of_device_id array but not adding it to the driver is unusuall
and generally a bad template for new drivers.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--lwhm5g33cm24lkxt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYNWSQACgkQj4D7WH0S
/k6SBQf/boQclIHZWoNQ1TuZG4XA4b8YelwZEdTd65NHDS6BeEIoqmURpv3FhZDn
BLm5Xa52CQnqKSJPtc/xPF7cf4RygvQy1IQeQo05VgSWpdilHEHfQ5ni24FBkamZ
oEEpGMyfTzYABRHbJ5HBP9E5lXeIuf6Sydod5a7jhYTYLqnZYv0aLOWU5veHZydV
OChe/wSCmysu058/7iLNUoHOPk3KBIL0DTzqY1LQXFa+LKX3JInzTgm0yvOVcOKa
sjrLsZi7v55hB1Xr1G0WuCuneCTeVz3w5jI/8NbbdGd7dp/530fNvKtIA5LN1uZS
wnVuxRH+MiZXchlhoWFVvfFWLa1vZg==
=fXp2
-----END PGP SIGNATURE-----

--lwhm5g33cm24lkxt--